Title: [149188] trunk/Source/WebCore
Revision
149188
Author
allan.jen...@digia.com
Date
2013-04-26 09:08:21 -0700 (Fri, 26 Apr 2013)

Log Message

Assert in JSC::Heap::unprotect when closing facebook.com web site
https://bugs.webkit.org/show_bug.cgi?id=115058

Reviewed by Darin Adler.

Grab a JSLock before calling RootObject::invalidate().

* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::~ScriptController):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (149187 => 149188)


--- trunk/Source/WebCore/ChangeLog	2013-04-26 15:17:59 UTC (rev 149187)
+++ trunk/Source/WebCore/ChangeLog	2013-04-26 16:08:21 UTC (rev 149188)
@@ -1,3 +1,15 @@
+2013-04-26  Allan Sandfeld Jensen  <allan.jen...@digia.com>
+
+        Assert in JSC::Heap::unprotect when closing facebook.com web site
+        https://bugs.webkit.org/show_bug.cgi?id=115058
+
+        Reviewed by Darin Adler.
+
+        Grab a JSLock before calling RootObject::invalidate().
+
+        * bindings/js/ScriptController.cpp:
+        (WebCore::ScriptController::~ScriptController):
+
 2013-04-26  Eric Carlson  <eric.carl...@apple.com>
 
         [Mac] in-band cues sometimes have incorrect duration

Modified: trunk/Source/WebCore/bindings/js/ScriptController.cpp (149187 => 149188)


--- trunk/Source/WebCore/bindings/js/ScriptController.cpp	2013-04-26 15:17:59 UTC (rev 149187)
+++ trunk/Source/WebCore/bindings/js/ScriptController.cpp	2013-04-26 16:08:21 UTC (rev 149188)
@@ -82,6 +82,7 @@
     disconnectPlatformScriptObjects();
 
     if (m_cacheableBindingRootObject) {
+        JSLockHolder lock(JSDOMWindowBase::commonVM());
         m_cacheableBindingRootObject->invalidate();
         m_cacheableBindingRootObject = 0;
     }
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to