Title: [150069] trunk/Source/WebCore
- Revision
- 150069
- Author
- commit-qu...@webkit.org
- Date
- 2013-05-14 07:29:57 -0700 (Tue, 14 May 2013)
Log Message
Remove RenderTheme::supportsCalendarPicker
https://bugs.webkit.org/show_bug.cgi?id=116068
Patch by Daker Fernandes Pinheiro <daker.pinhe...@openbossa.org> on 2013-05-14
Reviewed by Benjamin Poulain.
No new tests needed because it doesn't affect behaviour.
This method was never overrided by any platform
and always leaded to the same behaviour.
The code which depended on it was also removed.
* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
(WebCore::BaseMultipleFieldsDateAndTimeInputType::updatePickerIndicatorVisibility):
* html/BaseMultipleFieldsDateAndTimeInputType.h:
(BaseMultipleFieldsDateAndTimeInputType):
* page/ChromeClient.h:
(ChromeClient):
* rendering/RenderTheme.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (150068 => 150069)
--- trunk/Source/WebCore/ChangeLog 2013-05-14 12:54:06 UTC (rev 150068)
+++ trunk/Source/WebCore/ChangeLog 2013-05-14 14:29:57 UTC (rev 150069)
@@ -1,3 +1,25 @@
+2013-05-14 Daker Fernandes Pinheiro <daker.pinhe...@openbossa.org>
+
+ Remove RenderTheme::supportsCalendarPicker
+ https://bugs.webkit.org/show_bug.cgi?id=116068
+
+ Reviewed by Benjamin Poulain.
+
+ No new tests needed because it doesn't affect behaviour.
+
+ This method was never overrided by any platform
+ and always leaded to the same behaviour.
+ The code which depended on it was also removed.
+
+ * html/BaseMultipleFieldsDateAndTimeInputType.cpp:
+ (WebCore::BaseMultipleFieldsDateAndTimeInputType::createShadowSubtree):
+ (WebCore::BaseMultipleFieldsDateAndTimeInputType::updatePickerIndicatorVisibility):
+ * html/BaseMultipleFieldsDateAndTimeInputType.h:
+ (BaseMultipleFieldsDateAndTimeInputType):
+ * page/ChromeClient.h:
+ (ChromeClient):
+ * rendering/RenderTheme.h:
+
2013-04-30 Balazs Kelemen <b.kele...@sisa.samsung.com>
[GStreamer] cannot seek after video finished
Modified: trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp (150068 => 150069)
--- trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp 2013-05-14 12:54:06 UTC (rev 150068)
+++ trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.cpp 2013-05-14 14:29:57 UTC (rev 150069)
@@ -311,11 +311,6 @@
if (InputType::themeSupportsDataListUI(this))
shouldAddPickerIndicator = true;
#endif
- RefPtr<RenderTheme> theme = document->page() ? document->page()->theme() : RenderTheme::defaultTheme();
- if (theme->supportsCalendarPicker(formControlType())) {
- shouldAddPickerIndicator = true;
- m_pickerIndicatorIsAlwaysVisible = true;
- }
if (shouldAddPickerIndicator) {
RefPtr<PickerIndicatorElement> pickerElement = PickerIndicatorElement::create(document, *this);
m_pickerIndicatorElement = pickerElement.get();
@@ -511,10 +506,6 @@
void BaseMultipleFieldsDateAndTimeInputType::updatePickerIndicatorVisibility()
{
- if (m_pickerIndicatorIsAlwaysVisible) {
- showPickerIndicator();
- return;
- }
#if ENABLE(DATALIST_ELEMENT)
if (HTMLDataListElement* dataList = element()->dataList()) {
RefPtr<HTMLCollection> options = dataList->options();
Modified: trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.h (150068 => 150069)
--- trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.h 2013-05-14 12:54:06 UTC (rev 150068)
+++ trunk/Source/WebCore/html/BaseMultipleFieldsDateAndTimeInputType.h 2013-05-14 14:29:57 UTC (rev 150069)
@@ -121,7 +121,6 @@
ClearButtonElement* m_clearButton;
PickerIndicatorElement* m_pickerIndicatorElement;
bool m_pickerIndicatorIsVisible;
- bool m_pickerIndicatorIsAlwaysVisible;
};
} // namespace WebCore
Modified: trunk/Source/WebCore/page/ChromeClient.h (150068 => 150069)
--- trunk/Source/WebCore/page/ChromeClient.h 2013-05-14 12:54:06 UTC (rev 150068)
+++ trunk/Source/WebCore/page/ChromeClient.h 2013-05-14 14:29:57 UTC (rev 150069)
@@ -228,8 +228,6 @@
#if ENABLE(DATE_AND_TIME_INPUT_TYPES)
// This function is used for:
// - Mandatory date/time choosers if !ENABLE(INPUT_MULTIPLE_FIELDS_UI)
- // - Date/time choosers for types for which RenderTheme::supportsCalendarPicker
- // returns true, if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
// - <datalist> UI for date/time input types regardless of
// ENABLE(INPUT_MULTIPLE_FIELDS_UI)
virtual PassRefPtr<DateTimeChooser> openDateTimeChooser(DateTimeChooserClient*, const DateTimeChooserParameters&) = 0;
Modified: trunk/Source/WebCore/rendering/RenderTheme.h (150068 => 150069)
--- trunk/Source/WebCore/rendering/RenderTheme.h 2013-05-14 12:54:06 UTC (rev 150068)
+++ trunk/Source/WebCore/rendering/RenderTheme.h 2013-05-14 14:29:57 UTC (rev 150069)
@@ -136,11 +136,6 @@
// A method asking if the platform is able to show datalist suggestions for a given input type.
virtual bool supportsDataListUI(const AtomicString&) const { return false; }
-#if ENABLE(INPUT_MULTIPLE_FIELDS_UI)
- // A method asking if the platform is able to show a calendar picker for a given input type.
- virtual bool supportsCalendarPicker(const AtomicString&) const { return false; }
-#endif
-
// Text selection colors.
Color activeSelectionBackgroundColor() const;
Color inactiveSelectionBackgroundColor() const;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
