Title: [151606] trunk/Source/WebCore
- Revision
- 151606
- Author
- jer.no...@apple.com
- Date
- 2013-06-14 14:55:48 -0700 (Fri, 14 Jun 2013)
Log Message
REGRESSION (r150651): Web Audio doesn't work at all (silence or squawks) on Mountain Lion
https://bugs.webkit.org/show_bug.cgi?id=117652
Reviewed by Eric Carlson.
r150651 disabled setting the buffer size to a large value, but in so doing, also
disabled setting the buffer size to a small value for Web Audio. Narrow the Mountain
Lion protection to just the <video> element case.
* platform/audio/mac/AudioSessionManagerMac.cpp:
(AudioSessionManager::updateSessionState):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (151605 => 151606)
--- trunk/Source/WebCore/ChangeLog 2013-06-14 20:36:33 UTC (rev 151605)
+++ trunk/Source/WebCore/ChangeLog 2013-06-14 21:55:48 UTC (rev 151606)
@@ -1,3 +1,17 @@
+2013-06-14 Jer Noble <jer.no...@apple.com>
+
+ REGRESSION (r150651): Web Audio doesn't work at all (silence or squawks) on Mountain Lion
+ https://bugs.webkit.org/show_bug.cgi?id=117652
+
+ Reviewed by Eric Carlson.
+
+ r150651 disabled setting the buffer size to a large value, but in so doing, also
+ disabled setting the buffer size to a small value for Web Audio. Narrow the Mountain
+ Lion protection to just the <video> element case.
+
+ * platform/audio/mac/AudioSessionManagerMac.cpp:
+ (AudioSessionManager::updateSessionState):
+
2013-06-14 Ryosuke Niwa <rn...@webkit.org>
Function names on Object.prototype should be common identifiers
Modified: trunk/Source/WebCore/platform/audio/mac/AudioSessionManagerMac.cpp (151605 => 151606)
--- trunk/Source/WebCore/platform/audio/mac/AudioSessionManagerMac.cpp 2013-06-14 20:36:33 UTC (rev 151605)
+++ trunk/Source/WebCore/platform/audio/mac/AudioSessionManagerMac.cpp 2013-06-14 21:55:48 UTC (rev 151606)
@@ -37,13 +37,13 @@
void AudioSessionManager::updateSessionState()
{
- // FIXME: <http://webkit.org/b/116725> Figure out why enabling the code below
- // causes media LayoutTests to fail on 10.8.
-#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
LOG(Media, "AudioSessionManager::updateSessionState() - types: Video(%d), Audio(%d), WebAudio(%d)", m_typeCount.count(Video), m_typeCount.count(Audio), m_typeCount.count(WebAudio));
if (has(WebAudio))
AudioSession::sharedSession().setPreferredBufferSize(kWebAudioBufferSize);
+ // FIXME: <http://webkit.org/b/116725> Figure out why enabling the code below
+ // causes media LayoutTests to fail on 10.8.
+#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
else if (has(Video) || has(Audio))
AudioSession::sharedSession().setPreferredBufferSize(kLowPowerVideoBufferSize);
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
