[webkit-changes] [151656] trunk/Source

Mon, 17 Jun 2013 14:50:37 -0700

Title: [151656] trunk/Source
Revision
151656
Author
commit-qu...@webkit.org
Date
2013-06-17 14:50:55 -0700 (Mon, 17 Jun 2013)

Log Message

REGRESSION: Important controls are missing from <video> element UI, when compared to QuickTime
https://bugs.webkit.org/show_bug.cgi?id=20599

Add a "Download Video"/"Download Audio" context menu item to download media
elements.

Patch by Ruth Fong <ruth_f...@apple.com> on 2013-06-17
Reviewed by Beth Dakin.

Source/WebCore:

No new tests. media/context-menu-action.html,
which has been disabled by bug 116651, is used to test context menus.

* English.lproj/Localizable.strings: Updated to
include localizable strings for "Download Video" and "Download Audio".

* page/ContextMenuController.cpp: Updated to
include and handle a "Download Video/Audio" context menu item.

* platform/ContextMenuItem.h:

* platform/LocalizedStrings.cpp:
* platform/LocalizedStrings.h:
* platform/efl/LocalizedStringsEfl.cpp:
* platform/gtk/LocalizedStringsGtk.cpp:
* platform/qt/LocalizedStringsQt.cpp:
Updated to include localizable strings for "Download Video" and "Download Audio".

Source/WebKit/efl:

* WebCoreSupport/AssertMatchingEnums.cpp:
* ewk/ewk_contextmenu.h:
Updated to include new EWK enum type for "Download Video/Audio" context menu item.

Source/WebKit2:

* Shared/API/c/WKContextMenuItemTypes.h: Updated to include
an enum type for the "Download Video/Audio" context menu item.

* Shared/API/c/WKSharedAPICast.h: Updated to associate
the enums in WebKit and WebCore that handle the "Download Video/Audio"
context menu item.

* UIProcess/API/efl/ewk_context_menu.cpp:
* UIProcess/API/efl/ewk_context_menu_item.cpp:
* UIProcess/API/efl/ewk_context_menu_item.h:
Updated to include new EWK enum type for "Download Video/Audio" context menu item.

* UIProcess/WebPageProxy.cpp: Updated to
handle the "Download Video/Audio" context menu item mouse click
and download the media item in the UI process.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (151655 => 151656)


--- trunk/Source/WebCore/ChangeLog	2013-06-17 21:27:00 UTC (rev 151655)
+++ trunk/Source/WebCore/ChangeLog	2013-06-17 21:50:55 UTC (rev 151656)
@@ -1,3 +1,31 @@
+2013-06-17  Ruth Fong  <ruth_f...@apple.com>
+
+        REGRESSION: Important controls are missing from <video> element UI, when compared to QuickTime
+        https://bugs.webkit.org/show_bug.cgi?id=20599
+
+        Add a "Download Video"/"Download Audio" context menu item to download media
+        elements.
+
+        Reviewed by Beth Dakin.
+
+        No new tests. media/context-menu-action.html,
+        which has been disabled by bug 116651, is used to test context menus.
+
+        * English.lproj/Localizable.strings: Updated to
+        include localizable strings for "Download Video" and "Download Audio".
+
+        * page/ContextMenuController.cpp: Updated to 
+        include and handle a "Download Video/Audio" context menu item.
+
+        * platform/ContextMenuItem.h:
+
+        * platform/LocalizedStrings.cpp: 
+        * platform/LocalizedStrings.h:
+        * platform/efl/LocalizedStringsEfl.cpp:
+        * platform/gtk/LocalizedStringsGtk.cpp:
+        * platform/qt/LocalizedStringsQt.cpp: 
+        Updated to include localizable strings for "Download Video" and "Download Audio".
+
 2013-06-17  Zoltan Horvath  <zol...@webkit.org>
 
         [CSS Shapes] Consider bottom borders when calculating the position of the overflow

Modified: trunk/Source/WebCore/English.lproj/Localizable.strings (151655 => 151656)


--- trunk/Source/WebCore/English.lproj/Localizable.strings	2013-06-17 21:27:00 UTC (rev 151655)
+++ trunk/Source/WebCore/English.lproj/Localizable.strings	2013-06-17 21:50:55 UTC (rev 151656)
@@ -178,6 +178,12 @@
 /* Video Exit Fullscreen context menu item */
 "Exit Fullscreen" = "Exit Fullscreen";
 
+/* Download Video context menu item */
+"Download Video" = "Download Video";
+
+/* Download Audio context menu item */
+"Download Audio" = "Download Audio";
+
 /* Default application name for Open With context menu */
 "Finder" = "Finder";

Modified: trunk/Source/WebCore/page/ContextMenuController.cpp (151655 => 151656)


--- trunk/Source/WebCore/page/ContextMenuController.cpp	2013-06-17 21:27:00 UTC (rev 151655)
+++ trunk/Source/WebCore/page/ContextMenuController.cpp	2013-06-17 21:50:55 UTC (rev 151656)
@@ -228,7 +228,7 @@
         openNewWindow(m_hitTestResult.absoluteLinkURL(), frame);
         break;
     case ContextMenuItemTagDownloadLinkToDisk:
-        // FIXME: Some day we should be able to do this from within WebCore.
+        // FIXME: Some day we should be able to do this from within WebCore. (Bug 117709)
         m_client->downloadURL(m_hitTestResult.absoluteLinkURL());
         break;
     case ContextMenuItemTagCopyLinkToClipboard:
@@ -238,7 +238,7 @@
         openNewWindow(m_hitTestResult.absoluteImageURL(), frame);
         break;
     case ContextMenuItemTagDownloadImageToDisk:
-        // FIXME: Some day we should be able to do this from within WebCore.
+        // FIXME: Some day we should be able to do this from within WebCore. (Bug 117709)
         m_client->downloadURL(m_hitTestResult.absoluteImageURL());
         break;
     case ContextMenuItemTagCopyImageToClipboard:
@@ -254,6 +254,10 @@
     case ContextMenuItemTagOpenMediaInNewWindow:
         openNewWindow(m_hitTestResult.absoluteMediaURL(), frame);
         break;
+    case ContextMenuItemTagDownloadMediaToDisk:
+        // FIXME: Some day we should be able to do this from within WebCore. (Bug 117709)
+        m_client->downloadURL(m_hitTestResult.absoluteMediaURL());
+        break;
     case ContextMenuItemTagCopyMediaLinkToClipboard:
         frame->editor().copyURL(m_hitTestResult.absoluteMediaURL(), m_hitTestResult.textContent());
         break;
@@ -761,8 +765,8 @@
         contextMenuItemTagCopyImageUrlToClipboard());
 #endif
     ContextMenuItem OpenMediaInNewWindowItem(ActionType, ContextMenuItemTagOpenMediaInNewWindow, String());
-    ContextMenuItem CopyMediaLinkItem(ActionType, ContextMenuItemTagCopyMediaLinkToClipboard, 
-        String());
+    ContextMenuItem DownloadMediaItem(ActionType, ContextMenuItemTagDownloadMediaToDisk, String());
+    ContextMenuItem CopyMediaLinkItem(ActionType, ContextMenuItemTagCopyMediaLinkToClipboard, String());
     ContextMenuItem MediaPlayPause(ActionType, ContextMenuItemTagMediaPlayPause, 
         contextMenuItemTagMediaPlay());
     ContextMenuItem MediaMute(ActionType, ContextMenuItemTagMediaMute, 
@@ -864,6 +868,8 @@
             appendItem(*separatorItem(), m_contextMenu.get());
             appendItem(CopyMediaLinkItem, m_contextMenu.get());
             appendItem(OpenMediaInNewWindowItem, m_contextMenu.get());
+            if (loader->client()->canHandleRequest(ResourceRequest(mediaURL)))
+                appendItem(DownloadMediaItem, m_contextMenu.get());
         }
 
         if (imageURL.isEmpty() && linkURL.isEmpty() && mediaURL.isEmpty()) {
@@ -1344,6 +1350,12 @@
             else
                 item.setTitle(contextMenuItemTagOpenAudioInNewWindow());
             break;
+        case ContextMenuItemTagDownloadMediaToDisk:
+            if (m_hitTestResult.mediaIsVideo())
+                item.setTitle(contextMenuItemTagDownloadVideoToDisk());
+            else
+                item.setTitle(contextMenuItemTagDownloadAudioToDisk());
+            break;
         case ContextMenuItemTagCopyMediaLinkToClipboard:
             if (m_hitTestResult.mediaIsVideo())
                 item.setTitle(contextMenuItemTagCopyVideoLinkToClipboard());

Modified: trunk/Source/WebCore/platform/ContextMenuItem.h (151655 => 151656)


--- trunk/Source/WebCore/platform/ContextMenuItem.h	2013-06-17 21:27:00 UTC (rev 151655)
+++ trunk/Source/WebCore/platform/ContextMenuItem.h	2013-06-17 21:50:55 UTC (rev 151656)
@@ -153,6 +153,7 @@
         ContextMenuItemTagChangeBack,
 #endif
         ContextMenuItemTagOpenMediaInNewWindow,
+        ContextMenuItemTagDownloadMediaToDisk,
         ContextMenuItemTagCopyMediaLinkToClipboard,
         ContextMenuItemTagToggleMediaControls,
         ContextMenuItemTagToggleMediaLoop,

Modified: trunk/Source/WebCore/platform/LocalizedStrings.cpp (151655 => 151656)


--- trunk/Source/WebCore/platform/LocalizedStrings.cpp	2013-06-17 21:27:00 UTC (rev 151655)
+++ trunk/Source/WebCore/platform/LocalizedStrings.cpp	2013-06-17 21:50:55 UTC (rev 151656)
@@ -469,6 +469,16 @@
     return WEB_UI_STRING("Open Audio in New Window", "Open Audio in New Window context menu item");
 }
 
+String contextMenuItemTagDownloadVideoToDisk()
+{
+    return WEB_UI_STRING("Download Video", "Download Video To Disk context menu item");
+}
+
+String contextMenuItemTagDownloadAudioToDisk()
+{
+    return WEB_UI_STRING("Download Audio", "Download Audio To Disk context menu item");
+}
+
 String contextMenuItemTagCopyVideoLinkToClipboard()
 {
     return WEB_UI_STRING("Copy Video Address", "Copy Video Address Location context menu item");

Modified: trunk/Source/WebCore/platform/LocalizedStrings.h (151655 => 151656)


--- trunk/Source/WebCore/platform/LocalizedStrings.h	2013-06-17 21:27:00 UTC (rev 151655)
+++ trunk/Source/WebCore/platform/LocalizedStrings.h	2013-06-17 21:50:55 UTC (rev 151656)
@@ -132,6 +132,8 @@
 #endif
     String contextMenuItemTagOpenVideoInNewWindow();
     String contextMenuItemTagOpenAudioInNewWindow();
+    String contextMenuItemTagDownloadVideoToDisk();
+    String contextMenuItemTagDownloadAudioToDisk();
     String contextMenuItemTagCopyVideoLinkToClipboard();
     String contextMenuItemTagCopyAudioLinkToClipboard();
     String contextMenuItemTagToggleMediaControls();

Modified: trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp (151655 => 151656)


--- trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp	2013-06-17 21:27:00 UTC (rev 151655)
+++ trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp	2013-06-17 21:50:55 UTC (rev 151656)
@@ -128,6 +128,16 @@
     return String::fromUTF8("Open Audio in New Window");
 }
 
+String contextMenuItemTagDownloadVideoToDisk()
+{
+    return String::fromUTF8("Download Video");
+}
+
+String contextMenuItemTagDownloadAudioToDisk()
+{
+    return String::fromUTF8("Download Audio");
+}
+
 String contextMenuItemTagCopyVideoLinkToClipboard()
 {
     return String::fromUTF8("Copy Video Link Location");

Modified: trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp (151655 => 151656)


--- trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp	2013-06-17 21:27:00 UTC (rev 151655)
+++ trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp	2013-06-17 21:50:55 UTC (rev 151656)
@@ -141,6 +141,16 @@
     return String::fromUTF8(_("Open _Audio in New Window"));
 }
 
+String contextMenuItemTagDownloadVideoToDisk()
+{
+    return String::fromUTF8(_("Download _Video"));
+}
+
+String contextMenuItemTagDownloadAudioToDisk()
+{
+    return String::fromUTF8(_("Download _Audio"));
+}
+
 String contextMenuItemTagCopyVideoLinkToClipboard()
 {
     return String::fromUTF8(_("Cop_y Video Link Location"));

Modified: trunk/Source/WebCore/platform/qt/LocalizedStringsQt.cpp (151655 => 151656)


--- trunk/Source/WebCore/platform/qt/LocalizedStringsQt.cpp	2013-06-17 21:27:00 UTC (rev 151655)
+++ trunk/Source/WebCore/platform/qt/LocalizedStringsQt.cpp	2013-06-17 21:50:55 UTC (rev 151656)
@@ -133,6 +133,16 @@
     return QCoreApplication::translate("QWebPage", "Open Audio", "Open Audio in New Window");
 }
 
+String contextMenuItemTagDownloadVideoToDisk()
+{
+    return QCoreApplication::translate("QWebPage", "Download Video", "Download Video context menu item");
+}
+
+String contextMenuItemTagDownloadAudioToDisk()
+{
+    return QCoreApplication::translate("QWebPage", "Download Audio", "Download Audio context menu item");
+}
+
 String contextMenuItemTagCopyVideoLinkToClipboard()
 {
     return QCoreApplication::translate("QWebPage", "Copy Video", "Copy Video Link Location");

Modified: trunk/Source/WebKit/efl/ChangeLog (151655 => 151656)


--- trunk/Source/WebKit/efl/ChangeLog	2013-06-17 21:27:00 UTC (rev 151655)
+++ trunk/Source/WebKit/efl/ChangeLog	2013-06-17 21:50:55 UTC (rev 151656)
@@ -1,3 +1,17 @@
+2013-06-17  Ruth Fong  <ruth_f...@apple.com>
+
+        REGRESSION: Important controls are missing from <video> element UI, when compared to QuickTime
+        https://bugs.webkit.org/show_bug.cgi?id=20599
+
+        Add a "Download Video"/"Download Audio" context menu item to download media
+        elements.
+
+        Reviewed by Beth Dakin.
+
+        * WebCoreSupport/AssertMatchingEnums.cpp:
+        * ewk/ewk_contextmenu.h:
+        Updated to include new EWK enum type for "Download Video/Audio" context menu item.
+
 2013-06-13  Ryuan Choi  <ryuan.c...@samsung.com>
 
         [EFL] Refactor ewk_view_scroll to remove internal structure.

Modified: trunk/Source/WebKit/efl/WebCoreSupport/AssertMatchingEnums.cpp (151655 => 151656)


--- trunk/Source/WebKit/efl/WebCoreSupport/AssertMatchingEnums.cpp	2013-06-17 21:27:00 UTC (rev 151655)
+++ trunk/Source/WebKit/efl/WebCoreSupport/AssertMatchingEnums.cpp	2013-06-17 21:50:55 UTC (rev 151656)
@@ -156,6 +156,7 @@
 COMPILE_ASSERT_MATCHING_ENUM(EWK_CONTEXT_MENU_ITEM_TAG_TEXT_DIRECTION_LEFT_TO_RIGHT, ContextMenuItemTagTextDirectionLeftToRight);
 COMPILE_ASSERT_MATCHING_ENUM(EWK_CONTEXT_MENU_ITEM_TAG_TEXT_DIRECTION_RIGHT_TO_LEFT, ContextMenuItemTagTextDirectionRightToLeft);
 COMPILE_ASSERT_MATCHING_ENUM(EWK_CONTEXT_MENU_ITEM_OPEN_MEDIA_IN_NEW_WINDOW, ContextMenuItemTagOpenMediaInNewWindow);
+COMPILE_ASSERT_MATCHING_ENUM(EWK_CONTEXT_MENU_ITEM_TAG_DOWNLOAD_MEDIA_TO_DISK, ContextMenuItemTagDownloadMediaToDisk);
 COMPILE_ASSERT_MATCHING_ENUM(EWK_CONTEXT_MENU_ITEM_TAG_COPY_MEDIA_LINK_TO_CLIPBOARD, ContextMenuItemTagCopyMediaLinkToClipboard);
 COMPILE_ASSERT_MATCHING_ENUM(EWK_CONTEXT_MENU_ITEM_TAG_TOGGLE_MEDIA_CONTROLS, ContextMenuItemTagToggleMediaControls);
 COMPILE_ASSERT_MATCHING_ENUM(EWK_CONTEXT_MENU_ITEM_TAG_TOGGLE_MEDIA_LOOP, ContextMenuItemTagToggleMediaLoop);

Modified: trunk/Source/WebKit/efl/ewk/ewk_contextmenu.h (151655 => 151656)


--- trunk/Source/WebKit/efl/ewk/ewk_contextmenu.h	2013-06-17 21:27:00 UTC (rev 151655)
+++ trunk/Source/WebKit/efl/ewk/ewk_contextmenu.h	2013-06-17 21:50:55 UTC (rev 151656)
@@ -115,6 +115,7 @@
     EWK_CONTEXT_MENU_ITEM_TAG_TEXT_DIRECTION_LEFT_TO_RIGHT,
     EWK_CONTEXT_MENU_ITEM_TAG_TEXT_DIRECTION_RIGHT_TO_LEFT,
     EWK_CONTEXT_MENU_ITEM_OPEN_MEDIA_IN_NEW_WINDOW,
+    EWK_CONTEXT_MENU_ITEM_TAG_DOWNLOAD_MEDIA_TO_DISK, 
     EWK_CONTEXT_MENU_ITEM_TAG_COPY_MEDIA_LINK_TO_CLIPBOARD,
     EWK_CONTEXT_MENU_ITEM_TAG_TOGGLE_MEDIA_CONTROLS,
     EWK_CONTEXT_MENU_ITEM_TAG_TOGGLE_MEDIA_LOOP,

Modified: trunk/Source/WebKit2/ChangeLog (151655 => 151656)


--- trunk/Source/WebKit2/ChangeLog	2013-06-17 21:27:00 UTC (rev 151655)
+++ trunk/Source/WebKit2/ChangeLog	2013-06-17 21:50:55 UTC (rev 151656)
@@ -1,3 +1,29 @@
+2013-06-17  Ruth Fong  <ruth_f...@apple.com>
+
+        REGRESSION: Important controls are missing from <video> element UI, when compared to QuickTime
+        https://bugs.webkit.org/show_bug.cgi?id=20599
+
+        Add a "Download Video"/"Download Audio" context menu item to download media
+        elements.
+
+        Reviewed by Beth Dakin.
+
+        * Shared/API/c/WKContextMenuItemTypes.h: Updated to include
+        an enum type for the "Download Video/Audio" context menu item.
+
+        * Shared/API/c/WKSharedAPICast.h: Updated to associate
+        the enums in WebKit and WebCore that handle the "Download Video/Audio"
+        context menu item.
+
+        * UIProcess/API/efl/ewk_context_menu.cpp:
+        * UIProcess/API/efl/ewk_context_menu_item.cpp:
+        * UIProcess/API/efl/ewk_context_menu_item.h:
+        Updated to include new EWK enum type for "Download Video/Audio" context menu item.
+
+        * UIProcess/WebPageProxy.cpp: Updated to 
+        handle the "Download Video/Audio" context menu item mouse click
+        and download the media item in the UI process.
+
 2013-06-17  Ralph Thomas  <ral...@gmail.com>
 
         [CoordinatedGraphics][CSS Shaders] Use forwarding header for TextureMapperPlatformCompiledProgram.h

Modified: trunk/Source/WebKit2/Shared/API/c/WKContextMenuItemTypes.h (151655 => 151656)


--- trunk/Source/WebKit2/Shared/API/c/WKContextMenuItemTypes.h	2013-06-17 21:27:00 UTC (rev 151655)
+++ trunk/Source/WebKit2/Shared/API/c/WKContextMenuItemTypes.h	2013-06-17 21:50:55 UTC (rev 151656)
@@ -107,6 +107,7 @@
     kWKContextMenuItemTagCapitalize,
     kWKContextMenuItemTagChangeBack,
     kWKContextMenuItemTagOpenMediaInNewWindow,
+    kWKContextMenuItemTagDownloadMediaToDisk,
     kWKContextMenuItemTagCopyMediaLinkToClipboard,
     kWKContextMenuItemTagToggleMediaControls,
     kWKContextMenuItemTagToggleMediaLoop,

Modified: trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h (151655 => 151656)


--- trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h	2013-06-17 21:27:00 UTC (rev 151655)
+++ trunk/Source/WebKit2/Shared/API/c/WKSharedAPICast.h	2013-06-17 21:50:55 UTC (rev 151656)
@@ -462,6 +462,8 @@
         return kWKContextMenuItemTagTextDirectionRightToLeft;
     case WebCore::ContextMenuItemTagOpenMediaInNewWindow:
         return kWKContextMenuItemTagOpenMediaInNewWindow;
+    case WebCore::ContextMenuItemTagDownloadMediaToDisk:
+        return kWKContextMenuItemTagDownloadMediaToDisk;
     case WebCore::ContextMenuItemTagCopyMediaLinkToClipboard:
         return kWKContextMenuItemTagCopyMediaLinkToClipboard;
     case WebCore::ContextMenuItemTagToggleMediaControls:
@@ -654,6 +656,8 @@
         return WebCore::ContextMenuItemTagTextDirectionRightToLeft;
     case kWKContextMenuItemTagOpenMediaInNewWindow:
         return WebCore::ContextMenuItemTagOpenMediaInNewWindow;
+    case kWKContextMenuItemTagDownloadMediaToDisk:
+        return WebCore::ContextMenuItemTagDownloadMediaToDisk;
     case kWKContextMenuItemTagCopyMediaLinkToClipboard:
         return WebCore::ContextMenuItemTagCopyMediaLinkToClipboard;
     case kWKContextMenuItemTagToggleMediaControls:

Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_context_menu.cpp (151655 => 151656)


--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_context_menu.cpp	2013-06-17 21:27:00 UTC (rev 151655)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_context_menu.cpp	2013-06-17 21:50:55 UTC (rev 151656)
@@ -307,6 +307,8 @@
         return kWKContextMenuItemTagTextDirectionRightToLeft;
     case EWK_CONTEXT_MENU_ITEM_OPEN_MEDIA_IN_NEW_WINDOW:
         return kWKContextMenuItemTagOpenMediaInNewWindow;
+    case EWK_CONTEXT_MENU_ITEM_TAG_DOWNLOAD_MEDIA_TO_DISK:
+        return kWKContextMenuItemTagDownloadMediaToDisk;
     case EWK_CONTEXT_MENU_ITEM_TAG_COPY_MEDIA_LINK_TO_CLIPBOARD:
         return kWKContextMenuItemTagCopyMediaLinkToClipboard;
     case EWK_CONTEXT_MENU_ITEM_TAG_TOGGLE_MEDIA_CONTROLS:

Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_context_menu_item.cpp (151655 => 151656)


--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_context_menu_item.cpp	2013-06-17 21:27:00 UTC (rev 151655)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_context_menu_item.cpp	2013-06-17 21:50:55 UTC (rev 151656)
@@ -300,6 +300,8 @@
         return EWK_CONTEXT_MENU_ITEM_TAG_TEXT_DIRECTION_RIGHT_TO_LEFT;
     case kWKContextMenuItemTagOpenMediaInNewWindow:
         return EWK_CONTEXT_MENU_ITEM_OPEN_MEDIA_IN_NEW_WINDOW;
+    case kWKContextMenuItemTagDownloadMediaToDisk:
+        return EWK_CONTEXT_MENU_ITEM_TAG_DOWNLOAD_MEDIA_TO_DISK;
     case kWKContextMenuItemTagCopyMediaLinkToClipboard:
         return EWK_CONTEXT_MENU_ITEM_TAG_COPY_MEDIA_LINK_TO_CLIPBOARD;
     case kWKContextMenuItemTagToggleMediaControls:

Modified: trunk/Source/WebKit2/UIProcess/API/efl/ewk_context_menu_item.h (151655 => 151656)


--- trunk/Source/WebKit2/UIProcess/API/efl/ewk_context_menu_item.h	2013-06-17 21:27:00 UTC (rev 151655)
+++ trunk/Source/WebKit2/UIProcess/API/efl/ewk_context_menu_item.h	2013-06-17 21:50:55 UTC (rev 151656)
@@ -120,6 +120,7 @@
     EWK_CONTEXT_MENU_ITEM_TAG_TEXT_DIRECTION_LEFT_TO_RIGHT,
     EWK_CONTEXT_MENU_ITEM_TAG_TEXT_DIRECTION_RIGHT_TO_LEFT,
     EWK_CONTEXT_MENU_ITEM_OPEN_MEDIA_IN_NEW_WINDOW,
+    EWK_CONTEXT_MENU_ITEM_TAG_DOWNLOAD_MEDIA_TO_DISK, 
     EWK_CONTEXT_MENU_ITEM_TAG_COPY_MEDIA_LINK_TO_CLIPBOARD,
     EWK_CONTEXT_MENU_ITEM_TAG_TOGGLE_MEDIA_CONTROLS,
     EWK_CONTEXT_MENU_ITEM_TAG_TOGGLE_MEDIA_LOOP,

Modified: trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp (151655 => 151656)


--- trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2013-06-17 21:27:00 UTC (rev 151655)
+++ trunk/Source/WebKit2/UIProcess/WebPageProxy.cpp	2013-06-17 21:50:55 UTC (rev 151656)
@@ -3344,6 +3344,10 @@
         m_process->context()->download(this, KURL(KURL(), m_activeContextMenuHitTestResultData.absoluteLinkURL));
         return;
     }
+    if (item.action() == ContextMenuItemTagDownloadMediaToDisk) {
+        m_process->context()->download(this, KURL(KURL(), m_activeContextMenuHitTestResultData.absoluteMediaURL));
+        return;
+    }
     if (item.action() == ContextMenuItemTagCheckSpellingWhileTyping) {
         TextChecker::setContinuousSpellCheckingEnabled(!TextChecker::state().isContinuousSpellCheckingEnabled);
         m_process->updateTextCheckerState();

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to