Title: [152199] trunk/Source/WebInspectorUI
- Revision
- 152199
- Author
- commit-qu...@webkit.org
- Date
- 2013-06-28 18:25:43 -0700 (Fri, 28 Jun 2013)
Log Message
Web Inspector: AX: VoiceOver speaks all inspector search fields as 'required'
https://bugs.webkit.org/show_bug.cgi?id=118122
Patch by James Craig <ja...@cookiecrook.com> on 2013-06-28
Reviewed by Timothy Hatcher.
Removed bogus "required" state, and switched :valid selector to use :not(:placeholder-shown)
so that screen readers will not indicate a bogus :required/:invalid state to the user.
Minor cosmetic difference blocked by http://webkit.org/b/118162
* UserInterface/FilterBar.css:
(.filter-bar > input[type="search"]:focus):
(.filter-bar > input[type="search"]:not(:placeholder-shown)):
* UserInterface/FilterBar.js:
(WebInspector.FilterBar):
* UserInterface/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel):
* UserInterface/SearchBar.css:
(.search-bar > input[type="search"]:focus):
(.search-bar > input[type="search"]:not(:placeholder-shown)):
* UserInterface/SearchBar.js:
(WebInspector.SearchBar):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (152198 => 152199)
--- trunk/Source/WebInspectorUI/ChangeLog 2013-06-29 00:09:09 UTC (rev 152198)
+++ trunk/Source/WebInspectorUI/ChangeLog 2013-06-29 01:25:43 UTC (rev 152199)
@@ -1,3 +1,27 @@
+2013-06-28 James Craig <ja...@cookiecrook.com>
+
+ Web Inspector: AX: VoiceOver speaks all inspector search fields as 'required'
+ https://bugs.webkit.org/show_bug.cgi?id=118122
+
+ Reviewed by Timothy Hatcher.
+
+ Removed bogus "required" state, and switched :valid selector to use :not(:placeholder-shown)
+ so that screen readers will not indicate a bogus :required/:invalid state to the user.
+ Minor cosmetic difference blocked by http://webkit.org/b/118162
+
+ * UserInterface/FilterBar.css:
+ (.filter-bar > input[type="search"]:focus):
+ (.filter-bar > input[type="search"]:not(:placeholder-shown)):
+ * UserInterface/FilterBar.js:
+ (WebInspector.FilterBar):
+ * UserInterface/ResourceSidebarPanel.js:
+ (WebInspector.ResourceSidebarPanel):
+ * UserInterface/SearchBar.css:
+ (.search-bar > input[type="search"]:focus):
+ (.search-bar > input[type="search"]:not(:placeholder-shown)):
+ * UserInterface/SearchBar.js:
+ (WebInspector.SearchBar):
+
2013-06-27 James Craig <ja...@cookiecrook.com>
Web Inspector: AX: Add container ARIA roles (toolbar, main, labeled regions, etc.)
Modified: trunk/Source/WebInspectorUI/UserInterface/FilterBar.css (152198 => 152199)
--- trunk/Source/WebInspectorUI/UserInterface/FilterBar.css 2013-06-29 00:09:09 UTC (rev 152198)
+++ trunk/Source/WebInspectorUI/UserInterface/FilterBar.css 2013-06-29 01:25:43 UTC (rev 152199)
@@ -57,10 +57,8 @@
color: rgba(0, 0, 0, 0.35);
}
-.filter-bar > input[type="search"]:focus,
-.filter-bar > input[type="search"]:valid {
- background-color: white;
-}
+.filter-bar > input[type="search"]:focus { background-color: white; }
+.filter-bar > input[type="search"]:not(:placeholder-shown) { background-color: white; } /* Needs to be a separate rule. See http://webkit.org/b/118162 */
.filter-bar > input[type="search"]::-webkit-search-decoration {
width: 13px;
Modified: trunk/Source/WebInspectorUI/UserInterface/FilterBar.js (152198 => 152199)
--- trunk/Source/WebInspectorUI/UserInterface/FilterBar.js 2013-06-29 00:09:09 UTC (rev 152198)
+++ trunk/Source/WebInspectorUI/UserInterface/FilterBar.js 2013-06-29 01:25:43 UTC (rev 152199)
@@ -31,7 +31,6 @@
this._inputField = document.createElement("input");
this._inputField.type = "search";
- this._inputField.required = true;
this._inputField.spellcheck = false;
this._inputField.incremental = true;
this._inputField.addEventListener("search", this._inputFieldChanged.bind(this), false);
Modified: trunk/Source/WebInspectorUI/UserInterface/ResourceSidebarPanel.js (152198 => 152199)
--- trunk/Source/WebInspectorUI/UserInterface/ResourceSidebarPanel.js 2013-06-29 00:09:09 UTC (rev 152198)
+++ trunk/Source/WebInspectorUI/UserInterface/ResourceSidebarPanel.js 2013-06-29 01:25:43 UTC (rev 152199)
@@ -32,7 +32,6 @@
this._inputElement = document.createElement("input");
this._inputElement.type = "search";
- this._inputElement.required = true;
this._inputElement.spellcheck = false;
this._inputElement.addEventListener("search", this._searchFieldChanged.bind(this));
this._inputElement.addEventListener("input", this._searchFieldInput.bind(this));
Modified: trunk/Source/WebInspectorUI/UserInterface/SearchBar.css (152198 => 152199)
--- trunk/Source/WebInspectorUI/UserInterface/SearchBar.css 2013-06-29 00:09:09 UTC (rev 152198)
+++ trunk/Source/WebInspectorUI/UserInterface/SearchBar.css 2013-06-29 01:25:43 UTC (rev 152199)
@@ -45,7 +45,5 @@
color: rgba(0, 0, 0, 0.35);
}
-.search-bar > input[type="search"]:focus,
-.search-bar > input[type="search"]:valid {
- background-color: white;
-}
+.search-bar > input[type="search"]:focus { background-color: white; }
+.search-bar > input[type="search"]:not(:placeholder-shown) { background-color: white; } /* Needs to be a separate rule. See http://webkit.org/b/118162 */
Modified: trunk/Source/WebInspectorUI/UserInterface/SearchBar.js (152198 => 152199)
--- trunk/Source/WebInspectorUI/UserInterface/SearchBar.js 2013-06-29 00:09:09 UTC (rev 152198)
+++ trunk/Source/WebInspectorUI/UserInterface/SearchBar.js 2013-06-29 01:25:43 UTC (rev 152199)
@@ -35,7 +35,6 @@
this._searchInput = this._element.appendChild(document.createElement("input"));
this._searchInput.type = "search";
- this._searchInput.required = true;
this._searchInput.spellcheck = false;
this._searchInput.incremental = true;
this._searchInput.setAttribute("results", 5);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
