Title: [152202] trunk/Source/WebCore
Revision
152202
Author
barraclo...@apple.com
Date
2013-06-28 18:45:04 -0700 (Fri, 28 Jun 2013)

Log Message

PageThrottler::shouldThrottleTimers is wrong.
https://bugs.webkit.org/show_bug.cgi?id=118210

Reviewed by Anders Carlson.

m_throttleState == PageNotThrottledState
    -> page NOT throttled, so should NOT throttle timers
m_throttleState != PageNotThrottledState
    -> page NOT NOT throttled, so should throttle timers

This needs cleaning up, but for now, 1 character fix.

* page/PageThrottler.h:
(WebCore::PageThrottler::shouldThrottleTimers):
    == -> !=

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (152201 => 152202)


--- trunk/Source/WebCore/ChangeLog	2013-06-29 01:39:28 UTC (rev 152201)
+++ trunk/Source/WebCore/ChangeLog	2013-06-29 01:45:04 UTC (rev 152202)
@@ -1,3 +1,21 @@
+2013-06-28  Gavin Barraclough  <barraclo...@apple.com>
+
+        PageThrottler::shouldThrottleTimers is wrong.
+        https://bugs.webkit.org/show_bug.cgi?id=118210
+
+        Reviewed by Anders Carlson.
+
+        m_throttleState == PageNotThrottledState
+            -> page NOT throttled, so should NOT throttle timers
+        m_throttleState != PageNotThrottledState
+            -> page NOT NOT throttled, so should throttle timers
+
+        This needs cleaning up, but for now, 1 character fix.
+
+        * page/PageThrottler.h:
+        (WebCore::PageThrottler::shouldThrottleTimers):
+            == -> !=
+
 2013-06-28  Ryosuke Niwa  <rn...@webkit.org>
 
         An element with -webkit-user-select: all should be selected on single click

Modified: trunk/Source/WebCore/page/PageThrottler.h (152201 => 152202)


--- trunk/Source/WebCore/page/PageThrottler.h	2013-06-29 01:39:28 UTC (rev 152201)
+++ trunk/Source/WebCore/page/PageThrottler.h	2013-06-29 01:45:04 UTC (rev 152202)
@@ -44,7 +44,7 @@
     }
 
     bool shouldThrottleAnimations() const { return m_throttleState != PageNotThrottledState; }
-    bool shouldThrottleTimers() const { return m_throttleState == PageNotThrottledState; }
+    bool shouldThrottleTimers() const { return m_throttleState != PageNotThrottledState; }
 
     void setThrottled(bool);
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to