Title: [152602] trunk/Tools
- Revision
- 152602
- Author
- commit-qu...@webkit.org
- Date
- 2013-07-12 12:05:04 -0700 (Fri, 12 Jul 2013)
Log Message
Unreviewed, rolling out r152599.
http://trac.webkit.org/changeset/152599
https://bugs.webkit.org/show_bug.cgi?id=118612
This patch includes a failing unit test (Requested by
mrobinson on #webkit).
* Scripts/webkitpy/style/checkers/python.py:
(Pylinter):
* Scripts/webkitpy/style/checkers/python_unittest.py:
(PythonCheckerTest.test_check):
* Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Removed.
Modified Paths
Removed Paths
Diff
Modified: trunk/Tools/ChangeLog (152601 => 152602)
--- trunk/Tools/ChangeLog 2013-07-12 18:57:35 UTC (rev 152601)
+++ trunk/Tools/ChangeLog 2013-07-12 19:05:04 UTC (rev 152602)
@@ -1,3 +1,18 @@
+2013-07-12 Commit Queue <commit-qu...@webkit.org>
+
+ Unreviewed, rolling out r152599.
+ http://trac.webkit.org/changeset/152599
+ https://bugs.webkit.org/show_bug.cgi?id=118612
+
+ This patch includes a failing unit test (Requested by
+ mrobinson on #webkit).
+
+ * Scripts/webkitpy/style/checkers/python.py:
+ (Pylinter):
+ * Scripts/webkitpy/style/checkers/python_unittest.py:
+ (PythonCheckerTest.test_check):
+ * Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py: Removed.
+
2013-07-12 Emanuele Aina <emanuele.a...@collabora.com>
[Tools] Ignore missing GNUmakefile when detecting previous arch in build-webkit
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/python.py (152601 => 152602)
--- trunk/Tools/Scripts/webkitpy/style/checkers/python.py 2013-07-12 18:57:35 UTC (rev 152601)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/python.py 2013-07-12 19:05:04 UTC (rev 152602)
@@ -95,7 +95,6 @@
"Instance of 'Popen' has no 'stdout' member",
"Instance of 'Popen' has no 'stderr' member",
"Instance of 'Popen' has no 'wait' member",
- "Instance of 'Popen' has no 'pid' member",
]
def __init__(self):
Modified: trunk/Tools/Scripts/webkitpy/style/checkers/python_unittest.py (152601 => 152602)
--- trunk/Tools/Scripts/webkitpy/style/checkers/python_unittest.py 2013-07-12 18:57:35 UTC (rev 152601)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/python_unittest.py 2013-07-12 19:05:04 UTC (rev 152602)
@@ -61,20 +61,3 @@
(4, "pep8/W291", 5, "trailing whitespace"),
(4, "pylint/E0602", 5, "Undefined variable 'error'"),
])
-
- def test_pylint_false_positives(self):
- """Test that pylint false positives are suppressed."""
- errors = []
-
- def _mock_handle_pylint_false_positives(line_number, category, confidence,
- message):
- error = (line_number, category, confidence, message)
- errors.append(error)
-
- current_dir = os.path.dirname(__file__)
- file_path = os.path.join(current_dir, "python_unittest_false_positives.py")
-
- checker = PythonChecker(file_path, _mock_handle_style_error)
- checker.check(lines=[])
-
- self.assertEqual(errors, [])
Deleted: trunk/Tools/Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py (152601 => 152602)
--- trunk/Tools/Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py 2013-07-12 18:57:35 UTC (rev 152601)
+++ trunk/Tools/Scripts/webkitpy/style/checkers/python_unittest_falsepositives.py 2013-07-12 19:05:04 UTC (rev 152602)
@@ -1,16 +0,0 @@
-# This test verifies that the false positives generated by pylint are
-# correctly suppressed.
-
-import subprocess
-
-
-def test_popen(proc):
- p = subprocess.Popen(proc, stdout=subprocess.PIPE,
- stderr=subprocess.STDOUT)
- tmp1 = p.poll
- tmp2 = p.returncode
- tmp3 = p.stdin
- tmp4 = p.stdout
- tmp5 = p.stderr
- tmp6 = p.wait
- tmp7 = p.pid
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
