Title: [152817] trunk/Source/_javascript_Core
- Revision
- 152817
- Author
- gga...@apple.com
- Date
- 2013-07-17 16:41:01 -0700 (Wed, 17 Jul 2013)
Log Message
API tests should test for JSStringCreateWithCFString with empty string
https://bugs.webkit.org/show_bug.cgi?id=118819
Reviewed by Mark Hahnenberg.
* API/tests/testapi.c:
(main): Test!
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/API/tests/testapi.c (152816 => 152817)
--- trunk/Source/_javascript_Core/API/tests/testapi.c 2013-07-17 23:37:54 UTC (rev 152816)
+++ trunk/Source/_javascript_Core/API/tests/testapi.c 2013-07-17 23:41:01 UTC (rev 152817)
@@ -1245,6 +1245,14 @@
} else
printf("PASS: returned null when accessing character pointer of a null String.\n");
+ JSStringRef emptyString = JSStringCreateWithCFString(CFSTR(""));
+ characters = JSStringGetCharactersPtr(emptyString);
+ if (!characters) {
+ printf("FAIL: Returned null when accessing character pointer of an empty String.\n");
+ failed = 1;
+ } else
+ printf("PASS: returned empty when accessing character pointer of an empty String.\n");
+
size_t length = JSStringGetLength(nullString);
if (length) {
printf("FAIL: Didn't return 0 length for null String.\n");
@@ -1253,6 +1261,14 @@
printf("PASS: returned 0 length for null String.\n");
JSStringRelease(nullString);
+ length = JSStringGetLength(emptyString);
+ if (length) {
+ printf("FAIL: Didn't return 0 length for empty String.\n");
+ failed = 1;
+ } else
+ printf("PASS: returned 0 length for empty String.\n");
+ JSStringRelease(emptyString);
+
JSObjectRef propertyCatchalls = JSObjectMake(context, PropertyCatchalls_class(context), NULL);
JSStringRef propertyCatchallsString = JSStringCreateWithUTF8CString("PropertyCatchalls");
JSObjectSetProperty(context, globalObject, propertyCatchallsString, propertyCatchalls, kJSPropertyAttributeNone, NULL);
Modified: trunk/Source/_javascript_Core/ChangeLog (152816 => 152817)
--- trunk/Source/_javascript_Core/ChangeLog 2013-07-17 23:37:54 UTC (rev 152816)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-07-17 23:41:01 UTC (rev 152817)
@@ -1,3 +1,13 @@
+2013-07-17 Geoffrey Garen <gga...@apple.com>
+
+ API tests should test for JSStringCreateWithCFString with empty string
+ https://bugs.webkit.org/show_bug.cgi?id=118819
+
+ Reviewed by Mark Hahnenberg.
+
+ * API/tests/testapi.c:
+ (main): Test!
+
2013-07-17 Filip Pizlo <fpi...@apple.com>
DFG assumes that NewFunction will never pass its input through
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
