Log Message
[Windows] Improper Caption Button Displayed to Users https://bugs.webkit.org/show_bug.cgi?id=119593
Reviewed by Eric Carlson. Remove the custom drawing code for the Windows port, and have it render using the CSS/SVG markup like we do on OS X. * rendering/RenderThemeWin.cpp: Remove drawing code. * rendering/RenderThemeWin.h: Remove declaration.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (153844 => 153845)
--- trunk/Source/WebCore/ChangeLog 2013-08-08 21:05:41 UTC (rev 153844)
+++ trunk/Source/WebCore/ChangeLog 2013-08-08 21:12:24 UTC (rev 153845)
@@ -1,3 +1,16 @@
+2013-08-08 Brent Fulgham <bfulg...@apple.com>
+
+ [Windows] Improper Caption Button Displayed to Users
+ https://bugs.webkit.org/show_bug.cgi?id=119593
+
+ Reviewed by Eric Carlson.
+
+ Remove the custom drawing code for the Windows port, and
+ have it render using the CSS/SVG markup like we do on OS X.
+
+ * rendering/RenderThemeWin.cpp: Remove drawing code.
+ * rendering/RenderThemeWin.h: Remove declaration.
+
2013-08-08 Alex Christensen <achristen...@apple.com>
Work towards WebGL on AppleWin port.
Modified: trunk/Source/WebCore/rendering/RenderThemeWin.cpp (153844 => 153845)
--- trunk/Source/WebCore/rendering/RenderThemeWin.cpp 2013-08-08 21:05:41 UTC (rev 153844)
+++ trunk/Source/WebCore/rendering/RenderThemeWin.cpp 2013-08-08 21:12:24 UTC (rev 153845)
@@ -1138,11 +1138,6 @@
return RenderMediaControls::paintMediaControlsPart(MediaSliderThumb, o, paintInfo, r);
}
-bool RenderThemeWin::paintMediaToggleClosedCaptionsButton(RenderObject* o, const PaintInfo& paintInfo, const IntRect& r)
-{
- return RenderMediaControls::paintMediaControlsPart(MediaShowClosedCaptionsButton, o, paintInfo, r);
-}
-
bool RenderThemeWin::paintMediaControlsBackground(RenderObject* o, const PaintInfo& paintInfo, const IntRect& r)
{
return RenderMediaControls::paintMediaControlsPart(MediaTimelineContainer, o, paintInfo, r);
Modified: trunk/Source/WebCore/rendering/RenderThemeWin.h (153844 => 153845)
--- trunk/Source/WebCore/rendering/RenderThemeWin.h 2013-08-08 21:05:41 UTC (rev 153844)
+++ trunk/Source/WebCore/rendering/RenderThemeWin.h 2013-08-08 21:12:24 UTC (rev 153845)
@@ -137,7 +137,6 @@
virtual bool paintMediaSeekForwardButton(RenderObject*, const PaintInfo&, const IntRect&);
virtual bool paintMediaSliderTrack(RenderObject*, const PaintInfo&, const IntRect&);
virtual bool paintMediaSliderThumb(RenderObject*, const PaintInfo&, const IntRect&);
- virtual bool paintMediaToggleClosedCaptionsButton(RenderObject*, const PaintInfo&, const IntRect&);
virtual bool paintMediaVolumeSliderContainer(RenderObject*, const PaintInfo&, const IntRect&);
virtual bool paintMediaVolumeSliderTrack(RenderObject*, const PaintInfo&, const IntRect&);
virtual bool paintMediaVolumeSliderThumb(RenderObject*, const PaintInfo&, const IntRect&);
_______________________________________________ webkit-changes mailing list webkit-changes@lists.webkit.org https://lists.webkit.org/mailman/listinfo/webkit-changes
