Title: [154989] trunk/Source/WebKit2
- Revision
- 154989
- Author
- commit-qu...@webkit.org
- Date
- 2013-09-03 10:08:13 -0700 (Tue, 03 Sep 2013)
Log Message
[GTK] gdk threads deprecated functions calls should be refactored
https://bugs.webkit.org/show_bug.cgi?id=120070
Patch by Anton Obzhirov <a.obzhi...@samsung.com> on 2013-09-03
Reviewed by Mario Sanchez Prada.
Removed deprecated functions gdk_threads_leave()/gdk_threads_enter() functions since
there is no more checks for threads lock in GTK 3.6.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewRunAsModal):
* UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
(WebKit::WebPopupMenuProxyGtk::showPopupMenu):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (154988 => 154989)
--- trunk/Source/WebKit2/ChangeLog 2013-09-03 16:51:19 UTC (rev 154988)
+++ trunk/Source/WebKit2/ChangeLog 2013-09-03 17:08:13 UTC (rev 154989)
@@ -1,3 +1,18 @@
+2013-09-03 Anton Obzhirov <a.obzhi...@samsung.com>
+
+ [GTK] gdk threads deprecated functions calls should be refactored
+ https://bugs.webkit.org/show_bug.cgi?id=120070
+
+ Reviewed by Mario Sanchez Prada.
+
+ Removed deprecated functions gdk_threads_leave()/gdk_threads_enter() functions since
+ there is no more checks for threads lock in GTK 3.6.
+
+ * UIProcess/API/gtk/WebKitWebView.cpp:
+ (webkitWebViewRunAsModal):
+ * UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
+ (WebKit::WebPopupMenuProxyGtk::showPopupMenu):
+
2013-09-03 Brian Holt <brian.h...@samsung.com>
[GTK] [WK2] TestContextMenu default-menu fails
Modified: trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp (154988 => 154989)
--- trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2013-09-03 16:51:19 UTC (rev 154988)
+++ trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp 2013-09-03 17:08:13 UTC (rev 154989)
@@ -1560,9 +1560,7 @@
g_signal_emit(webView, signals[RUN_AS_MODAL], 0, NULL);
webView->priv->modalLoop = adoptGRef(g_main_loop_new(0, FALSE));
- gdk_threads_leave();
g_main_loop_run(webView->priv->modalLoop.get());
- gdk_threads_enter();
}
void webkitWebViewClosePage(WebKitWebView* webView)
Modified: trunk/Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp (154988 => 154989)
--- trunk/Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp 2013-09-03 16:51:19 UTC (rev 154988)
+++ trunk/Source/WebKit2/UIProcess/gtk/WebPopupMenuProxyGtk.cpp 2013-09-03 17:08:13 UTC (rev 154989)
@@ -97,9 +97,7 @@
// menu right after calling WebPopupMenuProxy::showPopupMenu().
m_runLoop = adoptGRef(g_main_loop_new(0, FALSE));
- gdk_threads_leave();
g_main_loop_run(m_runLoop.get());
- gdk_threads_enter();
m_runLoop.clear();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
