Title: [156027] trunk/Source/WebInspectorUI
- Revision
- 156027
- Author
- commit-qu...@webkit.org
- Date
- 2013-09-17 23:51:58 -0700 (Tue, 17 Sep 2013)
Log Message
[GTK] Cannot find WebInspectorUI/UserInterface/Main.html referenced in GResourceBundle.xml
https://bugs.webkit.org/show_bug.cgi?id=121405
Patch by Gustavo Noronha Silva <g...@gnome.org> on 2013-09-17
Reviewed by Carlos Garcia Campos.
* GNUmakefile.am: if srcdir == builddir the WebInspectorUI variable that is used both to list
the dependencies of the GResourceBundle and to normalize the paths added to the XML through sed
replacement will end up starting with ./, which would be fine if automake did not remove that
from the paths in the target's dependency. We deal with that by normalizing the path we use to
take that quirk into account.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (156026 => 156027)
--- trunk/Source/WebInspectorUI/ChangeLog 2013-09-18 06:39:54 UTC (rev 156026)
+++ trunk/Source/WebInspectorUI/ChangeLog 2013-09-18 06:51:58 UTC (rev 156027)
@@ -1,3 +1,16 @@
+2013-09-17 Gustavo Noronha Silva <g...@gnome.org>
+
+ [GTK] Cannot find WebInspectorUI/UserInterface/Main.html referenced in GResourceBundle.xml
+ https://bugs.webkit.org/show_bug.cgi?id=121405
+
+ Reviewed by Carlos Garcia Campos.
+
+ * GNUmakefile.am: if srcdir == builddir the WebInspectorUI variable that is used both to list
+ the dependencies of the GResourceBundle and to normalize the paths added to the XML through sed
+ replacement will end up starting with ./, which would be fine if automake did not remove that
+ from the paths in the target's dependency. We deal with that by normalizing the path we use to
+ take that quirk into account.
+
2013-09-17 Timothy Hatcher <timo...@apple.com>
Clean up the Inspector's WebSocket code and prevent it from dropping messages.
Modified: trunk/Source/WebInspectorUI/GNUmakefile.am (156026 => 156027)
--- trunk/Source/WebInspectorUI/GNUmakefile.am 2013-09-18 06:39:54 UTC (rev 156026)
+++ trunk/Source/WebInspectorUI/GNUmakefile.am 2013-09-18 06:51:58 UTC (rev 156027)
@@ -12,9 +12,10 @@
$(AM_V_at)echo '<gresources>' >> ${GENSOURCES_WEBINSPECTOR_UI}/GResourceBundle.xml
$(AM_V_at)echo ' <gresource prefix="/org/webkitgtk/inspector">' >> ${GENSOURCES_WEBINSPECTOR_UI}/GResourceBundle.xml
$(AM_V_at)\
+ basepath=`echo $(WebInspectorUI)/ | sed 's,^./,,g'`; \
for file in $^; do \
if [ "$$file" = "GNUmakefile" ]; then continue; fi; \
- file=`echo $$file | sed s,$(WebInspectorUI)/,,g`; \
+ file=`echo $$file | sed "s,$$basepath,,g"`; \
echo " <file>$$file</file>" >> ${GENSOURCES_WEBINSPECTOR_UI}/GResourceBundle.xml; \
done
$(AM_V_at)echo ' </gresource>' >> ${GENSOURCES_WEBINSPECTOR_UI}/GResourceBundle.xml
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
