Title: [156873] trunk/Source/_javascript_Core
- Revision
- 156873
- Author
- mr...@apple.com
- Date
- 2013-10-03 20:19:44 -0700 (Thu, 03 Oct 2013)
Log Message
REGRESSION (r156811): WebCore rebuilds from scratch when doing an incremental build
The change in r156811 resulted in several public headers in the _javascript_Core framework having their modification
date touched on every build, even if their contents had not changed. This resulted in a large portion of WebCore
needing to rebuilt after an incremental build of _javascript_Core.
Reviewed by Dan Bernstein.
* _javascript_Core.xcodeproj/project.pbxproj: Have unifdef generate its output to a temporary file. If its exit status
indicates that the content did not change, remove the temporary file. If the content changed, moved the temporary file
over the destination.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (156872 => 156873)
--- trunk/Source/_javascript_Core/ChangeLog 2013-10-04 03:19:29 UTC (rev 156872)
+++ trunk/Source/_javascript_Core/ChangeLog 2013-10-04 03:19:44 UTC (rev 156873)
@@ -1,3 +1,17 @@
+2013-10-03 Mark Rowe <mr...@apple.com>
+
+ REGRESSION (r156811): WebCore rebuilds from scratch when doing an incremental build
+
+ The change in r156811 resulted in several public headers in the _javascript_Core framework having their modification
+ date touched on every build, even if their contents had not changed. This resulted in a large portion of WebCore
+ needing to rebuilt after an incremental build of _javascript_Core.
+
+ Reviewed by Dan Bernstein.
+
+ * _javascript_Core.xcodeproj/project.pbxproj: Have unifdef generate its output to a temporary file. If its exit status
+ indicates that the content did not change, remove the temporary file. If the content changed, moved the temporary file
+ over the destination.
+
2013-10-03 Brent Fulgham <bfulg...@apple.com>
[Win] Unreviewed gardening.
Modified: trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj (156872 => 156873)
--- trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2013-10-04 03:19:29 UTC (rev 156872)
+++ trunk/Source/_javascript_Core/_javascript_Core.xcodeproj/project.pbxproj 2013-10-04 03:19:44 UTC (rev 156873)
@@ -4749,7 +4749,7 @@
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
- shellScript = "cd \"${TARGET_BUILD_DIR}/${PUBLIC_HEADERS_FOLDER_PATH}\"\n\nif [[ ${TARGET_MAC_OS_X_VERSION_MAJOR} == \"1080\" ]]; then\n UNIFDEF_OPTION=\"-DJSC_OBJC_API_AVAILABLE_MAC_OS_X_1080\";\nelse\n UNIFDEF_OPTION=\"-UJSC_OBJC_API_AVAILABLE_MAC_OS_X_1080\";\nfi\n\nfor HEADER in JSBase.h JSContext.h JSManagedValue.h JSValue.h JSVirtualMachine.h; do\n unifdef -B ${UNIFDEF_OPTION} -o ${HEADER} ${HEADER}\n if [[ $? > 1 ]]; then\n exit 1;\n fi\ndone";
+ shellScript = "cd \"${TARGET_BUILD_DIR}/${PUBLIC_HEADERS_FOLDER_PATH}\"\n\nif [[ ${TARGET_MAC_OS_X_VERSION_MAJOR} == \"1080\" ]]; then\n UNIFDEF_OPTION=\"-DJSC_OBJC_API_AVAILABLE_MAC_OS_X_1080\";\nelse\n UNIFDEF_OPTION=\"-UJSC_OBJC_API_AVAILABLE_MAC_OS_X_1080\";\nfi\n\nfor HEADER in JSBase.h JSContext.h JSManagedValue.h JSValue.h JSVirtualMachine.h; do\n unifdef -B ${UNIFDEF_OPTION} -o ${HEADER}.unifdef ${HEADER}\n case $? in\n 0)\n rm ${HEADER}.unifdef\n ;;\n 1)\n mv ${HEADER}{.unifdef,}\n ;;\n *)\n exit 1\n esac\ndone\n";
};
5D29D8BE0E9860B400C3D2D0 /* Check For Weak VTables and Externals */ = {
isa = PBXShellScriptBuildPhase;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
