Title: [157564] trunk
Revision
157564
Author
commit-qu...@webkit.org
Date
2013-10-17 01:06:33 -0700 (Thu, 17 Oct 2013)

Log Message

[EFL] Properly expose tables in accessibility
https://bugs.webkit.org/show_bug.cgi?id=122894

Patch by Krzysztof Czech <k.cz...@samsung.com> on 2013-10-17
Reviewed by Chris Fleizach.

Source/WebCore:

All tables should exposed as tables.

* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
(WebCore::AccessibilityTable::addChildren):
* accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::computeAccessibilityIsIgnored):
* accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore::AccessibilityTableHeaderContainer::computeAccessibilityIsIgnored):

LayoutTests:

Added new accessibility expectations after r153432.

* platform/efl-wk2/TestExpectations:
* platform/efl-wk2/accessibility/table-detection-expected.txt: Added.
* platform/efl-wk2/accessibility/table-one-cell-expected.txt: Added.
* platform/efl-wk2/accessibility/table-with-rules-expected.txt: Added.
* platform/efl/accessibility/table-detection-expected.txt: Added.
* platform/efl/accessibility/table-one-cell-expected.txt: Added.
* platform/efl/accessibility/table-with-rules-expected.txt: Added.

Modified Paths

Added Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (157563 => 157564)


--- trunk/LayoutTests/ChangeLog	2013-10-17 07:55:09 UTC (rev 157563)
+++ trunk/LayoutTests/ChangeLog	2013-10-17 08:06:33 UTC (rev 157564)
@@ -1,3 +1,20 @@
+2013-10-17  Krzysztof Czech  <k.cz...@samsung.com>
+
+        [EFL] Properly expose tables in accessibility
+        https://bugs.webkit.org/show_bug.cgi?id=122894
+
+        Reviewed by Chris Fleizach.
+
+        Added new accessibility expectations after r153432.
+
+        * platform/efl-wk2/TestExpectations:
+        * platform/efl-wk2/accessibility/table-detection-expected.txt: Added.
+        * platform/efl-wk2/accessibility/table-one-cell-expected.txt: Added.
+        * platform/efl-wk2/accessibility/table-with-rules-expected.txt: Added.
+        * platform/efl/accessibility/table-detection-expected.txt: Added.
+        * platform/efl/accessibility/table-one-cell-expected.txt: Added.
+        * platform/efl/accessibility/table-with-rules-expected.txt: Added.
+
 2013-10-16  Jinwoo Song  <jinwoo7.s...@samsung.com>
 
         Unreviewed EFL gardening. Rebaselining after r155607.

Added: trunk/LayoutTests/platform/efl/accessibility/table-detection-expected.txt (0 => 157564)


--- trunk/LayoutTests/platform/efl/accessibility/table-detection-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/efl/accessibility/table-detection-expected.txt	2013-10-17 08:06:33 UTC (rev 157564)
@@ -0,0 +1,457 @@
+
+This should be a table because it has a thead.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 4
+AXPosition: { 8.000000, 56.000000 }
+AXSize: { 62.000000, 49.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+asdf	asdf
+
+This should be a table because cells have borders.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 8.000000, 493.000000 }
+AXSize: { 68.000000, 29.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+
+This should not be a table because its cells do not have borders.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 8.000000, 318.000000 }
+AXSize: { 64.000000, 27.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: layout-guess:true, toolkit:WebKitEfl
+
+asdf	asdf
+
+This should be a table because a cell has a special attribute
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 8.000000, 319.000000 }
+AXSize: { 58.000000, 23.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+
+This should be a table because a cell has a special attribute.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 8.000000, 319.000000 }
+AXSize: { 58.000000, 23.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+
+This should be a table because a cell has a special attribute.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 4
+AXPosition: { 8.000000, 319.000000 }
+AXSize: { 58.000000, 43.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+asdf	asdf
+
+This should be a table because cells have different colors.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 8.000000, 319.000000 }
+AXSize: { 58.000000, 23.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+
+This should not be a table because cells have different but no spacing.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 8.000000, 319.000000 }
+AXSize: { 52.000000, 19.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: layout-guess:true, toolkit:WebKitEfl
+
+asdf	asdf
+
+This should not be a table because cells have the same colors even though there is spacing.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 8.000000, 333.000000 }
+AXSize: { 61.000000, 25.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: layout-guess:true, toolkit:WebKitEfl
+
+asdf	asdf
+
+This should be a table because it has the "rules" attr.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 8.000000, 319.000000 }
+AXSize: { 53.000000, 19.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+
+This should not be a table because it only has one valid cell (need more than one).
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 8.000000, 333.000000 }
+AXSize: { 765.000000, 26.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: layout-guess:true, toolkit:WebKitEfl
+
+Contributions
+
+This should not be a table because it does not have enough cell borders or background colors
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 7
+AXPosition: { 8.000000, 333.000000 }
+AXSize: { 130.000000, 93.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: layout-guess:true, toolkit:WebKitEfl
+
+Politics
+Decision '08
+The debates
+The White House
+Capitol Hill
+National Journal
+New York Times
+
+This should be a table because it's editable.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 8.000000, 319.000000 }
+AXSize: { 64.000000, 27.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 1
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+
+This should be a table because most cells have a top border.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 4
+AXPosition: { 8.000000, 319.000000 }
+AXSize: { 62.000000, 49.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+asdf	asdf
+
+This should not be a table because cells have different borders.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 4
+AXPosition: { 8.000000, 319.000000 }
+AXSize: { 62.000000, 47.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: layout-guess:true, toolkit:WebKitEfl
+
+asdf	asdf
+asdf	asdf
+
+This should be a table because it sets empty-cells: hide on the table.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 6
+AXPosition: { 8.000000, 319.000000 }
+AXSize: { 64.000000, 70.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+asdf
+asdf	asdf
+
+This should be a table because it sets empty-cells: hide on a cell.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 6
+AXPosition: { 8.000000, 319.000000 }
+AXSize: { 64.000000, 71.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+asdf
+asdf	asdf
+
+This should be a table because it has a col.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 4
+AXPosition: { 8.000000, 319.000000 }
+AXSize: { 62.000000, 47.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+asdf	asdf
+
+This should be a table because it has at least 20 rows
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 24
+AXPosition: { 8.000000, 318.000000 }
+AXSize: { 32.000000, 531.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+

Added: trunk/LayoutTests/platform/efl/accessibility/table-one-cell-expected.txt (0 => 157564)


--- trunk/LayoutTests/platform/efl/accessibility/table-one-cell-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/efl/accessibility/table-one-cell-expected.txt	2013-10-17 08:06:33 UTC (rev 157564)
@@ -0,0 +1,20 @@
+Pick Your Location!
+Get specific content for your area. 
+http://web.apple.com
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 1
+AXPosition: { 8.000000, 8.000000 }
+AXSize: { 138.000000, 96.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: layout-guess:true, toolkit:WebKitEfl

Added: trunk/LayoutTests/platform/efl/accessibility/table-with-rules-expected.txt (0 => 157564)


--- trunk/LayoutTests/platform/efl/accessibility/table-with-rules-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/efl/accessibility/table-with-rules-expected.txt	2013-10-17 08:06:33 UTC (rev 157564)
@@ -0,0 +1,99 @@
+asdf	asdf
+asdf	asdf
+asdf	asdf
+asdf	asdf
+asdf	asdf
+
+------------------------------------
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 8.000000, 28.000000 }
+AXSize: { 57.000000, 20.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: html-id:testTable2, toolkit:WebKitEfl
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 8.000000, 48.000000 }
+AXSize: { 62.000000, 24.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: html-id:testTable3, toolkit:WebKitEfl
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 8.000000, 72.000000 }
+AXSize: { 56.000000, 20.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: html-id:testTable4, toolkit:WebKitEfl
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 8.000000, 92.000000 }
+AXSize: { 62.000000, 24.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: layout-guess:true, html-id:testTable5, toolkit:WebKitEfl
+
+AXRole: AXGroup
+AXParent: AXWebArea
+AXChildren: 0
+AXPosition: { 8.000000, 116.000000 }
+AXSize: { 765.000000, 36.000000 }
+AXTitle: 
+AXDescription: 
+AXValue: ------------------------------------
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+

Modified: trunk/LayoutTests/platform/efl-wk2/TestExpectations (157563 => 157564)


--- trunk/LayoutTests/platform/efl-wk2/TestExpectations	2013-10-17 07:55:09 UTC (rev 157563)
+++ trunk/LayoutTests/platform/efl-wk2/TestExpectations	2013-10-17 08:06:33 UTC (rev 157564)
@@ -188,9 +188,6 @@
 
 accessibility/media-element.html [ Missing ]
 accessibility/negative-tabindex-does-not-expose-label.html [ Missing ]
-accessibility/table-detection.html [ Missing ]
-accessibility/table-one-cell.html [ Missing ]
-accessibility/table-with-rules.html [ Missing ]
 
 # EFL port doesn't support webarchives.
 webarchive [ Skip ]

Added: trunk/LayoutTests/platform/efl-wk2/accessibility/table-detection-expected.txt (0 => 157564)


--- trunk/LayoutTests/platform/efl-wk2/accessibility/table-detection-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/efl-wk2/accessibility/table-detection-expected.txt	2013-10-17 08:06:33 UTC (rev 157564)
@@ -0,0 +1,457 @@
+
+This should be a table because it has a thead.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 4
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 62.000000, 49.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+asdf	asdf
+
+This should be a table because cells have borders.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 68.000000, 29.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+
+This should not be a table because its cells do not have borders.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 64.000000, 27.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: layout-guess:true, toolkit:WebKitEfl
+
+asdf	asdf
+
+This should be a table because a cell has a special attribute
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 58.000000, 23.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+
+This should be a table because a cell has a special attribute.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 58.000000, 23.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+
+This should be a table because a cell has a special attribute.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 4
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 58.000000, 43.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+asdf	asdf
+
+This should be a table because cells have different colors.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 58.000000, 23.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+
+This should not be a table because cells have different but no spacing.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 52.000000, 19.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: layout-guess:true, toolkit:WebKitEfl
+
+asdf	asdf
+
+This should not be a table because cells have the same colors even though there is spacing.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 61.000000, 25.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: layout-guess:true, toolkit:WebKitEfl
+
+asdf	asdf
+
+This should be a table because it has the "rules" attr.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 53.000000, 19.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+
+This should not be a table because it only has one valid cell (need more than one).
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 769.000000, 26.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: layout-guess:true, toolkit:WebKitEfl
+
+Contributions
+
+This should not be a table because it does not have enough cell borders or background colors
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 7
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 130.000000, 93.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: layout-guess:true, toolkit:WebKitEfl
+
+Politics
+Decision '08
+The debates
+The White House
+Capitol Hill
+National Journal
+New York Times
+
+This should be a table because it's editable.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 64.000000, 27.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 1
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+
+This should be a table because most cells have a top border.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 4
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 62.000000, 49.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+asdf	asdf
+
+This should not be a table because cells have different borders.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 4
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 62.000000, 47.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: layout-guess:true, toolkit:WebKitEfl
+
+asdf	asdf
+asdf	asdf
+
+This should be a table because it sets empty-cells: hide on the table.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 6
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 64.000000, 70.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+asdf
+asdf	asdf
+
+This should be a table because it sets empty-cells: hide on a cell.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 6
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 64.000000, 71.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+asdf
+asdf	asdf
+
+This should be a table because it has a col.
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 4
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 62.000000, 47.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf	asdf
+asdf	asdf
+
+This should be a table because it has at least 20 rows
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 24
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 32.000000, 531.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+asdf
+

Added: trunk/LayoutTests/platform/efl-wk2/accessibility/table-one-cell-expected.txt (0 => 157564)


--- trunk/LayoutTests/platform/efl-wk2/accessibility/table-one-cell-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/efl-wk2/accessibility/table-one-cell-expected.txt	2013-10-17 08:06:33 UTC (rev 157564)
@@ -0,0 +1,20 @@
+Pick Your Location!
+Get specific content for your area. 
+http://web.apple.com
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 1
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 138.000000, 96.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: layout-guess:true, toolkit:WebKitEfl

Added: trunk/LayoutTests/platform/efl-wk2/accessibility/table-with-rules-expected.txt (0 => 157564)


--- trunk/LayoutTests/platform/efl-wk2/accessibility/table-with-rules-expected.txt	                        (rev 0)
+++ trunk/LayoutTests/platform/efl-wk2/accessibility/table-with-rules-expected.txt	2013-10-17 08:06:33 UTC (rev 157564)
@@ -0,0 +1,99 @@
+asdf	asdf
+asdf	asdf
+asdf	asdf
+asdf	asdf
+asdf	asdf
+
+------------------------------------
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 57.000000, 20.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: html-id:testTable2, toolkit:WebKitEfl
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 62.000000, 24.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: html-id:testTable3, toolkit:WebKitEfl
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 56.000000, 20.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: html-id:testTable4, toolkit:WebKitEfl
+
+AXRole: AXTable
+AXParent: AXWebArea
+AXChildren: 2
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 62.000000, 24.000000 }
+AXTitle: 
+AXDescription: 
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: layout-guess:true, html-id:testTable5, toolkit:WebKitEfl
+
+AXRole: AXGroup
+AXParent: AXWebArea
+AXChildren: 0
+AXPosition: { 0.000000, 0.000000 }
+AXSize: { 769.000000, 36.000000 }
+AXTitle: 
+AXDescription: 
+AXValue: ------------------------------------
+AXFocusable: 0
+AXFocused: 0
+AXSelectable: 0
+AXSelected: 0
+AXMultiSelectable: 0
+AXEnabled: 1
+AXExpanded: 0
+AXRequired: 0
+AXChecked: 0
+AXPlatformAttributes: toolkit:WebKitEfl
+
+

Modified: trunk/Source/WebCore/ChangeLog (157563 => 157564)


--- trunk/Source/WebCore/ChangeLog	2013-10-17 07:55:09 UTC (rev 157563)
+++ trunk/Source/WebCore/ChangeLog	2013-10-17 08:06:33 UTC (rev 157564)
@@ -1,3 +1,20 @@
+2013-10-17  Krzysztof Czech  <k.cz...@samsung.com>
+
+        [EFL] Properly expose tables in accessibility
+        https://bugs.webkit.org/show_bug.cgi?id=122894
+
+        Reviewed by Chris Fleizach.
+
+        All tables should exposed as tables.
+
+        * accessibility/AccessibilityTable.cpp:
+        (WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
+        (WebCore::AccessibilityTable::addChildren):
+        * accessibility/AccessibilityTableColumn.cpp:
+        (WebCore::AccessibilityTableColumn::computeAccessibilityIsIgnored):
+        * accessibility/AccessibilityTableHeaderContainer.cpp:
+        (WebCore::AccessibilityTableHeaderContainer::computeAccessibilityIsIgnored):
+
 2013-10-17  Brendan Long  <b.l...@cablelabs.com>
 
         [GStreamer] Too many arguments for format in WebKitWebAudioSourceGStreamer.cpp

Modified: trunk/Source/WebCore/accessibility/AccessibilityTable.cpp (157563 => 157564)


--- trunk/Source/WebCore/accessibility/AccessibilityTable.cpp	2013-10-17 07:55:09 UTC (rev 157563)
+++ trunk/Source/WebCore/accessibility/AccessibilityTable.cpp	2013-10-17 08:06:33 UTC (rev 157564)
@@ -307,7 +307,7 @@
         return false;
 
     // Gtk+ ATs expect all tables to be exposed as tables.
-#if PLATFORM(GTK)
+#if PLATFORM(GTK) || PLATFORM(EFL)
     Element* tableNode = toRenderTable(m_renderer)->element();
     return tableNode && isHTMLTableElement(tableNode);
 #endif
@@ -374,7 +374,7 @@
             m_rows.append(row);
             if (!row->accessibilityIsIgnored())
                 m_children.append(row);
-#if PLATFORM(GTK)
+#if PLATFORM(GTK) || PLATFORM(EFL)
             else
                 m_children.appendVector(row->children());
 #endif

Modified: trunk/Source/WebCore/accessibility/AccessibilityTableColumn.cpp (157563 => 157564)


--- trunk/Source/WebCore/accessibility/AccessibilityTableColumn.cpp	2013-10-17 07:55:09 UTC (rev 157563)
+++ trunk/Source/WebCore/accessibility/AccessibilityTableColumn.cpp	2013-10-17 08:06:33 UTC (rev 157564)
@@ -156,7 +156,7 @@
     if (!m_parent)
         return true;
     
-#if PLATFORM(IOS) || PLATFORM(GTK)
+#if PLATFORM(IOS) || PLATFORM(GTK) || PLATFORM(EFL)
     return true;
 #endif
     

Modified: trunk/Source/WebCore/accessibility/AccessibilityTableHeaderContainer.cpp (157563 => 157564)


--- trunk/Source/WebCore/accessibility/AccessibilityTableHeaderContainer.cpp	2013-10-17 07:55:09 UTC (rev 157563)
+++ trunk/Source/WebCore/accessibility/AccessibilityTableHeaderContainer.cpp	2013-10-17 08:06:33 UTC (rev 157564)
@@ -60,7 +60,7 @@
     if (!m_parent)
         return true;
     
-#if PLATFORM(IOS) || PLATFORM(GTK)
+#if PLATFORM(IOS) || PLATFORM(GTK) || PLATFORM(EFL)
     return true;
 #endif
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to