Title: [157594] trunk/Source/WebCore
- Revision
- 157594
- Author
- ander...@apple.com
- Date
- 2013-10-17 13:36:19 -0700 (Thu, 17 Oct 2013)
Log Message
Remove PlatformCAAnimation::supportsValueFunction()
https://bugs.webkit.org/show_bug.cgi?id=122990
Reviewed by Tim Horton.
PlatformCAAnimation::supportsValueFunction always returns true now, so there's no need for it to exist anymore.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
* platform/graphics/ca/PlatformCAAnimation.h:
* platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
* platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (157593 => 157594)
--- trunk/Source/WebCore/ChangeLog 2013-10-17 20:08:46 UTC (rev 157593)
+++ trunk/Source/WebCore/ChangeLog 2013-10-17 20:36:19 UTC (rev 157594)
@@ -1,3 +1,18 @@
+2013-10-17 Anders Carlsson <ander...@apple.com>
+
+ Remove PlatformCAAnimation::supportsValueFunction()
+ https://bugs.webkit.org/show_bug.cgi?id=122990
+
+ Reviewed by Tim Horton.
+
+ PlatformCAAnimation::supportsValueFunction always returns true now, so there's no need for it to exist anymore.
+
+ * platform/graphics/ca/GraphicsLayerCA.cpp:
+ (WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
+ * platform/graphics/ca/PlatformCAAnimation.h:
+ * platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
+ * platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
+
2013-10-17 Andreas Kling <akl...@apple.com>
CTTE: RenderMathMLFenced always has a MathMLInlineContainerElement.
Modified: trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp (157593 => 157594)
--- trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2013-10-17 20:08:46 UTC (rev 157593)
+++ trunk/Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp 2013-10-17 20:36:19 UTC (rev 157594)
@@ -2326,18 +2326,10 @@
int listIndex = validateTransformOperations(valueList, hasBigRotation);
const TransformOperations* operations = (listIndex >= 0) ? &static_cast<const TransformAnimationValue&>(valueList.at(listIndex)).value() : 0;
- // We need to fall back to software animation if we don't have setValueFunction:, and
- // we would need to animate each incoming transform function separately. This is the
- // case if we have a rotation >= 180 or we have more than one transform function.
- if ((hasBigRotation || (operations && operations->size() > 1)) && !PlatformCAAnimation::supportsValueFunction())
- return false;
-
bool validMatrices = true;
// If function lists don't match we do a matrix animation, otherwise we do a component hardware animation.
- // Also, we can't do component animation unless we have valueFunction, so we need to do matrix animation
- // if that's not true as well.
- bool isMatrixAnimation = listIndex < 0 || !PlatformCAAnimation::supportsValueFunction();
+ bool isMatrixAnimation = listIndex < 0;
int numAnimations = isMatrixAnimation ? 1 : operations->size();
bool reverseAnimationList = true;
Modified: trunk/Source/WebCore/platform/graphics/ca/PlatformCAAnimation.h (157593 => 157594)
--- trunk/Source/WebCore/platform/graphics/ca/PlatformCAAnimation.h 2013-10-17 20:08:46 UTC (rev 157593)
+++ trunk/Source/WebCore/platform/graphics/ca/PlatformCAAnimation.h 2013-10-17 20:36:19 UTC (rev 157594)
@@ -68,8 +68,6 @@
~PlatformCAAnimation();
- static bool supportsValueFunction();
-
PassRefPtr<PlatformCAAnimation> copy() const;
PlatformAnimationRef platformAnimation() const;
Modified: trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm (157593 => 157594)
--- trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm 2013-10-17 20:08:46 UTC (rev 157593)
+++ trunk/Source/WebCore/platform/graphics/ca/mac/PlatformCAAnimationMac.mm 2013-10-17 20:36:19 UTC (rev 157594)
@@ -214,12 +214,6 @@
{
}
-bool PlatformCAAnimation::supportsValueFunction()
-{
- static bool sHaveValueFunction = [CAPropertyAnimation instancesRespondToSelector:@selector(setValueFunction:)];
- return sHaveValueFunction;
-}
-
PlatformAnimationRef PlatformCAAnimation::platformAnimation() const
{
return m_animation.get();
Modified: trunk/Source/WebCore/platform/graphics/ca/win/PlatformCAAnimationWin.cpp (157593 => 157594)
--- trunk/Source/WebCore/platform/graphics/ca/win/PlatformCAAnimationWin.cpp 2013-10-17 20:08:46 UTC (rev 157593)
+++ trunk/Source/WebCore/platform/graphics/ca/win/PlatformCAAnimationWin.cpp 2013-10-17 20:36:19 UTC (rev 157594)
@@ -201,11 +201,6 @@
{
}
-bool PlatformCAAnimation::supportsValueFunction()
-{
- return true;
-}
-
PlatformAnimationRef PlatformCAAnimation::platformAnimation() const
{
return m_animation.get();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
