Title: [158080] trunk/Websites/test-results
- Revision
- 158080
- Author
- rn...@webkit.org
- Date
- 2013-10-25 23:13:37 -0700 (Fri, 25 Oct 2013)
Log Message
Build fix. The query results weren't sorted by the latest commit time,
yielding wrong set of tests to be listed in the builder pane.
* public/include/test-results.php:
Modified Paths
Diff
Modified: trunk/Websites/test-results/ChangeLog (158079 => 158080)
--- trunk/Websites/test-results/ChangeLog 2013-10-26 05:50:03 UTC (rev 158079)
+++ trunk/Websites/test-results/ChangeLog 2013-10-26 06:13:37 UTC (rev 158080)
@@ -1,5 +1,12 @@
2013-10-25 Ryosuke Niwa <rn...@webkit.org>
+ Build fix. The query results weren't sorted by the latest commit time,
+ yielding wrong set of tests to be listed in the builder pane.
+
+ * public/include/test-results.php:
+
+2013-10-25 Ryosuke Niwa <rn...@webkit.org>
+
Links in new flakiness dashboard could benefit from tooltips
https://bugs.webkit.org/show_bug.cgi?id=123381
Modified: trunk/Websites/test-results/public/include/test-results.php (158079 => 158080)
--- trunk/Websites/test-results/public/include/test-results.php 2013-10-26 05:50:03 UTC (rev 158079)
+++ trunk/Websites/test-results/public/include/test-results.php 2013-10-26 06:13:37 UTC (rev 158080)
@@ -197,12 +197,12 @@
$number_of_days = self::MAXIMUM_NUMBER_OF_DAYS;
$all_results = $this->db->query(
"SELECT results.*, builds.* FROM results
- JOIN (SELECT builds.*, array_agg((build_revisions.repository, build_revisions.value, build_revisions.time)) AS revisions
+ JOIN (SELECT builds.*, array_agg((build_revisions.repository, build_revisions.value, build_revisions.time)) AS revisions,
+ max(build_revisions.time) AS latest_revision_time
FROM builds, build_revisions
WHERE build_revisions.build = builds.id AND builds.builder = $1 AND builds.start_time > now() - interval '$number_of_days days'
- GROUP BY builds.id
- ORDER BY max(build_revisions.time) DESC) as builds ON results.build = builds.id
- ORDER BY results.test", array($this->builder_id));
+ GROUP BY builds.id) as builds ON results.build = builds.id
+ ORDER BY results.test, latest_revision_time DESC", array($this->builder_id));
if (!$all_results)
return FALSE;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
