Title: [158472] trunk/Source/WebCore
- Revision
- 158472
- Author
- akl...@apple.com
- Date
- 2013-11-01 18:23:53 -0700 (Fri, 01 Nov 2013)
Log Message
CSSCanvasValue construction helper should return PassRef.
<https://webkit.org/b/123650>
Return PassRef instead of PassRefPtr from functions that return
ownership-passing pointers that are known to be non-null.
Reviewed by Anders Carlsson.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (158471 => 158472)
--- trunk/Source/WebCore/ChangeLog 2013-11-02 01:22:42 UTC (rev 158471)
+++ trunk/Source/WebCore/ChangeLog 2013-11-02 01:23:53 UTC (rev 158472)
@@ -1,3 +1,13 @@
+2013-11-01 Andreas Kling <akl...@apple.com>
+
+ CSSCanvasValue construction helper should return PassRef.
+ <https://webkit.org/b/123650>
+
+ Return PassRef instead of PassRefPtr from functions that return
+ ownership-passing pointers that are known to be non-null.
+
+ Reviewed by Anders Carlsson.
+
2013-11-01 Joseph Pecoraro <pecor...@apple.com>
Move CF/Mac WTF String implementations down into WTF
Modified: trunk/Source/WebCore/css/CSSCanvasValue.h (158471 => 158472)
--- trunk/Source/WebCore/css/CSSCanvasValue.h 2013-11-02 01:22:42 UTC (rev 158471)
+++ trunk/Source/WebCore/css/CSSCanvasValue.h 2013-11-02 01:23:53 UTC (rev 158472)
@@ -35,7 +35,7 @@
class CSSCanvasValue : public CSSImageGeneratorValue {
public:
- static PassRefPtr<CSSCanvasValue> create(const String& name) { return adoptRef(new CSSCanvasValue(name)); }
+ static PassRef<CSSCanvasValue> create(const String& name) { return adoptRef(*new CSSCanvasValue(name)); }
~CSSCanvasValue();
String customCSSText() const;
@@ -50,7 +50,7 @@
bool equals(const CSSCanvasValue&) const;
private:
- CSSCanvasValue(const String& name)
+ explicit CSSCanvasValue(const String& name)
: CSSImageGeneratorValue(CanvasClass)
, m_canvasObserver(this)
, m_name(name)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
