Title: [159334] trunk/Source/WebKit/efl
- Revision
- 159334
- Author
- be...@igalia.com
- Date
- 2013-11-15 06:08:00 -0800 (Fri, 15 Nov 2013)
Log Message
[EFL] Leak in ewk_frame_certificate_status_get()
https://bugs.webkit.org/show_bug.cgi?id=124401
Reviewed by Carlos Garcia Campos.
The SoupMessage object is being leaked. In in this case that
object is not even necessary since ResourceRequest already
provides a way to get the soup flags directly.
* ewk/ewk_frame.cpp:
(ewk_frame_certificate_status_get):
Modified Paths
Diff
Modified: trunk/Source/WebKit/efl/ChangeLog (159333 => 159334)
--- trunk/Source/WebKit/efl/ChangeLog 2013-11-15 13:09:28 UTC (rev 159333)
+++ trunk/Source/WebKit/efl/ChangeLog 2013-11-15 14:08:00 UTC (rev 159334)
@@ -1,3 +1,17 @@
+2013-11-15 Alberto Garcia <be...@igalia.com>
+
+ [EFL] Leak in ewk_frame_certificate_status_get()
+ https://bugs.webkit.org/show_bug.cgi?id=124401
+
+ Reviewed by Carlos Garcia Campos.
+
+ The SoupMessage object is being leaked. In in this case that
+ object is not even necessary since ResourceRequest already
+ provides a way to get the soup flags directly.
+
+ * ewk/ewk_frame.cpp:
+ (ewk_frame_certificate_status_get):
+
2013-11-10 Tibor Meszaros <mti...@inf.u-szeged.hu>
Cleanup the EFL --minimal build from unused parameters
Modified: trunk/Source/WebKit/efl/ewk/ewk_frame.cpp (159333 => 159334)
--- trunk/Source/WebKit/efl/ewk/ewk_frame.cpp 2013-11-15 13:09:28 UTC (rev 159333)
+++ trunk/Source/WebKit/efl/ewk/ewk_frame.cpp 2013-11-15 14:08:00 UTC (rev 159334)
@@ -1699,9 +1699,7 @@
if (frameLoader.subframeIsLoading())
return EWK_CERTIFICATE_STATUS_NO_CERTIFICATE;
- SoupMessage* soupMessage = documentLoader->request().toSoupMessage();
-
- if (soupMessage && (soup_message_get_flags(soupMessage) & SOUP_MESSAGE_CERTIFICATE_TRUSTED))
+ if (documentLoader->request().soupMessageFlags() & SOUP_MESSAGE_CERTIFICATE_TRUSTED)
return EWK_CERTIFICATE_STATUS_TRUSTED;
return EWK_CERTIFICATE_STATUS_UNTRUSTED;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
