Title: [159342] trunk/Tools
- Revision
- 159342
- Author
- timothy_hor...@apple.com
- Date
- 2013-11-15 09:47:10 -0800 (Fri, 15 Nov 2013)
Log Message
Make it possible to select revision numbers on build.webkit.org/dashboard
https://bugs.webkit.org/show_bug.cgi?id=124400
Reviewed by Timothy Hatcher.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
(BuildbotQueueView.prototype.revisionLinksForIteration):
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(.selectable):
Add a child span to the trac link, which has '-webkit-user-select: all' on it.
This way, a Dashboard user can highlight revision numbers for easy copying,
and doesn't even have to be precise about the selection.
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js (159341 => 159342)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2013-11-15 17:44:11 UTC (rev 159341)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js 2013-11-15 17:47:10 UTC (rev 159342)
@@ -77,8 +77,14 @@
{
var linkElement = document.createElement("a");
linkElement.href = "" internal);
- linkElement.textContent = "r" + revision;
linkElement.target = "_blank";
+ linkElement.textContent = "r";
+
+ var revisionLabel = document.createElement("span");
+ revisionLabel.classList.add("selectable");
+ revisionLabel.textContent = revision;
+ linkElement.appendChild(revisionLabel);
+
return linkElement;
}
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css (159341 => 159342)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css 2013-11-15 17:44:11 UTC (rev 159341)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css 2013-11-15 17:47:10 UTC (rev 159342)
@@ -34,6 +34,10 @@
cursor: pointer;
}
+.selectable {
+ -webkit-user-select: all;
+}
+
body {
background-color: rgb(233, 231, 223);
text-align: center;
Modified: trunk/Tools/ChangeLog (159341 => 159342)
--- trunk/Tools/ChangeLog 2013-11-15 17:44:11 UTC (rev 159341)
+++ trunk/Tools/ChangeLog 2013-11-15 17:47:10 UTC (rev 159342)
@@ -1,5 +1,20 @@
2013-11-15 Tim Horton <timothy_hor...@apple.com>
+ Make it possible to select revision numbers on build.webkit.org/dashboard
+ https://bugs.webkit.org/show_bug.cgi?id=124400
+
+ Reviewed by Timothy Hatcher.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
+ (BuildbotQueueView.prototype.revisionLinksForIteration):
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
+ (.selectable):
+ Add a child span to the trac link, which has '-webkit-user-select: all' on it.
+ This way, a Dashboard user can highlight revision numbers for easy copying,
+ and doesn't even have to be precise about the selection.
+
+2013-11-15 Tim Horton <timothy_hor...@apple.com>
+
Adjust and add retina versions of EFL and GTK build.webkit.org/dashboard icons
https://bugs.webkit.org/show_bug.cgi?id=124399
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
