Title: [159683] trunk/Source/WebCore
- Revision
- 159683
- Author
- r...@igalia.com
- Date
- 2013-11-22 01:22:50 -0800 (Fri, 22 Nov 2013)
Log Message
[CSS Regions] Move code after early break in RenderRegion::repaintFlowThreadContentRectangle
https://bugs.webkit.org/show_bug.cgi?id=124743
Reviewed by Mihnea Ovidenie.
No new tests, covered by existing tests.
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::repaintFlowThreadContentRectangle): Variable
flippedFlowThreadPortionRect is not used before the early break, so we
can move it after and save some unneeded operations.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (159682 => 159683)
--- trunk/Source/WebCore/ChangeLog 2013-11-22 08:28:26 UTC (rev 159682)
+++ trunk/Source/WebCore/ChangeLog 2013-11-22 09:22:50 UTC (rev 159683)
@@ -1,5 +1,19 @@
2013-11-22 Manuel Rego Casasnovas <r...@igalia.com>
+ [CSS Regions] Move code after early break in RenderRegion::repaintFlowThreadContentRectangle
+ https://bugs.webkit.org/show_bug.cgi?id=124743
+
+ Reviewed by Mihnea Ovidenie.
+
+ No new tests, covered by existing tests.
+
+ * rendering/RenderRegion.cpp:
+ (WebCore::RenderRegion::repaintFlowThreadContentRectangle): Variable
+ flippedFlowThreadPortionRect is not used before the early break, so we
+ can move it after and save some unneeded operations.
+
+2013-11-22 Manuel Rego Casasnovas <r...@igalia.com>
+
[CSS Regions] Use hasOverflowClip() in RenderRegion
https://bugs.webkit.org/show_bug.cgi?id=124746
Modified: trunk/Source/WebCore/rendering/RenderRegion.cpp (159682 => 159683)
--- trunk/Source/WebCore/rendering/RenderRegion.cpp 2013-11-22 08:28:26 UTC (rev 159682)
+++ trunk/Source/WebCore/rendering/RenderRegion.cpp 2013-11-22 09:22:50 UTC (rev 159683)
@@ -371,9 +371,6 @@
ASSERT(isValid());
// We only have to issue a repaint in this region if the region rect intersects the repaint rect.
- LayoutRect flippedFlowThreadPortionRect(flowThreadPortionRect);
- flowThread()->flipForWritingMode(flippedFlowThreadPortionRect); // Put the region rects into physical coordinates.
-
LayoutRect clippedRect(repaintRect);
if (flowThreadPortionClipRect) {
@@ -385,6 +382,9 @@
if (clippedRect.isEmpty())
return;
+ LayoutRect flippedFlowThreadPortionRect(flowThreadPortionRect);
+ flowThread()->flipForWritingMode(flippedFlowThreadPortionRect); // Put the region rects into physical coordinates.
+
// Put the region rect into the region's physical coordinate space.
clippedRect.setLocation(regionLocation + (clippedRect.location() - flippedFlowThreadPortionRect.location()));
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
