Title: [159722] trunk/Source
- Revision
- 159722
- Author
- jer.no...@apple.com
- Date
- 2013-11-22 16:57:51 -0800 (Fri, 22 Nov 2013)
Log Message
[Mac] Can't drag full-screen video to another monitor
https://bugs.webkit.org/show_bug.cgi?id=124798
Reviewed by Geoffrey Garen.
Source/WebCore:
Make full screen windows movable by default. Previously, we wanted non-movable full screen
windows since they were in the same space and were just placed atop non-full screen windows.
Now that all our supported Mac platforms have explicit full screen support, we can remove this
non-movable restriction.
* platform/mac/WebCoreFullScreenWindow.mm:
(-[WebCoreFullScreenWindow initWithContentRect:styleMask:backing:defer:]):
Source/WebKit2:
Make full screen windows resizable by default. This allows the window to be resized when
moved between monitors with different resolutions.
* UIProcess/API/mac/WKView.mm:
(-[WKView createFullScreenWindow]):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (159721 => 159722)
--- trunk/Source/WebCore/ChangeLog 2013-11-23 00:36:55 UTC (rev 159721)
+++ trunk/Source/WebCore/ChangeLog 2013-11-23 00:57:51 UTC (rev 159722)
@@ -1,3 +1,18 @@
+2013-11-22 Jer Noble <jer.no...@apple.com>
+
+ [Mac] Can't drag full-screen video to another monitor
+ https://bugs.webkit.org/show_bug.cgi?id=124798
+
+ Reviewed by Geoffrey Garen.
+
+ Make full screen windows movable by default. Previously, we wanted non-movable full screen
+ windows since they were in the same space and were just placed atop non-full screen windows.
+ Now that all our supported Mac platforms have explicit full screen support, we can remove this
+ non-movable restriction.
+
+ * platform/mac/WebCoreFullScreenWindow.mm:
+ (-[WebCoreFullScreenWindow initWithContentRect:styleMask:backing:defer:]):
+
2013-11-22 Brent Fulgham <bfulg...@apple.com>
[Win] Clean up ColorSpace handling in Windows code
Modified: trunk/Source/WebCore/platform/mac/WebCoreFullScreenWindow.mm (159721 => 159722)
--- trunk/Source/WebCore/platform/mac/WebCoreFullScreenWindow.mm 2013-11-23 00:36:55 UTC (rev 159721)
+++ trunk/Source/WebCore/platform/mac/WebCoreFullScreenWindow.mm 2013-11-23 00:57:51 UTC (rev 159722)
@@ -42,7 +42,6 @@
[self setAcceptsMouseMovedEvents:YES];
[self setReleasedWhenClosed:NO];
[self setHasShadow:NO];
- [self setMovable:NO];
return self;
}
Modified: trunk/Source/WebKit2/ChangeLog (159721 => 159722)
--- trunk/Source/WebKit2/ChangeLog 2013-11-23 00:36:55 UTC (rev 159721)
+++ trunk/Source/WebKit2/ChangeLog 2013-11-23 00:57:51 UTC (rev 159722)
@@ -1,3 +1,16 @@
+2013-11-22 Jer Noble <jer.no...@apple.com>
+
+ [Mac] Can't drag full-screen video to another monitor
+ https://bugs.webkit.org/show_bug.cgi?id=124798
+
+ Reviewed by Geoffrey Garen.
+
+ Make full screen windows resizable by default. This allows the window to be resized when
+ moved between monitors with different resolutions.
+
+ * UIProcess/API/mac/WKView.mm:
+ (-[WKView createFullScreenWindow]):
+
2013-11-22 Benjamin Poulain <bpoul...@apple.com>
[WK2] Another build fix for NetworkProcess on iOS
Modified: trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm (159721 => 159722)
--- trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2013-11-23 00:36:55 UTC (rev 159721)
+++ trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm 2013-11-23 00:57:51 UTC (rev 159722)
@@ -3235,7 +3235,7 @@
#else
NSRect contentRect = [[NSScreen mainScreen] frame];
#endif
- return [[[WebCoreFullScreenWindow alloc] initWithContentRect:contentRect styleMask:NSBorderlessWindowMask backing:NSBackingStoreBuffered defer:NO] autorelease];
+ return [[[WebCoreFullScreenWindow alloc] initWithContentRect:contentRect styleMask:(NSBorderlessWindowMask | NSResizableWindowMask) backing:NSBackingStoreBuffered defer:NO] autorelease];
#else
return nil;
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
