Title: [159726] trunk
Revision
159726
Author
rn...@webkit.org
Date
2013-11-22 20:50:45 -0800 (Fri, 22 Nov 2013)

Log Message

Layout Test editing/deleting/password-delete-performance.html is failing
https://bugs.webkit.org/show_bug.cgi?id=124781

Reviewed by Alexey Proskuryakov.

PerformanceTests:

Add a new performance test to replace editing/deleting/password-delete-performance.html.
We skip this test by default since it's a micro benchmark.

* Interactive/DeletingInPasswordField.html: Added.
* Skipped:

LayoutTests:

Removed the test that has been timing out.

* TestExpectations:
* editing/deleting/password-delete-performance.html: Removed.

Modified Paths

Added Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (159725 => 159726)


--- trunk/LayoutTests/ChangeLog	2013-11-23 03:43:57 UTC (rev 159725)
+++ trunk/LayoutTests/ChangeLog	2013-11-23 04:50:45 UTC (rev 159726)
@@ -1,3 +1,15 @@
+2013-11-22  Ryosuke Niwa  <rn...@webkit.org>
+
+        Layout Test editing/deleting/password-delete-performance.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=124781
+
+        Reviewed by Alexey Proskuryakov.
+
+        Removed the test that has been timing out.
+
+        * TestExpectations:
+        * editing/deleting/password-delete-performance.html: Removed.
+
 2013-11-22  Brendan Long  <b.l...@cablelabs.com>
 
         Fire "change" event on TextTrackList when a TextTrack's mode changes

Modified: trunk/LayoutTests/TestExpectations (159725 => 159726)


--- trunk/LayoutTests/TestExpectations	2013-11-23 03:43:57 UTC (rev 159725)
+++ trunk/LayoutTests/TestExpectations	2013-11-23 04:50:45 UTC (rev 159726)
@@ -69,6 +69,3 @@
 # The spec is not clear if the MediaStream ended event should be fired if stop is called on each MediaStream's track
 # Skipping it for now, then put it again when the spec decides it
 fast/mediastream/MediaStream-onended.html [ Skip ]
-
-# Times out on most runs
-webkit.org/b/124781 editing/deleting/password-delete-performance.html [ Skip ]

Deleted: trunk/LayoutTests/editing/deleting/password-delete-performance.html (159725 => 159726)


--- trunk/LayoutTests/editing/deleting/password-delete-performance.html	2013-11-23 03:43:57 UTC (rev 159725)
+++ trunk/LayoutTests/editing/deleting/password-delete-performance.html	2013-11-23 04:50:45 UTC (rev 159726)
@@ -1,31 +0,0 @@
-<!DOCTYPE html>
-<html>
-    <body>
-        <p id="description">This test ensures that deleting characters from a password field that follows large content blocks is not slow.
-        To run the test manually, delete the character from the password field. The user agent should not freeze.</p>
-
-        <div id="content" style="height:0px; overflow:hidden;"> </div>
-        <input id="field" type="password" value="A">
-
-        <script src=""
-        <script>
-            if (window.testRunner)
-                testRunner.dumpAsText();
-
-            var newContent = '<p>Lorem ipsum dolor sit amet, consectetuer adipiscing elit.</p>';
-            for (var i = 0; i < 15; i++) {
-                newContent += newContent;
-            }
-
-            var contentDiv = document.getElementById('content');
-            contentDiv.innerHTML = newContent;
-
-            document.getElementById("field").focus();
-            document.execCommand("Delete");
-
-            // We clear the content div to avoid having its content appear in the test harness output.
-            if (window.testRunner)
-                contentDiv.innerHTML = "";
-        </script>
-    </body>
-</html>

Modified: trunk/PerformanceTests/ChangeLog (159725 => 159726)


--- trunk/PerformanceTests/ChangeLog	2013-11-23 03:43:57 UTC (rev 159725)
+++ trunk/PerformanceTests/ChangeLog	2013-11-23 04:50:45 UTC (rev 159726)
@@ -1,3 +1,16 @@
+2013-11-22  Ryosuke Niwa  <rn...@webkit.org>
+
+        Layout Test editing/deleting/password-delete-performance.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=124781
+
+        Reviewed by Alexey Proskuryakov.
+
+        Add a new performance test to replace editing/deleting/password-delete-performance.html.
+        We skip this test by default since it's a micro benchmark.
+
+        * Interactive/DeletingInPasswordField.html: Added.
+        * Skipped:
+
 2013-11-18  Sergio Villar Senin  <svil...@igalia.com>
 
         [CSS Grid Layout] Improve content-sized track layout

Added: trunk/PerformanceTests/Interactive/DeletingInPasswordField.html (0 => 159726)


--- trunk/PerformanceTests/Interactive/DeletingInPasswordField.html	                        (rev 0)
+++ trunk/PerformanceTests/Interactive/DeletingInPasswordField.html	2013-11-23 04:50:45 UTC (rev 159726)
@@ -0,0 +1,32 @@
+<!DOCTYPE html>
+<html>
+<body>
+<div id="content" style="height:0px; overflow:hidden;"> </div>
+<input id="field" type="password" value="">
+<script src=""
+<script>
+var content = document.getElementById('content');
+var field = document.getElementById('field');
+
+var newContent = '<p>Lorem ipsum dolor sit amet, consectetuer adipiscing elit.</p>';
+for (var i = 0; i < 12; i++)
+    newContent += newContent;
+content.innerHTML = newContent;
+
+PerfTestRunner.measureTime({
+    unit: 'ms',
+    setup: function () {
+        field.value = 'A';
+    },
+    run: function () {
+        field.focus();
+        document.execCommand('Delete');
+    },
+    done: function () {
+        content.innerHTML = '';
+    }
+});
+
+</script>
+</body>
+</html>

Modified: trunk/PerformanceTests/Skipped (159725 => 159726)


--- trunk/PerformanceTests/Skipped	2013-11-23 03:43:57 UTC (rev 159725)
+++ trunk/PerformanceTests/Skipped	2013-11-23 04:50:45 UTC (rev 159726)
@@ -2,6 +2,7 @@
 DOM/TraverseChildNodes.html
 Interactive/SelectAll.html
 Interactive/CopyAll.html
+Interactive/DeletingInPasswordField.html
 
 # Not enabled by default on some ports
 Mutation
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to