Title: [159915] trunk/Source/WebCore
- Revision
- 159915
- Author
- commit-qu...@webkit.org
- Date
- 2013-12-02 01:08:31 -0800 (Mon, 02 Dec 2013)
Log Message
HTML5 required attribute validation messages implemented.
https://bugs.webkit.org/show_bug.cgi?id=125003
Patch by Attila Dusnoki <adusn...@inf.u-szeged.hu> on 2013-12-02
Reviewed by Gyuyoung Kim.
* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::validationMessagePatternMismatchText):
(WebCore::validationMessageValueMissingText):
(WebCore::validationMessageValueMissingForCheckboxText):
(WebCore::validationMessageValueMissingForFileText):
(WebCore::validationMessageValueMissingForMultipleFileText):
(WebCore::validationMessageValueMissingForRadioText):
(WebCore::validationMessageValueMissingForSelectText):
(WebCore::validationMessageBadInputForNumberText):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (159914 => 159915)
--- trunk/Source/WebCore/ChangeLog 2013-12-02 08:59:22 UTC (rev 159914)
+++ trunk/Source/WebCore/ChangeLog 2013-12-02 09:08:31 UTC (rev 159915)
@@ -1,3 +1,20 @@
+2013-12-02 Attila Dusnoki <adusn...@inf.u-szeged.hu>
+
+ HTML5 required attribute validation messages implemented.
+ https://bugs.webkit.org/show_bug.cgi?id=125003
+
+ Reviewed by Gyuyoung Kim.
+
+ * platform/efl/LocalizedStringsEfl.cpp:
+ (WebCore::validationMessagePatternMismatchText):
+ (WebCore::validationMessageValueMissingText):
+ (WebCore::validationMessageValueMissingForCheckboxText):
+ (WebCore::validationMessageValueMissingForFileText):
+ (WebCore::validationMessageValueMissingForMultipleFileText):
+ (WebCore::validationMessageValueMissingForRadioText):
+ (WebCore::validationMessageValueMissingForSelectText):
+ (WebCore::validationMessageBadInputForNumberText):
+
2013-12-01 Andreas Kling <akl...@apple.com>
SVG: Intersection/enclosure checks should use RenderElement.
Modified: trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp (159914 => 159915)
--- trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp 2013-12-02 08:59:22 UTC (rev 159914)
+++ trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp 2013-12-02 09:08:31 UTC (rev 159915)
@@ -528,7 +528,7 @@
String validationMessagePatternMismatchText()
{
- return String::fromUTF8("pattern mismatch");
+ return ASCIILiteral("Please match the requested format:");
}
String validationMessageRangeOverflowText(const String& maximum)
@@ -573,43 +573,37 @@
String validationMessageValueMissingText()
{
- return String::fromUTF8("value missing");
+ return ASCIILiteral("Please fill out this field.");
}
String validationMessageValueMissingForCheckboxText()
{
- notImplemented();
- return validationMessageValueMissingText();
+ return ASCIILiteral("Please check this box if you want to proceed.");
}
String validationMessageValueMissingForFileText()
{
- notImplemented();
- return validationMessageValueMissingText();
+ return ASCIILiteral("Please select a file.");
}
String validationMessageValueMissingForMultipleFileText()
{
- notImplemented();
- return validationMessageValueMissingText();
+ return ASCIILiteral("Please select one or more files.");
}
String validationMessageValueMissingForRadioText()
{
- notImplemented();
- return validationMessageValueMissingText();
+ return ASCIILiteral("Please select one of these options.");
}
String validationMessageValueMissingForSelectText()
{
- notImplemented();
- return validationMessageValueMissingText();
+ return ASCIILiteral("Please select an item in the list.");
}
String validationMessageBadInputForNumberText()
{
- notImplemented();
- return validationMessageTypeMismatchText();
+ return ASCIILiteral("Please enter a number.");
}
String missingPluginText()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
