Title: [161390] branches/jsCStack/Source/_javascript_Core
- Revision
- 161390
- Author
- msab...@apple.com
- Date
- 2014-01-06 17:55:49 -0800 (Mon, 06 Jan 2014)
Log Message
CStack Branch: Disable JIT stack alignment check for ARM64
https://bugs.webkit.org/show_bug.cgi?id=126550
Reviewed by Mark Lam.
Since ARM64 enforces strict stack alignment, the need for checkStackPointerAlignment()
is not needed. Also, the implementation of checkStackPointerAlignment() would
need to be reworked given the limits on the operations that can be done with
the stack pointer register in ARM64. Therefore conditionally disabled
checkStackPointerAlignment() for ARM64.
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::checkStackPointerAlignment):
Modified Paths
Diff
Modified: branches/jsCStack/Source/_javascript_Core/ChangeLog (161389 => 161390)
--- branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-07 01:44:33 UTC (rev 161389)
+++ branches/jsCStack/Source/_javascript_Core/ChangeLog 2014-01-07 01:55:49 UTC (rev 161390)
@@ -1,3 +1,19 @@
+2014-01-06 Michael Saboff <msab...@apple.com>
+
+ CStack Branch: Disable JIT stack alignment check for ARM64
+ https://bugs.webkit.org/show_bug.cgi?id=126550
+
+ Reviewed by Mark Lam.
+
+ Since ARM64 enforces strict stack alignment, the need for checkStackPointerAlignment()
+ is not needed. Also, the implementation of checkStackPointerAlignment() would
+ need to be reworked given the limits on the operations that can be done with
+ the stack pointer register in ARM64. Therefore conditionally disabled
+ checkStackPointerAlignment() for ARM64.
+
+ * jit/AssemblyHelpers.h:
+ (JSC::AssemblyHelpers::checkStackPointerAlignment):
+
2014-01-06 Mark Lam <mark....@apple.com>
CStack: JSLock drop and grab lock APIs should be private.
Modified: branches/jsCStack/Source/_javascript_Core/jit/AssemblyHelpers.h (161389 => 161390)
--- branches/jsCStack/Source/_javascript_Core/jit/AssemblyHelpers.h 2014-01-07 01:44:33 UTC (rev 161389)
+++ branches/jsCStack/Source/_javascript_Core/jit/AssemblyHelpers.h 2014-01-07 01:55:49 UTC (rev 161390)
@@ -61,7 +61,7 @@
void checkStackPointerAlignment()
{
-#ifndef NDEBUG
+#if !defined(NDEBUG) && !CPU(ARM64)
Jump stackPointerAligned = branchTestPtr(Zero, stackPointerRegister, TrustedImm32(0xf));
breakpoint();
stackPointerAligned.link(this);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
