Title: [163264] trunk/Source/WebCore
- Revision
- 163264
- Author
- za...@apple.com
- Date
- 2014-02-02 09:44:48 -0800 (Sun, 02 Feb 2014)
Log Message
Floor thickness and length after switching from int to float.
https://bugs.webkit.org/show_bug.cgi?id=128071
Reviewed by Antti Koivisto.
This is a temporary solution to fix the assertion on empty line drawing until after
device pixel snapping is added.
Covered by existing tests.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::drawLineForBoxSide):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (163263 => 163264)
--- trunk/Source/WebCore/ChangeLog 2014-02-02 17:27:02 UTC (rev 163263)
+++ trunk/Source/WebCore/ChangeLog 2014-02-02 17:44:48 UTC (rev 163264)
@@ -1,3 +1,18 @@
+2014-02-02 Zalan Bujtas <za...@apple.com>
+
+ Floor thickness and length after switching from int to float.
+ https://bugs.webkit.org/show_bug.cgi?id=128071
+
+ Reviewed by Antti Koivisto.
+
+ This is a temporary solution to fix the assertion on empty line drawing until after
+ device pixel snapping is added.
+
+ Covered by existing tests.
+
+ * rendering/RenderObject.cpp:
+ (WebCore::RenderObject::drawLineForBoxSide):
+
2014-02-02 Antti Koivisto <an...@apple.com>
Remove StyleScopeResolver
Modified: trunk/Source/WebCore/rendering/RenderObject.cpp (163263 => 163264)
--- trunk/Source/WebCore/rendering/RenderObject.cpp 2014-02-02 17:27:02 UTC (rev 163263)
+++ trunk/Source/WebCore/rendering/RenderObject.cpp 2014-02-02 17:44:48 UTC (rev 163264)
@@ -751,7 +751,8 @@
// FIXME: We really would like this check to be an ASSERT as we don't want to draw empty borders. However
// nothing guarantees that the following recursive calls to drawLineForBoxSide will have non-null dimensions.
- if (!thickness || !length)
+ // FIXME: flooring is a temporary solution until the device pixel snapping is added here.
+ if (!floor(thickness) || !floor(length))
return;
if (borderStyle == DOUBLE && thickness < 3)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
