Title: [163268] trunk/Tools
- Revision
- 163268
- Author
- dba...@webkit.org
- Date
- 2014-02-02 12:31:03 -0800 (Sun, 02 Feb 2014)
Log Message
WebKit Bot Watcher's Dashboard: Access restricted queue should only prompt for HTTP credentials once per page load
https://bugs.webkit.org/show_bug.cgi?id=127849
I inadvertently used the equality operator instead of the identity operator when comparing the
value of the error HTTP status code with the numeric literal 401.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
(BuildbotQueue.prototype.update):
Modified Paths
Diff
Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js (163267 => 163268)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js 2014-02-02 20:29:50 UTC (rev 163267)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js 2014-02-02 20:31:03 UTC (rev 163268)
@@ -170,7 +170,7 @@
this.update();
return;
}
- if (data.errorType === JSON.LoadError && data.errorHTTPCode == 401) {
+ if (data.errorType === JSON.LoadError && data.errorHTTPCode === 401) {
this.buildbot.isAuthenticated = false;
this.dispatchEventToListeners(BuildbotQueue.Event.UnauthorizedAccess, { });
}
Modified: trunk/Tools/ChangeLog (163267 => 163268)
--- trunk/Tools/ChangeLog 2014-02-02 20:29:50 UTC (rev 163267)
+++ trunk/Tools/ChangeLog 2014-02-02 20:31:03 UTC (rev 163268)
@@ -1,5 +1,16 @@
2014-02-02 Daniel Bates <daba...@apple.com>
+ WebKit Bot Watcher's Dashboard: Access restricted queue should only prompt for HTTP credentials once per page load
+ https://bugs.webkit.org/show_bug.cgi?id=127849
+
+ I inadvertently used the equality operator instead of the identity operator when comparing the
+ value of the error HTTP status code with the numeric literal 401.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
+ (BuildbotQueue.prototype.update):
+
+2014-02-02 Daniel Bates <daba...@apple.com>
+
Attempt to fix production dashboard after <http://trac.webkit.org/changeset/163222>
Actually pass option dictionary to JSON.load(); JSON.load() takes four arguments with the
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
