Title: [163282] trunk/Source/WebCore
Revision
163282
Author
akl...@apple.com
Date
2014-02-02 20:44:10 -0800 (Sun, 02 Feb 2014)

Log Message

Minor SVGRootInlineBox cleanup.
<https://webkit.org/b/128094>

Remove two virtual functions and sprinkle some missing overrides.

Reviewed by Anders Carlsson.

* rendering/svg/SVGRootInlineBox.h:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (163281 => 163282)


--- trunk/Source/WebCore/ChangeLog	2014-02-03 02:35:22 UTC (rev 163281)
+++ trunk/Source/WebCore/ChangeLog	2014-02-03 04:44:10 UTC (rev 163282)
@@ -1,3 +1,14 @@
+2014-02-02  Andreas Kling  <akl...@apple.com>
+
+        Minor SVGRootInlineBox cleanup.
+        <https://webkit.org/b/128094>
+
+        Remove two virtual functions and sprinkle some missing overrides.
+
+        Reviewed by Anders Carlsson.
+
+        * rendering/svg/SVGRootInlineBox.h:
+
 2014-01-30  Oliver Hunt  <oli...@apple.com>
 
         Push DOM attributes into the prototype chain

Modified: trunk/Source/WebCore/rendering/svg/SVGRootInlineBox.h (163281 => 163282)


--- trunk/Source/WebCore/rendering/svg/SVGRootInlineBox.h	2014-02-03 02:35:22 UTC (rev 163281)
+++ trunk/Source/WebCore/rendering/svg/SVGRootInlineBox.h	2014-02-03 04:44:10 UTC (rev 163282)
@@ -35,20 +35,17 @@
 
 class SVGRootInlineBox final : public RootInlineBox {
 public:
-    SVGRootInlineBox(RenderSVGText&);
+    explicit SVGRootInlineBox(RenderSVGText&);
 
     RenderSVGText& renderSVGText();
 
-    virtual float virtualLogicalHeight() const { return m_logicalHeight; }
+    virtual float virtualLogicalHeight() const override { return m_logicalHeight; }
     void setLogicalHeight(float height) { m_logicalHeight = height; }
 
-    virtual void paint(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom);
+    virtual void paint(PaintInfo&, const LayoutPoint&, LayoutUnit lineTop, LayoutUnit lineBottom) override;
 
     void computePerCharacterLayoutInformation();
 
-    virtual FloatRect objectBoundingBox() const { return FloatRect(); }
-    virtual FloatRect repaintRectInLocalCoordinates() const { return FloatRect(); }
-
     InlineBox* closestLeafChildForPosition(const LayoutPoint&);
 
 private:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to