Title: [163659] trunk/Source/WebCore
Revision
163659
Author
roger_f...@apple.com
Date
2014-02-07 16:16:51 -0800 (Fri, 07 Feb 2014)

Log Message

CGContextGetUserSpaceToDeviceSpaceTransform returns the wrong value on Windows.
https://bugs.webkit.org/show_bug.cgi?id=128395.

Rubberstamped by Zalan Bujtas.

The call essentially returns 0 and causes an assertion failure when running many layout tests.

* platform/graphics/cg/GraphicsContextCG.cpp: Don't make the call on Windows. We default to 1.
(WebCore::GraphicsContext::platformInit):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (163658 => 163659)


--- trunk/Source/WebCore/ChangeLog	2014-02-08 00:07:48 UTC (rev 163658)
+++ trunk/Source/WebCore/ChangeLog	2014-02-08 00:16:51 UTC (rev 163659)
@@ -1,3 +1,15 @@
+2014-02-07  Roger Fong  <roger_f...@apple.com>
+
+        CGContextGetUserSpaceToDeviceSpaceTransform returns the wrong value on Windows.
+        https://bugs.webkit.org/show_bug.cgi?id=128395.
+        
+        Rubberstamped by Zalan Bujtas.
+
+        The call essentially returns 0 and causes an assertion failure when running many layout tests.
+
+        * platform/graphics/cg/GraphicsContextCG.cpp: Don't make the call on Windows. We default to 1.
+        (WebCore::GraphicsContext::platformInit):
+
 2014-02-07  Dan Bernstein  <m...@apple.com>
 
         iOS build fix.

Modified: trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp (163658 => 163659)


--- trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp	2014-02-08 00:07:48 UTC (rev 163658)
+++ trunk/Source/WebCore/platform/graphics/cg/GraphicsContextCG.cpp	2014-02-08 00:16:51 UTC (rev 163659)
@@ -127,7 +127,9 @@
     if (cgContext) {
         CGAffineTransform baseDeviceMatrix = CGContextGetUserSpaceToDeviceSpaceTransform(cgContext);
         ASSERT(fabs(baseDeviceMatrix.a) == fabs(baseDeviceMatrix.d));
+#if !PLATFORM(WIN)
         m_pixelSnappingFactor = baseDeviceMatrix.a;
+#endif
 #if PLATFORM(IOS)
         m_state.shouldUseContextColors = shouldUseContextColors;
         if (shouldUseContextColors) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to