Diff
Modified: trunk/LayoutTests/ChangeLog (164144 => 164145)
--- trunk/LayoutTests/ChangeLog 2014-02-15 00:54:36 UTC (rev 164144)
+++ trunk/LayoutTests/ChangeLog 2014-02-15 00:59:56 UTC (rev 164145)
@@ -1,3 +1,20 @@
+2014-02-14 Dan Bernstein <m...@apple.com>
+
+ REGRESSION (r157443): Search fields with a non-white background don’t have a round bezel
+ https://bugs.webkit.org/show_bug.cgi?id=126295
+
+ Reviewed by Ryosuke Niwa.
+
+ Reverted r157443.
+
+ * fast/forms/search/search-field-background-color-expected.txt: Removed.
+ * fast/forms/search/search-field-background-color.html: Removed.
+ * platform/efl/fast/forms/search: Removed.
+ * platform/efl/fast/forms/search/search-field-background-color-expected.png: Removed.
+ * platform/efl/fast/forms/search/search-size-with-decorations-expected.png: Removed.
+ * platform/efl/fast/forms/search/search-size-with-decorations-expected.txt: Removed.
+ * platform/mac/fast/forms/search-styled-expected.txt:
+
2014-02-14 Brent Fulgham <bfulg...@apple.com>
[Win] Activate CSS Region Tests on Windows
Deleted: trunk/LayoutTests/fast/forms/search/search-field-background-color-expected.txt (164144 => 164145)
--- trunk/LayoutTests/fast/forms/search/search-field-background-color-expected.txt 2014-02-15 00:54:36 UTC (rev 164144)
+++ trunk/LayoutTests/fast/forms/search/search-field-background-color-expected.txt 2014-02-15 00:59:56 UTC (rev 164145)
@@ -1,4 +0,0 @@
-PASS getComputedStyle(test, null).getPropertyValue('background-color') is color
-The following search field should have red background.
-
-
Deleted: trunk/LayoutTests/fast/forms/search/search-field-background-color.html (164144 => 164145)
--- trunk/LayoutTests/fast/forms/search/search-field-background-color.html 2014-02-15 00:54:36 UTC (rev 164144)
+++ trunk/LayoutTests/fast/forms/search/search-field-background-color.html 2014-02-15 00:59:56 UTC (rev 164145)
@@ -1,24 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<script src=""
-<style>
- input { background: red; }
-</style>
-</head>
-
-<body>
-<p>The following search field should have red background.</p>
-<input type="search" id="test">
-
-<script>
-if (window.testRunner)
- testRunner.dumpAsText(true);
-
- var test = document.getElementById("test");
- var color = 'rgb(255, 0, 0)';
- shouldBe("getComputedStyle(test, null).getPropertyValue('background-color')", "color");
-</script>
-
-</body>
-</html>
Modified: trunk/LayoutTests/platform/mac/fast/forms/search-styled-expected.txt (164144 => 164145)
--- trunk/LayoutTests/platform/mac/fast/forms/search-styled-expected.txt 2014-02-15 00:54:36 UTC (rev 164144)
+++ trunk/LayoutTests/platform/mac/fast/forms/search-styled-expected.txt 2014-02-15 00:59:56 UTC (rev 164145)
@@ -1,17 +1,17 @@
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
-layer at (0,0) size 800x41
- RenderBlock {HTML} at (0,0) size 800x41
- RenderBody {BODY} at (8,8) size 784x25
- RenderTextControl {INPUT} at (2,2) size 220x21 [bgcolor=#FFFFFF] [border: (1px solid #BDC7D8)]
- RenderFlexibleBox {DIV} at (18,4) size 198x13
+layer at (0,0) size 800x39
+ RenderBlock {HTML} at (0,0) size 800x39
+ RenderBody {BODY} at (8,8) size 784x23
+ RenderTextControl {INPUT} at (2,2) size 158x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)]
+ RenderFlexibleBox {DIV} at (3,3) size 152x13
RenderBlock {DIV} at (0,1) size 22x11
- RenderBlock {DIV} at (22,0) size 163x13
- RenderBlock {DIV} at (185,1) size 13x11
+ RenderBlock {DIV} at (22,0) size 117x13
+ RenderBlock {DIV} at (139,1) size 13x11
RenderText {#text} at (0,0) size 0x0
-layer at (50,14) size 163x13
- RenderBlock {DIV} at (40,4) size 163x13 [color=#A9A9A9]
+layer at (35,13) size 117x13
+ RenderBlock {DIV} at (25,3) size 117x13 [color=#A9A9A9]
RenderText {#text} at (0,0) size 92x13
text run at (0,0) width 92: "Search for Events"
-layer at (50,14) size 163x13
- RenderBlock {DIV} at (0,0) size 163x13
+layer at (35,13) size 117x13
+ RenderBlock {DIV} at (0,0) size 117x13
Modified: trunk/Source/WebCore/ChangeLog (164144 => 164145)
--- trunk/Source/WebCore/ChangeLog 2014-02-15 00:54:36 UTC (rev 164144)
+++ trunk/Source/WebCore/ChangeLog 2014-02-15 00:59:56 UTC (rev 164145)
@@ -1,3 +1,15 @@
+2014-02-14 Dan Bernstein <m...@apple.com>
+
+ REGRESSION (r157443): Search fields with a non-white background don’t have a round bezel
+ https://bugs.webkit.org/show_bug.cgi?id=126295
+
+ Reviewed by Ryosuke Niwa.
+
+ Reverted r157443 and improved comment.
+
+ * rendering/RenderTheme.cpp:
+ (WebCore::RenderTheme::isControlStyled):
+
2014-02-14 Brian Burg <bb...@apple.com>
Web Replay: AtomicString replay input names should be stored in a thread-local table
Modified: trunk/Source/WebCore/rendering/RenderTheme.cpp (164144 => 164145)
--- trunk/Source/WebCore/rendering/RenderTheme.cpp 2014-02-15 00:54:36 UTC (rev 164144)
+++ trunk/Source/WebCore/rendering/RenderTheme.cpp 2014-02-15 00:59:56 UTC (rev 164145)
@@ -684,7 +684,7 @@
case ContinuousCapacityLevelIndicatorPart:
case DiscreteCapacityLevelIndicatorPart:
case RatingLevelIndicatorPart:
- case SearchFieldPart:
+ // FIXME: SearchFieldPart should be included here when making search fields style-able.
case TextFieldPart:
case TextAreaPart:
// Test the style to see if the UA border and background match.
