Title: [164320] trunk/Source/WebCore
- Revision
- 164320
- Author
- rn...@webkit.org
- Date
- 2014-02-18 14:37:58 -0800 (Tue, 18 Feb 2014)
Log Message
Merge notifyComponentsOnChangedSelection into respondToSelectionChange
https://bugs.webkit.org/show_bug.cgi?id=128993
Reviewed by Andreas Kling.
Merged notifyComponentsOnChangedSelection into respondToSelectionChange since notifyComponentsOnChangedSelection
was only added in iOS codebase in response to the code added for continuous spellchecking and alternative text controller
in respondToChangedSelection but they should have been called inside setIgnoreCompositionSelectionChange.
So merge these two functions and make respondToChangedSelection behave like setIgnoreCompositionSelectionChange.
* editing/Editor.cpp:
(WebCore::Editor::setIgnoreCompositionSelectionChange):
(WebCore::Editor::respondToChangedSelection):
* editing/Editor.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (164319 => 164320)
--- trunk/Source/WebCore/ChangeLog 2014-02-18 22:35:14 UTC (rev 164319)
+++ trunk/Source/WebCore/ChangeLog 2014-02-18 22:37:58 UTC (rev 164320)
@@ -1,3 +1,21 @@
+2014-02-18 Ryosuke Niwa <rn...@webkit.org>
+
+ Merge notifyComponentsOnChangedSelection into respondToSelectionChange
+ https://bugs.webkit.org/show_bug.cgi?id=128993
+
+ Reviewed by Andreas Kling.
+
+ Merged notifyComponentsOnChangedSelection into respondToSelectionChange since notifyComponentsOnChangedSelection
+ was only added in iOS codebase in response to the code added for continuous spellchecking and alternative text controller
+ in respondToChangedSelection but they should have been called inside setIgnoreCompositionSelectionChange.
+
+ So merge these two functions and make respondToChangedSelection behave like setIgnoreCompositionSelectionChange.
+
+ * editing/Editor.cpp:
+ (WebCore::Editor::setIgnoreCompositionSelectionChange):
+ (WebCore::Editor::respondToChangedSelection):
+ * editing/Editor.h:
+
2014-02-18 Ryosuke Niwa <rn...@webkit.org>
FrameSelection::textWasReplaced and setSelectedRange shouldn't trigger synchronous layout
Modified: trunk/Source/WebCore/editing/Editor.cpp (164319 => 164320)
--- trunk/Source/WebCore/editing/Editor.cpp 2014-02-18 22:35:14 UTC (rev 164319)
+++ trunk/Source/WebCore/editing/Editor.cpp 2014-02-18 22:37:58 UTC (rev 164320)
@@ -756,7 +756,7 @@
void Editor::notifyComponentsOnChangedSelection(const VisibleSelection& oldSelection, FrameSelection::SetSelectionOptions options)
{
#if PLATFORM(IOS)
- // FIXME: Merge this to open source https://bugs.webkit.org/show_bug.cgi?id=38830
+ // FIXME: Should suppress selection change notifications during a composition change <https://webkit.org/b/38830>
if (m_ignoreCompositionSelectionChange)
return;
#endif
@@ -2949,7 +2949,7 @@
// does not call EditorClient::respondToChangedSelection(), which, on the Mac, sends selection change notifications and
// starts a new kill ring sequence, but we want to do these things (matches AppKit).
#if PLATFORM(IOS)
- // FIXME: Merge this to open source https://bugs.webkit.org/show_bug.cgi?id=38830
+ // FIXME: Should suppress selection change notifications during a composition change <https://webkit.org/b/38830>
if (m_ignoreCompositionSelectionChange)
return;
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
