Title: [164747] trunk/Source/_javascript_Core
Revision
164747
Author
oli...@apple.com
Date
2014-02-26 13:49:57 -0800 (Wed, 26 Feb 2014)

Log Message

Remove unused access types
https://bugs.webkit.org/show_bug.cgi?id=129385

Reviewed by Filip Pizlo.

Remove unused cruft.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::printGetByIdCacheStatus):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
* bytecode/StructureStubInfo.h:
(JSC::isGetByIdAccess):
(JSC::isPutByIdAccess):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (164746 => 164747)


--- trunk/Source/_javascript_Core/ChangeLog	2014-02-26 21:44:36 UTC (rev 164746)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-02-26 21:49:57 UTC (rev 164747)
@@ -1,5 +1,22 @@
 2014-02-26  Oliver Hunt  <oli...@apple.com>
 
+        Remove unused access types
+        https://bugs.webkit.org/show_bug.cgi?id=129385
+
+        Reviewed by Filip Pizlo.
+
+        Remove unused cruft.
+
+        * bytecode/CodeBlock.cpp:
+        (JSC::CodeBlock::printGetByIdCacheStatus):
+        * bytecode/StructureStubInfo.cpp:
+        (JSC::StructureStubInfo::deref):
+        * bytecode/StructureStubInfo.h:
+        (JSC::isGetByIdAccess):
+        (JSC::isPutByIdAccess):
+
+2014-02-26  Oliver Hunt  <oli...@apple.com>
+
         Function.prototype.apply has a bad time with the spread operator
         https://bugs.webkit.org/show_bug.cgi?id=129381
 

Modified: trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp (164746 => 164747)


--- trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2014-02-26 21:44:36 UTC (rev 164746)
+++ trunk/Source/_javascript_Core/bytecode/CodeBlock.cpp	2014-02-26 21:49:57 UTC (rev 164747)
@@ -362,15 +362,6 @@
             case access_unset:
                 out.printf("unset");
                 break;
-            case access_get_by_id_generic:
-                out.printf("generic");
-                break;
-            case access_get_array_length:
-                out.printf("array_length");
-                break;
-            case access_get_string_length:
-                out.printf("string_length");
-                break;
             default:
                 RELEASE_ASSERT_NOT_REACHED();
                 break;

Modified: trunk/Source/_javascript_Core/bytecode/StructureStubInfo.cpp (164746 => 164747)


--- trunk/Source/_javascript_Core/bytecode/StructureStubInfo.cpp	2014-02-26 21:44:36 UTC (rev 164746)
+++ trunk/Source/_javascript_Core/bytecode/StructureStubInfo.cpp	2014-02-26 21:49:57 UTC (rev 164747)
@@ -55,10 +55,6 @@
     case access_put_by_id_transition_direct:
     case access_put_by_id_replace:
     case access_unset:
-    case access_get_by_id_generic:
-    case access_put_by_id_generic:
-    case access_get_array_length:
-    case access_get_string_length:
         // These instructions don't have to release any allocated memory
         return;
     default:

Modified: trunk/Source/_javascript_Core/bytecode/StructureStubInfo.h (164746 => 164747)


--- trunk/Source/_javascript_Core/bytecode/StructureStubInfo.h	2014-02-26 21:44:36 UTC (rev 164746)
+++ trunk/Source/_javascript_Core/bytecode/StructureStubInfo.h	2014-02-26 21:49:57 UTC (rev 164747)
@@ -52,10 +52,6 @@
     access_put_by_id_replace,
     access_put_by_id_list,
     access_unset,
-    access_get_by_id_generic,
-    access_put_by_id_generic,
-    access_get_array_length,
-    access_get_string_length,
     access_in_list
 };
 
@@ -65,9 +61,6 @@
     case access_get_by_id_self:
     case access_get_by_id_chain:
     case access_get_by_id_self_list:
-    case access_get_by_id_generic:
-    case access_get_array_length:
-    case access_get_string_length:
         return true;
     default:
         return false;
@@ -81,7 +74,6 @@
     case access_put_by_id_transition_direct:
     case access_put_by_id_replace:
     case access_put_by_id_list:
-    case access_put_by_id_generic:
         return true;
     default:
         return false;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to