Title: [165112] trunk/Source/_javascript_Core
- Revision
- 165112
- Author
- mhahnenb...@apple.com
- Date
- 2014-03-05 09:43:57 -0800 (Wed, 05 Mar 2014)
Log Message
DFGStoreBarrierElisionPhase should should GCState directly instead of m_gcClobberSet when calling writesOverlap()
https://bugs.webkit.org/show_bug.cgi?id=129717
Reviewed by Filip Pizlo.
* dfg/DFGStoreBarrierElisionPhase.cpp:
(JSC::DFG::StoreBarrierElisionPhase::StoreBarrierElisionPhase):
(JSC::DFG::StoreBarrierElisionPhase::couldCauseGC):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (165111 => 165112)
--- trunk/Source/_javascript_Core/ChangeLog 2014-03-05 16:52:29 UTC (rev 165111)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-03-05 17:43:57 UTC (rev 165112)
@@ -1,5 +1,16 @@
2014-03-05 Mark Hahnenberg <mhahnenb...@apple.com>
+ DFGStoreBarrierElisionPhase should should GCState directly instead of m_gcClobberSet when calling writesOverlap()
+ https://bugs.webkit.org/show_bug.cgi?id=129717
+
+ Reviewed by Filip Pizlo.
+
+ * dfg/DFGStoreBarrierElisionPhase.cpp:
+ (JSC::DFG::StoreBarrierElisionPhase::StoreBarrierElisionPhase):
+ (JSC::DFG::StoreBarrierElisionPhase::couldCauseGC):
+
+2014-03-05 Mark Hahnenberg <mhahnenb...@apple.com>
+
Use range-based loops where possible in Heap methods
https://bugs.webkit.org/show_bug.cgi?id=129513
Modified: trunk/Source/_javascript_Core/dfg/DFGStoreBarrierElisionPhase.cpp (165111 => 165112)
--- trunk/Source/_javascript_Core/dfg/DFGStoreBarrierElisionPhase.cpp 2014-03-05 16:52:29 UTC (rev 165111)
+++ trunk/Source/_javascript_Core/dfg/DFGStoreBarrierElisionPhase.cpp 2014-03-05 17:43:57 UTC (rev 165112)
@@ -29,7 +29,7 @@
#if ENABLE(DFG_JIT)
#include "DFGBasicBlock.h"
-#include "DFGClobberSet.h"
+#include "DFGClobberize.h"
#include "DFGGraph.h"
#include "DFGPhase.h"
#include "JSCInlines.h"
@@ -44,7 +44,6 @@
, m_currentBlock(0)
, m_currentIndex(0)
{
- m_gcClobberSet.add(GCState);
}
bool run()
@@ -61,7 +60,7 @@
private:
bool couldCauseGC(Node* node)
{
- return writesOverlap(m_graph, node, m_gcClobberSet);
+ return writesOverlap(m_graph, node, GCState);
}
bool allocatesFreshObject(Node* node)
@@ -139,7 +138,6 @@
return true;
}
- ClobberSet m_gcClobberSet;
BasicBlock* m_currentBlock;
unsigned m_currentIndex;
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
