Title: [165622] trunk/Source/WebKit2
- Revision
- 165622
- Author
- ander...@apple.com
- Date
- 2014-03-14 09:08:25 -0700 (Fri, 14 Mar 2014)
Log Message
Remove WebContext::addVisitedLink
https://bugs.webkit.org/show_bug.cgi?id=130242
Reviewed by Dan Bernstein.
Fold the function into WKContextAddVisitedLink instead.
* UIProcess/API/C/WKContext.cpp:
(WKContextAddVisitedLink):
* UIProcess/WebContext.cpp:
* UIProcess/WebContext.h:
(WebKit::WebContext::visitedLinkProvider):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (165621 => 165622)
--- trunk/Source/WebKit2/ChangeLog 2014-03-14 16:06:32 UTC (rev 165621)
+++ trunk/Source/WebKit2/ChangeLog 2014-03-14 16:08:25 UTC (rev 165622)
@@ -1,3 +1,18 @@
+2014-03-14 Anders Carlsson <ander...@apple.com>
+
+ Remove WebContext::addVisitedLink
+ https://bugs.webkit.org/show_bug.cgi?id=130242
+
+ Reviewed by Dan Bernstein.
+
+ Fold the function into WKContextAddVisitedLink instead.
+
+ * UIProcess/API/C/WKContext.cpp:
+ (WKContextAddVisitedLink):
+ * UIProcess/WebContext.cpp:
+ * UIProcess/WebContext.h:
+ (WebKit::WebContext::visitedLinkProvider):
+
2014-03-13 Anders Carlsson <ander...@apple.com>
Move visited link handling to VisitedLinkTableController and VisitedLinkProvider
Modified: trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp (165621 => 165622)
--- trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2014-03-14 16:06:32 UTC (rev 165621)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKContext.cpp 2014-03-14 16:08:25 UTC (rev 165622)
@@ -61,6 +61,7 @@
};
}
+using namespace WebCore;
using namespace WebKit;
typedef GenericAPICallback<WKDictionaryRef> DictionaryAPICallback;
@@ -188,7 +189,11 @@
void WKContextAddVisitedLink(WKContextRef contextRef, WKStringRef visitedURL)
{
- toImpl(contextRef)->addVisitedLink(toImpl(visitedURL)->string());
+ String visitedURLString = toImpl(visitedURL)->string();
+ if (visitedURLString.isEmpty())
+ return;
+
+ toImpl(contextRef)->visitedLinkProvider().addVisitedLinkHash(visitedLinkHash(visitedURLString));
}
void WKContextSetCacheModel(WKContextRef contextRef, WKCacheModel cacheModel)
Modified: trunk/Source/WebKit2/UIProcess/WebContext.cpp (165621 => 165622)
--- trunk/Source/WebKit2/UIProcess/WebContext.cpp 2014-03-14 16:06:32 UTC (rev 165621)
+++ trunk/Source/WebKit2/UIProcess/WebContext.cpp 2014-03-14 16:08:25 UTC (rev 165622)
@@ -968,14 +968,6 @@
sendToAllProcesses(Messages::WebProcess::SetDefaultRequestTimeoutInterval(timeoutInterval));
}
-void WebContext::addVisitedLink(const String& visitedURL)
-{
- if (visitedURL.isEmpty())
- return;
-
- m_visitedLinkProvider->addVisitedLinkHash(visitedLinkHash(visitedURL));
-}
-
DownloadProxy* WebContext::createDownloadProxy()
{
#if ENABLE(NETWORK_PROCESS)
Modified: trunk/Source/WebKit2/UIProcess/WebContext.h (165621 => 165622)
--- trunk/Source/WebKit2/UIProcess/WebContext.h 2014-03-14 16:06:32 UTC (rev 165621)
+++ trunk/Source/WebKit2/UIProcess/WebContext.h 2014-03-14 16:08:25 UTC (rev 165622)
@@ -197,7 +197,7 @@
void registerURLSchemeAsCachePartitioned(const String&);
#endif
- void addVisitedLink(const String&);
+ VisitedLinkProvider& visitedLinkProvider() { return *m_visitedLinkProvider; }
// MessageReceiver.
virtual void didReceiveMessage(IPC::Connection*, IPC::MessageDecoder&) override;
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
