Title: [166993] trunk/Source
Revision
166993
Author
jon...@apple.com
Date
2014-04-08 19:18:52 -0700 (Tue, 08 Apr 2014)

Log Message

Turn MSE on by default
https://bugs.webkit.org/show_bug.cgi?id=131313
<rdar://problem/16525223>

Reviewed by Jer Noble.

Source/_javascript_Core:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
* page/Settings.in: Add MEDIA_SOURCE conditional.

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Set default to true.

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:
* Shared/WebPreferencesStore.h: Set default to true.
* UIProcess/API/C/WKPreferencesRefPrivate.h:

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (166992 => 166993)


--- trunk/Source/_javascript_Core/ChangeLog	2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-04-09 02:18:52 UTC (rev 166993)
@@ -1,3 +1,13 @@
+2014-04-08  Jon Lee  <jon...@apple.com>
+
+        Turn MSE on by default
+        https://bugs.webkit.org/show_bug.cgi?id=131313
+        <rdar://problem/16525223>
+
+        Reviewed by Jer Noble.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2014-04-08  Joseph Pecoraro  <pecor...@apple.com>
 
         Web Inspector: Prevent deadlocks receiving WIRPermissionDenied message

Modified: trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig (166992 => 166993)


--- trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/_javascript_Core/Configurations/FeatureDefines.xcconfig	2014-04-09 02:18:52 UTC (rev 166993)
@@ -142,7 +142,10 @@
 ENABLE_LINK_PREFETCH = ;
 ENABLE_MATHML = ENABLE_MATHML;
 ENABLE_MEDIA_CONTROLS_SCRIPT = ENABLE_MEDIA_CONTROLS_SCRIPT;
-ENABLE_MEDIA_SOURCE = ENABLE_MEDIA_SOURCE;
+
+ENABLE_MEDIA_SOURCE = $(ENABLE_MEDIA_SOURCE_$(PLATFORM_NAME));
+ENABLE_MEDIA_SOURCE_macosx = ENABLE_MEDIA_SOURCE;
+
 ENABLE_MEDIA_STATISTICS = ;
 ENABLE_METER_ELEMENT = $(ENABLE_METER_ELEMENT_$(PLATFORM_NAME));
 ENABLE_METER_ELEMENT_macosx = ENABLE_METER_ELEMENT;

Modified: trunk/Source/WebCore/ChangeLog (166992 => 166993)


--- trunk/Source/WebCore/ChangeLog	2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/WebCore/ChangeLog	2014-04-09 02:18:52 UTC (rev 166993)
@@ -1,3 +1,14 @@
+2014-04-08  Jon Lee  <jon...@apple.com>
+
+        Turn MSE on by default
+        https://bugs.webkit.org/show_bug.cgi?id=131313
+        <rdar://problem/16525223>
+
+        Reviewed by Jer Noble.
+
+        * Configurations/FeatureDefines.xcconfig:
+        * page/Settings.in: Add MEDIA_SOURCE conditional.
+
 2014-04-08  Anders Carlsson  <ander...@apple.com>
 
         Remove an unused parameter from loadResource.

Modified: trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig (166992 => 166993)


--- trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/WebCore/Configurations/FeatureDefines.xcconfig	2014-04-09 02:18:52 UTC (rev 166993)
@@ -142,7 +142,10 @@
 ENABLE_LINK_PREFETCH = ;
 ENABLE_MATHML = ENABLE_MATHML;
 ENABLE_MEDIA_CONTROLS_SCRIPT = ENABLE_MEDIA_CONTROLS_SCRIPT;
-ENABLE_MEDIA_SOURCE = ENABLE_MEDIA_SOURCE;
+
+ENABLE_MEDIA_SOURCE = $(ENABLE_MEDIA_SOURCE_$(PLATFORM_NAME));
+ENABLE_MEDIA_SOURCE_macosx = ENABLE_MEDIA_SOURCE;
+
 ENABLE_MEDIA_STATISTICS = ;
 ENABLE_METER_ELEMENT = $(ENABLE_METER_ELEMENT_$(PLATFORM_NAME));
 ENABLE_METER_ELEMENT_macosx = ENABLE_METER_ELEMENT;

Modified: trunk/Source/WebCore/page/Settings.in (166992 => 166993)


--- trunk/Source/WebCore/page/Settings.in	2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/WebCore/page/Settings.in	2014-04-09 02:18:52 UTC (rev 166993)
@@ -197,7 +197,7 @@
 simpleLineLayoutEnabled initial=true, setNeedsStyleRecalcInAllFrames=1
 simpleLineLayoutDebugBordersEnabled initial=false, setNeedsStyleRecalcInAllFrames=1
 
-mediaSourceEnabled initial=false
+mediaSourceEnabled initial=true, conditional=MEDIA_SOURCE
 
 # FIXME: Rename to allowMultiElementImplicitFormSubmission once we upstream the iOS changes to WebView.mm.
 allowMultiElementImplicitSubmission initial=false

Modified: trunk/Source/WebKit/mac/ChangeLog (166992 => 166993)


--- trunk/Source/WebKit/mac/ChangeLog	2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/WebKit/mac/ChangeLog	2014-04-09 02:18:52 UTC (rev 166993)
@@ -1,3 +1,15 @@
+2014-04-08  Jon Lee  <jon...@apple.com>
+
+        Turn MSE on by default
+        https://bugs.webkit.org/show_bug.cgi?id=131313
+        <rdar://problem/16525223>
+
+        Reviewed by Jer Noble.
+
+        * Configurations/FeatureDefines.xcconfig:
+        * WebView/WebPreferences.mm:
+        (+[WebPreferences initialize]): Set default to true.
+
 2014-04-08  Alexey Proskuryakov  <a...@apple.com>
 
         Rename Clipboard to DataTransfer

Modified: trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig (166992 => 166993)


--- trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig	2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/WebKit/mac/Configurations/FeatureDefines.xcconfig	2014-04-09 02:18:52 UTC (rev 166993)
@@ -142,7 +142,10 @@
 ENABLE_LINK_PREFETCH = ;
 ENABLE_MATHML = ENABLE_MATHML;
 ENABLE_MEDIA_CONTROLS_SCRIPT = ENABLE_MEDIA_CONTROLS_SCRIPT;
-ENABLE_MEDIA_SOURCE = ENABLE_MEDIA_SOURCE;
+
+ENABLE_MEDIA_SOURCE = $(ENABLE_MEDIA_SOURCE_$(PLATFORM_NAME));
+ENABLE_MEDIA_SOURCE_macosx = ENABLE_MEDIA_SOURCE;
+
 ENABLE_MEDIA_STATISTICS = ;
 ENABLE_METER_ELEMENT = $(ENABLE_METER_ELEMENT_$(PLATFORM_NAME));
 ENABLE_METER_ELEMENT_macosx = ENABLE_METER_ELEMENT;

Modified: trunk/Source/WebKit/mac/WebView/WebPreferences.mm (166992 => 166993)


--- trunk/Source/WebKit/mac/WebView/WebPreferences.mm	2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/WebKit/mac/WebView/WebPreferences.mm	2014-04-09 02:18:52 UTC (rev 166993)
@@ -588,7 +588,7 @@
         
         [NSNumber numberWithBool:NO],   WebKitVideoPluginProxyEnabledKey,
 #if ENABLE(MEDIA_SOURCE)
-        [NSNumber numberWithBool:NO], WebKitMediaSourceEnabledPreferenceKey,
+        [NSNumber numberWithBool:YES], WebKitMediaSourceEnabledPreferenceKey,
 #endif
 #if ENABLE(IMAGE_CONTROLS)
         [NSNumber numberWithBool:NO], WebKitImageControlsEnabledPreferenceKey,

Modified: trunk/Source/WebKit2/ChangeLog (166992 => 166993)


--- trunk/Source/WebKit2/ChangeLog	2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/WebKit2/ChangeLog	2014-04-09 02:18:52 UTC (rev 166993)
@@ -1,3 +1,15 @@
+2014-04-08  Jon Lee  <jon...@apple.com>
+
+        Turn MSE on by default
+        https://bugs.webkit.org/show_bug.cgi?id=131313
+        <rdar://problem/16525223>
+
+        Reviewed by Jer Noble.
+
+        * Configurations/FeatureDefines.xcconfig:
+        * Shared/WebPreferencesStore.h: Set default to true.
+        * UIProcess/API/C/WKPreferencesRefPrivate.h:
+
 2014-04-08  Ryosuke Niwa  <rn...@webkit.org>
 
         Fix the typo in the previous commit.

Modified: trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig (166992 => 166993)


--- trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig	2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/WebKit2/Configurations/FeatureDefines.xcconfig	2014-04-09 02:18:52 UTC (rev 166993)
@@ -142,7 +142,10 @@
 ENABLE_LINK_PREFETCH = ;
 ENABLE_MATHML = ENABLE_MATHML;
 ENABLE_MEDIA_CONTROLS_SCRIPT = ENABLE_MEDIA_CONTROLS_SCRIPT;
-ENABLE_MEDIA_SOURCE = ENABLE_MEDIA_SOURCE;
+
+ENABLE_MEDIA_SOURCE = $(ENABLE_MEDIA_SOURCE_$(PLATFORM_NAME));
+ENABLE_MEDIA_SOURCE_macosx = ENABLE_MEDIA_SOURCE;
+
 ENABLE_MEDIA_STATISTICS = ;
 ENABLE_METER_ELEMENT = $(ENABLE_METER_ELEMENT_$(PLATFORM_NAME));
 ENABLE_METER_ELEMENT_macosx = ENABLE_METER_ELEMENT;

Modified: trunk/Source/WebKit2/Shared/WebPreferencesStore.h (166992 => 166993)


--- trunk/Source/WebKit2/Shared/WebPreferencesStore.h	2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/WebKit2/Shared/WebPreferencesStore.h	2014-04-09 02:18:52 UTC (rev 166993)
@@ -214,7 +214,7 @@
     macro(MediaStreamEnabled, mediaStreamEnabled, Bool, bool, false) \
     macro(UseLegacyTextAlignPositionedElementBehavior, useLegacyTextAlignPositionedElementBehavior, Bool, bool, false) \
     macro(SpatialNavigationEnabled, spatialNavigationEnabled, Bool, bool, false) \
-    macro(MediaSourceEnabled, mediaSourceEnabled, Bool, bool, false) \
+    macro(MediaSourceEnabled, mediaSourceEnabled, Bool, bool, true) \
     macro(ViewGestureDebuggingEnabled, viewGestureDebuggingEnabled, Bool, bool, false) \
     macro(ShouldConvertPositionStyleOnCopy, shouldConvertPositionStyleOnCopy, Bool, bool, false) \
     macro(Standalone, standalone, Bool, bool, false) \

Modified: trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h (166992 => 166993)


--- trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h	2014-04-09 01:45:43 UTC (rev 166992)
+++ trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h	2014-04-09 02:18:52 UTC (rev 166993)
@@ -306,7 +306,7 @@
 WK_EXPORT void WKPreferencesSetUseLegacyTextAlignPositionedElementBehavior(WKPreferencesRef preferencesRef, bool enabled);
 WK_EXPORT bool WKPreferencesUseLegacyTextAlignPositionedElementBehavior(WKPreferencesRef preferencesRef);
 
-// Defaults to false.
+// Defaults to true.
 WK_EXPORT void WKPreferencesSetMediaSourceEnabled(WKPreferencesRef preferencesRef, bool enabled);
 WK_EXPORT bool WKPreferencesGetMediaSourceEnabled(WKPreferencesRef preferencesRef);
 
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to