Title: [167364] trunk/Source/_javascript_Core
Revision
167364
Author
mhahnenb...@apple.com
Date
2014-04-16 11:09:56 -0700 (Wed, 16 Apr 2014)

Log Message

[WebKit] Cleanup the build from uninitialized variable in _javascript_Core
https://bugs.webkit.org/show_bug.cgi?id=131728

Reviewed by Darin Adler.

* runtime/JSObject.cpp:
(JSC::JSObject::genericConvertDoubleToContiguous): Add a RELEASE_ASSERT on the
path we expect to never take. Also shut up confused compilers about uninitialized things.

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (167363 => 167364)


--- trunk/Source/_javascript_Core/ChangeLog	2014-04-16 18:06:13 UTC (rev 167363)
+++ trunk/Source/_javascript_Core/ChangeLog	2014-04-16 18:09:56 UTC (rev 167364)
@@ -1,3 +1,14 @@
+2014-04-16  Mark Hahnenberg  <mhahnenb...@apple.com>
+
+        [WebKit] Cleanup the build from uninitialized variable in _javascript_Core
+        https://bugs.webkit.org/show_bug.cgi?id=131728
+
+        Reviewed by Darin Adler.
+
+        * runtime/JSObject.cpp:
+        (JSC::JSObject::genericConvertDoubleToContiguous): Add a RELEASE_ASSERT on the 
+        path we expect to never take. Also shut up confused compilers about uninitialized things.
+
 2014-04-16  Filip Pizlo  <fpi...@apple.com>
 
         Unreviewed, ARMv7 build fix after r167336.

Modified: trunk/Source/_javascript_Core/runtime/JSObject.cpp (167363 => 167364)


--- trunk/Source/_javascript_Core/runtime/JSObject.cpp	2014-04-16 18:06:13 UTC (rev 167363)
+++ trunk/Source/_javascript_Core/runtime/JSObject.cpp	2014-04-16 18:09:56 UTC (rev 167364)
@@ -829,6 +829,10 @@
         case RageConvertDoubleToValue:
             v = jsNumber(value);
             break;
+        default:
+            v = JSValue();
+            RELEASE_ASSERT_NOT_REACHED();
+            break;
         }
         ASSERT(v.isNumber());
         currentAsValue->setWithoutWriteBarrier(v);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to