Title: [167933] trunk
- Revision
- 167933
- Author
- cfleiz...@apple.com
- Date
- 2014-04-29 09:04:57 -0700 (Tue, 29 Apr 2014)
Log Message
AX: SpeechSynthesisUtterance cannot addEventListener
https://bugs.webkit.org/show_bug.cgi?id=132321
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Modified an existing test (speech-synthesis-speak.html) to use addEventTarget.
* Modules/speech/SpeechSynthesisUtterance.idl:
LayoutTests:
* platform/mac/fast/speechsynthesis/speech-synthesis-speak.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (167932 => 167933)
--- trunk/LayoutTests/ChangeLog 2014-04-29 15:17:08 UTC (rev 167932)
+++ trunk/LayoutTests/ChangeLog 2014-04-29 16:04:57 UTC (rev 167933)
@@ -1,3 +1,12 @@
+2014-04-29 Chris Fleizach <cfleiz...@apple.com>
+
+ AX: SpeechSynthesisUtterance cannot addEventListener
+ https://bugs.webkit.org/show_bug.cgi?id=132321
+
+ Reviewed by Mario Sanchez Prada.
+
+ * platform/mac/fast/speechsynthesis/speech-synthesis-speak.html:
+
2014-04-29 Hans Muller <hmul...@adobe.com>
[CSS Shapes] shape-outside polygon fails when first vertex is 0,0
Modified: trunk/LayoutTests/platform/mac/fast/speechsynthesis/speech-synthesis-speak.html (167932 => 167933)
--- trunk/LayoutTests/platform/mac/fast/speechsynthesis/speech-synthesis-speak.html 2014-04-29 15:17:08 UTC (rev 167932)
+++ trunk/LayoutTests/platform/mac/fast/speechsynthesis/speech-synthesis-speak.html 2014-04-29 16:04:57 UTC (rev 167933)
@@ -26,11 +26,12 @@
shouldBeTrue("event.elapsedTime > 0");
shouldBeTrue("speechSynthesis.speaking");
}
- u._onend_ = function(event) {
+
+ u.addEventListener('end', function(e) {
shouldBeTrue("event.elapsedTime > 0");
shouldBeFalse("speechSynthesis.speaking");
finishJSTest();
- }
+ });
shouldBeFalse("speechSynthesis.speaking");
speechSynthesis.speak(u);
Modified: trunk/Source/WebCore/ChangeLog (167932 => 167933)
--- trunk/Source/WebCore/ChangeLog 2014-04-29 15:17:08 UTC (rev 167932)
+++ trunk/Source/WebCore/ChangeLog 2014-04-29 16:04:57 UTC (rev 167933)
@@ -1,3 +1,14 @@
+2014-04-29 Chris Fleizach <cfleiz...@apple.com>
+
+ AX: SpeechSynthesisUtterance cannot addEventListener
+ https://bugs.webkit.org/show_bug.cgi?id=132321
+
+ Reviewed by Mario Sanchez Prada.
+
+ Modified an existing test (speech-synthesis-speak.html) to use addEventTarget.
+
+ * Modules/speech/SpeechSynthesisUtterance.idl:
+
2014-04-29 Hans Muller <hmul...@adobe.com>
[CSS Shapes] shape-outside polygon fails when first vertex is 0,0
Modified: trunk/Source/WebCore/Modules/speech/SpeechSynthesisUtterance.idl (167932 => 167933)
--- trunk/Source/WebCore/Modules/speech/SpeechSynthesisUtterance.idl 2014-04-29 15:17:08 UTC (rev 167932)
+++ trunk/Source/WebCore/Modules/speech/SpeechSynthesisUtterance.idl 2014-04-29 16:04:57 UTC (rev 167933)
@@ -43,4 +43,13 @@
attribute EventListener onresume;
attribute EventListener onmark;
attribute EventListener onboundary;
+
+ // EventTarget interface
+ void addEventListener(DOMString type,
+ EventListener listener,
+ optional boolean useCapture);
+ void removeEventListener(DOMString type,
+ EventListener listener,
+ optional boolean useCapture);
+ [RaisesException] boolean dispatchEvent(Event evt);
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
