Title: [168033] trunk/Source/WebKit2
Revision
168033
Author
za...@apple.com
Date
2014-04-30 12:00:06 -0700 (Wed, 30 Apr 2014)

Log Message

[iOS]Subpixel rendering: Extra line of pixels next to the YouTube loading indicator.
https://bugs.webkit.org/show_bug.cgi?id=132391

Reviewed by Simon Fraser.

CG and GraphicsContext clipping should use the same coordinates. Snapping either one
while leaving the other unsnapped results in clipping mismatch and that may produce
unpainted areas.

Not testable.

* Shared/mac/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::drawInContext):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (168032 => 168033)


--- trunk/Source/WebKit2/ChangeLog	2014-04-30 17:50:04 UTC (rev 168032)
+++ trunk/Source/WebKit2/ChangeLog	2014-04-30 19:00:06 UTC (rev 168033)
@@ -1,3 +1,19 @@
+2014-04-30  Zalan Bujtas  <za...@apple.com>
+
+        [iOS]Subpixel rendering: Extra line of pixels next to the YouTube loading indicator.
+        https://bugs.webkit.org/show_bug.cgi?id=132391
+
+        Reviewed by Simon Fraser.
+
+        CG and GraphicsContext clipping should use the same coordinates. Snapping either one
+        while leaving the other unsnapped results in clipping mismatch and that may produce
+        unpainted areas.
+
+        Not testable.
+
+        * Shared/mac/RemoteLayerBackingStore.mm:
+        (WebKit::RemoteLayerBackingStore::drawInContext):
+
 2014-04-30  Alexey Proskuryakov  <a...@apple.com>
 
         https://bugs.webkit.org/show_bug.cgi?id=132363

Modified: trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm (168032 => 168033)


--- trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm	2014-04-30 17:50:04 UTC (rev 168032)
+++ trunk/Source/WebKit2/Shared/mac/RemoteLayerBackingStore.mm	2014-04-30 19:00:06 UTC (rev 168033)
@@ -264,6 +264,7 @@
         dirtyRects.append(dirtyBounds);
     }
 
+    // FIXME: find a consistent way to scale and snap dirty and CG clip rects.
     for (const auto& rect : dirtyRects) {
         FloatRect scaledRect(rect);
         scaledRect.scale(m_scale, m_scale);
@@ -276,7 +277,7 @@
     for (size_t i = 0, dirtyRectCount = m_paintingRects.size(); i < dirtyRectCount; ++i) {
         FloatRect scaledPaintingRect = m_paintingRects[i];
         scaledPaintingRect.scale(m_scale);
-        cgPaintingRects[i] = enclosingIntRect(scaledPaintingRect);
+        cgPaintingRects[i] = scaledPaintingRect;
     }
 
     if (backImage) {
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to