Title: [168211] trunk/Source/WebCore
Revision
168211
Author
za...@apple.com
Date
2014-05-02 17:02:23 -0700 (Fri, 02 May 2014)

Log Message

Subpixel rendering[iOS]: Use pixelSnappedRoundedRectForPainting() to clip text area rect.
https://bugs.webkit.org/show_bug.cgi?id=132499
<rdar://problem/16631050>

Reviewed by Simon Fraser.

Snap to device pixels properly instead of relying on float arithmetics while converting from RoundedRect
to FloatRoundedRect. This is the second, cleanup part of the text-area decoration is off-by-one painting issue.

Currently not testable.

* rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::paintTextFieldDecorations):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (168210 => 168211)


--- trunk/Source/WebCore/ChangeLog	2014-05-03 00:00:58 UTC (rev 168210)
+++ trunk/Source/WebCore/ChangeLog	2014-05-03 00:02:23 UTC (rev 168211)
@@ -1,3 +1,19 @@
+2014-05-02  Zalan Bujtas  <za...@apple.com>
+
+        Subpixel rendering[iOS]: Use pixelSnappedRoundedRectForPainting() to clip text area rect.
+        https://bugs.webkit.org/show_bug.cgi?id=132499
+        <rdar://problem/16631050>
+
+        Reviewed by Simon Fraser.
+
+        Snap to device pixels properly instead of relying on float arithmetics while converting from RoundedRect
+        to FloatRoundedRect. This is the second, cleanup part of the text-area decoration is off-by-one painting issue.
+
+        Currently not testable.
+
+        * rendering/RenderThemeIOS.mm:
+        (WebCore::RenderThemeIOS::paintTextFieldDecorations):
+
 2014-05-02  Andreas Kling  <akl...@apple.com>
 
         Remove HistogramSupport.

Modified: trunk/Source/WebCore/rendering/RenderThemeIOS.mm (168210 => 168211)


--- trunk/Source/WebCore/rendering/RenderThemeIOS.mm	2014-05-03 00:00:58 UTC (rev 168210)
+++ trunk/Source/WebCore/rendering/RenderThemeIOS.mm	2014-05-03 00:02:23 UTC (rev 168211)
@@ -481,7 +481,7 @@
 
     GraphicsContextStateSaver stateSaver(*paintInfo.context);
 
-    paintInfo.context->clipRoundedRect(FloatRoundedRect(style.getRoundedBorderFor(LayoutRect(rect))));
+    paintInfo.context->clipRoundedRect(style.getRoundedBorderFor(LayoutRect(rect)).pixelSnappedRoundedRectForPainting(box.document().deviceScaleFactor()));
 
     // This gradient gets drawn black when printing.
     // Do not draw the gradient if there is no visible top border.
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to