Title: [168513] trunk/Source
- Revision
- 168513
- Author
- simon.fra...@apple.com
- Date
- 2014-05-08 18:08:30 -0700 (Thu, 08 May 2014)
Log Message
[iOS WK2] Bottom-relative position:fixed elements are misplaced on page load
https://bugs.webkit.org/show_bug.cgi?id=132719
<rdar://problem/16860837>
Reviewed by Benjamin Poulain.
Source/WebCore:
Add a couple of functions, and sort.
* WebCore.exp.in:
Source/WebKit2:
If we haven't received visible rects from the web process, compute the
fixed position rect, but only after scale has been set.
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::viewportConfigurationChanged):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (168512 => 168513)
--- trunk/Source/WebCore/ChangeLog 2014-05-09 01:06:28 UTC (rev 168512)
+++ trunk/Source/WebCore/ChangeLog 2014-05-09 01:08:30 UTC (rev 168513)
@@ -1,3 +1,15 @@
+2014-05-08 Simon Fraser <simon.fra...@apple.com>
+
+ [iOS WK2] Bottom-relative position:fixed elements are misplaced on page load
+ https://bugs.webkit.org/show_bug.cgi?id=132719
+ <rdar://problem/16860837>
+
+ Reviewed by Benjamin Poulain.
+
+ Add a couple of functions, and sort.
+
+ * WebCore.exp.in:
+
2014-05-08 Jer Noble <jer.no...@apple.com>
[Mac, iOS] Add source application accounting to AVURLAsset.
Modified: trunk/Source/WebCore/WebCore.exp.in (168512 => 168513)
--- trunk/Source/WebCore/WebCore.exp.in 2014-05-09 01:06:28 UTC (rev 168512)
+++ trunk/Source/WebCore/WebCore.exp.in 2014-05-09 01:08:30 UTC (rev 168513)
@@ -717,6 +717,7 @@
__ZN7WebCore16createFullMarkupERKNS_4NodeE
__ZN7WebCore16createFullMarkupERKNS_5RangeE
__ZN7WebCore16enclosingIntRectERK6CGRect
+__ZN7WebCore16enclosingIntRectERKNS_10LayoutRectE
__ZN7WebCore16enclosingIntRectERKNS_9FloatRectE
__ZN7WebCore16isEndOfParagraphERKNS_15VisiblePositionENS_27EditingBoundaryCrossingRuleE
__ZN7WebCore16isUserVisibleURLEP8NSString
@@ -2297,9 +2298,9 @@
_wkDrawBezeledTextArea
_wkDrawBezeledTextFieldCell
_wkDrawCapsLockIndicator
+_wkDrawCellFocusRingWithFrameAtTime
_wkDrawFocusRing
_wkDrawFocusRingAtTime
-_wkDrawCellFocusRingWithFrameAtTime
_wkDrawMediaSliderTrack
_wkDrawMediaUIPart
_wkDrawTextFieldCellFocusRing
@@ -2716,6 +2717,7 @@
__ZNK7WebCore9FloatRectcv6CGRectEv
__ZNK7WebCore9FloatSizecv6CGSizeEv
__ZNK7WebCore9FrameView17wasScrolledByUserEv
+__ZNK7WebCore9FrameView30viewportConstrainedObjectsRectEv
__ZNK7WebCore9RenderBox11borderRadiiEv
_webThreadShouldYield
_wkExecutableWasLinkedOnOrAfterIOSVersion
Modified: trunk/Source/WebKit2/ChangeLog (168512 => 168513)
--- trunk/Source/WebKit2/ChangeLog 2014-05-09 01:06:28 UTC (rev 168512)
+++ trunk/Source/WebKit2/ChangeLog 2014-05-09 01:08:30 UTC (rev 168513)
@@ -1,3 +1,17 @@
+2014-05-08 Simon Fraser <simon.fra...@apple.com>
+
+ [iOS WK2] Bottom-relative position:fixed elements are misplaced on page load
+ https://bugs.webkit.org/show_bug.cgi?id=132719
+ <rdar://problem/16860837>
+
+ Reviewed by Benjamin Poulain.
+
+ If we haven't received visible rects from the web process, compute the
+ fixed position rect, but only after scale has been set.
+
+ * WebProcess/WebPage/ios/WebPageIOS.mm:
+ (WebKit::WebPage::viewportConfigurationChanged):
+
2014-05-08 Jer Noble <jer.no...@apple.com>
[Mac, iOS] Add source application accounting to AVURLAsset.
Modified: trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm (168512 => 168513)
--- trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2014-05-09 01:06:28 UTC (rev 168512)
+++ trunk/Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm 2014-05-09 01:08:30 UTC (rev 168513)
@@ -2087,6 +2087,11 @@
m_drawingArea->setExposedContentRect(unobscuredContentRect);
}
scalePage(scale, scrollPosition);
+
+ if (!m_hasReceivedVisibleContentRectsAfterDidCommitLoad) {
+ // This takes scale into account, so do after the scale change.
+ frameView.setCustomFixedPositionLayoutRect(enclosingIntRect(frameView.viewportConstrainedObjectsRect()));
+ }
}
void WebPage::applicationWillResignActive()
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
