Title: [168678] trunk/Source/WebInspectorUI
Revision
168678
Author
stav...@adobe.com
Date
2014-05-13 06:11:25 -0700 (Tue, 13 May 2014)

Log Message

Web Inspector: Restore regionLayoutUpdated event in iOS7 inspector and remove regionOversetChanged
https://bugs.webkit.org/show_bug.cgi?id=132731

Reviewed by Joseph Pecoraro.

Added the regionLayoutUpdated event back into the inspector for compatibility with iOS 7
and removed regionOversetChanged from the iOS7 inspector as iOS 7 does not implement that event.

* UserInterface/Models/ScriptTimelineRecord.js:
* UserInterface/Protocol/CSSObserver.js:
(WebInspector.CSSObserver.prototype.regionLayoutUpdated):
* UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
* Versions/Inspector-iOS-7.0.json:

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (168677 => 168678)


--- trunk/Source/WebInspectorUI/ChangeLog	2014-05-13 10:21:07 UTC (rev 168677)
+++ trunk/Source/WebInspectorUI/ChangeLog	2014-05-13 13:11:25 UTC (rev 168678)
@@ -1,3 +1,19 @@
+2014-05-13  Radu Stavila  <stav...@adobe.com>
+
+        Web Inspector: Restore regionLayoutUpdated event in iOS7 inspector and remove regionOversetChanged
+        https://bugs.webkit.org/show_bug.cgi?id=132731
+
+        Reviewed by Joseph Pecoraro.
+
+        Added the regionLayoutUpdated event back into the inspector for compatibility with iOS 7
+        and removed regionOversetChanged from the iOS7 inspector as iOS 7 does not implement that event.
+
+        * UserInterface/Models/ScriptTimelineRecord.js:
+        * UserInterface/Protocol/CSSObserver.js:
+        (WebInspector.CSSObserver.prototype.regionLayoutUpdated):
+        * UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js:
+        * Versions/Inspector-iOS-7.0.json:
+
 2014-05-12  Brent Fulgham  <bfulg...@apple.com>
 
         [Win] Correct Cygwin Path Confusion in WebInspectorUI Build

Modified: trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js (168677 => 168678)


--- trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js	2014-05-13 10:21:07 UTC (rev 168677)
+++ trunk/Source/WebInspectorUI/UserInterface/Models/ScriptTimelineRecord.js	2014-05-13 13:11:25 UTC (rev 168678)
@@ -190,6 +190,7 @@
         nameMap.set("webkitplaybacktargetavailabilitychanged", "Playback Target Availability Changed");
         nameMap.set("webkitpointerlockchange", "Pointer Lock Change");
         nameMap.set("webkitpointerlockerror", "Pointer Lock Error");
+        nameMap.set("webkitregionlayoutupdate", "Region Layout Update");    // COMPATIBILITY (iOS 7): regionLayoutUpdated was removed and replaced by regionOversetChanged.
         nameMap.set("webkitregionoversetchange", "Region Overset Change");
         nameMap.set("webkitremovesourcebuffer", "Remove Source Buffer");
         nameMap.set("webkitresourcetimingbufferfull", "Resource Timing Buffer Full");

Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/CSSObserver.js (168677 => 168678)


--- trunk/Source/WebInspectorUI/UserInterface/Protocol/CSSObserver.js	2014-05-13 10:21:07 UTC (rev 168677)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/CSSObserver.js	2014-05-13 13:11:25 UTC (rev 168678)
@@ -63,6 +63,12 @@
         WebInspector.domTreeManager.namedFlowRemoved(documentNodeId, flowName);
     },
 
+    // COMPATIBILITY (iOS 7): regionLayoutUpdated was removed and replaced by regionOversetChanged.
+    regionLayoutUpdated: function(namedFlow)
+    {
+        WebInspector.domTreeManager.regionLayoutUpdated(namedFlow);
+    },
+
     regionOversetChanged: function(namedFlow)
     {
         WebInspector.domTreeManager.regionOversetChanged(namedFlow);

Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js (168677 => 168678)


--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js	2014-05-13 10:21:07 UTC (rev 168677)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/7.0/InspectorWebBackendCommands.js	2014-05-13 13:11:25 UTC (rev 168678)
@@ -203,7 +203,7 @@
 InspectorBackend.registerEvent("CSS.styleSheetChanged", ["styleSheetId"]);
 InspectorBackend.registerEvent("CSS.namedFlowCreated", ["namedFlow"]);
 InspectorBackend.registerEvent("CSS.namedFlowRemoved", ["documentNodeId", "flowName"]);
-InspectorBackend.registerEvent("CSS.regionOversetChanged", ["namedFlow"]);
+InspectorBackend.registerEvent("CSS.regionLayoutUpdated", ["namedFlow"]);
 InspectorBackend.registerCommand("CSS.enable", [], []);
 InspectorBackend.registerCommand("CSS.disable", [], []);
 InspectorBackend.registerCommand("CSS.getMatchedStylesForNode", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "includePseudo", "type": "boolean", "optional": true}, {"name": "includeInherited", "type": "boolean", "optional": true}], ["matchedCSSRules", "pseudoElements", "inherited"]);

Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json (168677 => 168678)


--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json	2014-05-13 10:21:07 UTC (rev 168677)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json	2014-05-13 13:11:25 UTC (rev 168678)
@@ -2185,11 +2185,11 @@
                 "description": "Fires when a Named Flow is removed: has no associated content nodes and regions."
             },
             {
-                "name": "regionOversetChanged",
+                "name": "regionLayoutUpdated",
                 "parameters": [
-                    { "name": "namedFlow", "$ref": "NamedFlow", "description": "The Named Flow containing the regions whose regionOverset values changed." }
+                    { "name": "namedFlow", "$ref": "NamedFlow", "description": "The Named Flow whose layout may have changed." }
                 ],
-                "description": "Fires if any of the regionOverset values changed in a Named Flow's region chain."
+                "description": "Fires when a Named Flow's layout may have changed."
             }
         ]
     },
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to