Title: [170914] trunk/Source/WebKit2
Revision
170914
Author
commit-qu...@webkit.org
Date
2014-07-09 00:29:18 -0700 (Wed, 09 Jul 2014)

Log Message

[EFL] Fix crash caused by invalid cursor image.
https://bugs.webkit.org/show_bug.cgi?id=134663

Patch by KwangHyuk Kim <hyuki....@samsung.com> on 2014-07-09
Reviewed by Gyuyoung Kim.

Remove calling of updateCursor since the custom cursor image is invalid once a mouse is out of the webview.

* UIProcess/API/efl/EwkView.cpp:
(EwkViewEventHandler<EVAS_CALLBACK_MOUSE_IN>::handleEvent):

Modified Paths

Property Changed

Diff

Modified: trunk/Source/WebKit2/ChangeLog (170913 => 170914)


--- trunk/Source/WebKit2/ChangeLog	2014-07-09 07:01:48 UTC (rev 170913)
+++ trunk/Source/WebKit2/ChangeLog	2014-07-09 07:29:18 UTC (rev 170914)
@@ -1,3 +1,15 @@
+2014-07-09  KwangHyuk Kim  <hyuki....@samsung.com>
+
+        [EFL] Fix crash caused by invalid cursor image.
+        https://bugs.webkit.org/show_bug.cgi?id=134663
+
+        Reviewed by Gyuyoung Kim.
+
+        Remove calling of updateCursor since the custom cursor image is invalid once a mouse is out of the webview.
+
+        * UIProcess/API/efl/EwkView.cpp:
+        (EwkViewEventHandler<EVAS_CALLBACK_MOUSE_IN>::handleEvent):
+
 2014-07-08  Tim Horton  <timothy_hor...@apple.com>
 
         Remove WebBackForwardListItems when their owning page goes away

Modified: trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp (170913 => 170914)


--- trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp	2014-07-09 07:01:48 UTC (rev 170913)
+++ trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp	2014-07-09 07:29:18 UTC (rev 170914)
@@ -219,10 +219,9 @@
 template <>
 void EwkViewEventHandler<EVAS_CALLBACK_MOUSE_IN>::handleEvent(void* data, Evas*, Evas_Object*, void*)
 {
-    Ewk_View_Smart_Data* smartData = static_cast<Ewk_View_Smart_Data*>(data);
-    EwkView* self = toEwkView(smartData);
-
-    self->updateCursor();
+    // FIXME: self->updateCursor(); was removed in order to fix crash caused by invalid cursor image.
+    // new cursor implementation should be added for curso image restoration previously used for.
+    notImplemented();
 }
 
 template <>
Property changes on: trunk/Source/WebKit2/UIProcess/API/efl/EwkView.cpp
___________________________________________________________________

Added: svn:executable

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to