Title: [170948] trunk/Source/WebKit2
- Revision
- 170948
- Author
- enr...@apple.com
- Date
- 2014-07-09 19:18:30 -0700 (Wed, 09 Jul 2014)
Log Message
REGRESSION(r170858): Safari freezes upon making a search on a website (yelp.com).
https://bugs.webkit.org/show_bug.cgi?id=134791
<rdar://problem/17616971>
Reviewed by Benjamin Poulain.
After r170858 we notify the keyboard too often about
the changed selection. This patch removes the notification
until we find a better way to do it that doesn't cause
deadlocks.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _selectionWillChange]):
(-[WKContentView _selectionChanged]):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (170947 => 170948)
--- trunk/Source/WebKit2/ChangeLog 2014-07-10 01:42:43 UTC (rev 170947)
+++ trunk/Source/WebKit2/ChangeLog 2014-07-10 02:18:30 UTC (rev 170948)
@@ -1,3 +1,20 @@
+2014-07-09 Enrica Casucci <enr...@apple.com>
+
+ REGRESSION(r170858): Safari freezes upon making a search on a website (yelp.com).
+ https://bugs.webkit.org/show_bug.cgi?id=134791
+ <rdar://problem/17616971>
+
+ Reviewed by Benjamin Poulain.
+
+ After r170858 we notify the keyboard too often about
+ the changed selection. This patch removes the notification
+ until we find a better way to do it that doesn't cause
+ deadlocks.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView _selectionWillChange]):
+ (-[WKContentView _selectionChanged]):
+
2014-07-09 Anders Carlsson <ander...@apple.com>
Safari showing blank pages
Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (170947 => 170948)
--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2014-07-10 01:42:43 UTC (rev 170947)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2014-07-10 02:18:30 UTC (rev 170948)
@@ -2506,9 +2506,6 @@
- (void)_selectionWillChange
{
- if (_usingGestureForSelection)
- return;
- [self beginSelectionChange];
}
- (void)_selectionChanged
@@ -2518,8 +2515,6 @@
// to wait to paint the selection.
if (_usingGestureForSelection)
[self _updateChangedSelection];
- else
- [self endSelectionChange];
}
- (void)selectWordForReplacement
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
