Title: [171752] trunk/Source/WebCore
- Revision
- 171752
- Author
- benja...@webkit.org
- Date
- 2014-07-29 12:34:56 -0700 (Tue, 29 Jul 2014)
Log Message
VisitedLinkState::determineLinkState should take a reference
https://bugs.webkit.org/show_bug.cgi?id=135375
Patch by Benjamin Poulain <bpoul...@apple.com> on 2014-07-29
Reviewed by Sam Weinig.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::State::initElement):
* dom/VisitedLinkState.h:
(WebCore::VisitedLinkState::determineLinkState):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (171751 => 171752)
--- trunk/Source/WebCore/ChangeLog 2014-07-29 19:00:30 UTC (rev 171751)
+++ trunk/Source/WebCore/ChangeLog 2014-07-29 19:34:56 UTC (rev 171752)
@@ -1,3 +1,15 @@
+2014-07-29 Benjamin Poulain <bpoul...@apple.com>
+
+ VisitedLinkState::determineLinkState should take a reference
+ https://bugs.webkit.org/show_bug.cgi?id=135375
+
+ Reviewed by Sam Weinig.
+
+ * css/StyleResolver.cpp:
+ (WebCore::StyleResolver::State::initElement):
+ * dom/VisitedLinkState.h:
+ (WebCore::VisitedLinkState::determineLinkState):
+
2014-07-29 Brady Eidson <beid...@apple.com>
Make WKOriginDataManager actually operate on IndexedDatabases.
Modified: trunk/Source/WebCore/css/StyleResolver.cpp (171751 => 171752)
--- trunk/Source/WebCore/css/StyleResolver.cpp 2014-07-29 19:00:30 UTC (rev 171751)
+++ trunk/Source/WebCore/css/StyleResolver.cpp 2014-07-29 19:34:56 UTC (rev 171752)
@@ -389,7 +389,7 @@
{
m_element = e;
m_styledElement = e && e->isStyledElement() ? toStyledElement(e) : nullptr;
- m_elementLinkState = e ? e->document().visitedLinkState().determineLinkState(e) : NotInsideLink;
+ m_elementLinkState = e ? e->document().visitedLinkState().determineLinkState(*e) : NotInsideLink;
updateConversionData();
}
Modified: trunk/Source/WebCore/dom/VisitedLinkState.h (171751 => 171752)
--- trunk/Source/WebCore/dom/VisitedLinkState.h 2014-07-29 19:00:30 UTC (rev 171751)
+++ trunk/Source/WebCore/dom/VisitedLinkState.h 2014-07-29 19:34:56 UTC (rev 171752)
@@ -45,7 +45,7 @@
void invalidateStyleForAllLinks();
void invalidateStyleForLink(LinkHash);
- EInsideLink determineLinkState(Element*);
+ EInsideLink determineLinkState(Element&);
private:
EInsideLink determineLinkStateSlowCase(Element&);
@@ -54,11 +54,11 @@
HashSet<LinkHash, LinkHashHash> m_linksCheckedForVisitedState;
};
-inline EInsideLink VisitedLinkState::determineLinkState(Element* element)
+inline EInsideLink VisitedLinkState::determineLinkState(Element& element)
{
- if (!element || !element->isLink())
+ if (!element.isLink())
return NotInsideLink;
- return determineLinkStateSlowCase(*element);
+ return determineLinkStateSlowCase(element);
}
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
