Title: [171756] trunk/Tools
- Revision
- 171756
- Author
- a...@apple.com
- Date
- 2014-07-29 13:33:53 -0700 (Tue, 29 Jul 2014)
Log Message
PPT: run-webkit-tests doesn't upload crash logs to bots
https://bugs.webkit.org/show_bug.cgi?id=135391
Reviewed by Joseph Pecoraro.
* WebKitTestRunner/TestController.cpp: (WTR::TestController::processDidCrash):
Not a fix to be proud of, but better than not having it work at all.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (171755 => 171756)
--- trunk/Tools/ChangeLog 2014-07-29 20:32:39 UTC (rev 171755)
+++ trunk/Tools/ChangeLog 2014-07-29 20:33:53 UTC (rev 171756)
@@ -1,3 +1,13 @@
+2014-07-29 Alexey Proskuryakov <a...@apple.com>
+
+ PPT: run-webkit-tests doesn't upload crash logs to bots
+ https://bugs.webkit.org/show_bug.cgi?id=135391
+
+ Reviewed by Joseph Pecoraro.
+
+ * WebKitTestRunner/TestController.cpp: (WTR::TestController::processDidCrash):
+ Not a fix to be proud of, but better than not having it work at all.
+
2014-07-29 Adrian Perez de Castro <ape...@igalia.com>
[GTK] Remove WebKitWebViewGroup from WebKit2 GTK+ API
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (171755 => 171756)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2014-07-29 20:32:39 UTC (rev 171755)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2014-07-29 20:33:53 UTC (rev 171756)
@@ -1274,8 +1274,16 @@
if (!m_didPrintWebProcessCrashedMessage) {
#if PLATFORM(COCOA)
pid_t pid = WKPageGetProcessIdentifier(m_mainWebView->page());
- fprintf(stderr, "#CRASHED - WebProcess (pid %ld)\n", static_cast<long>(pid));
+ // FIXME: Find a way to not hardcode the process name.
+#if PLATFORM(IOS)
+ const char* processName = "com.apple.WebKit.WebContent";
+#elif PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED > 1080
+ const char* processName = "com.apple.WebKit.WebContent.Development";
#else
+ const char* processName = "WebProcess";
+#endif
+ fprintf(stderr, "#CRASHED - %s (pid %ld)\n", processName, static_cast<long>(pid));
+#else
fputs("#CRASHED - WebProcess\n", stderr);
#endif
fflush(stderr);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
