Title: [172216] trunk
- Revision
- 172216
- Author
- mhahnenb...@apple.com
- Date
- 2014-08-07 10:29:52 -0700 (Thu, 07 Aug 2014)
Log Message
for-in is failing fast/dom/dataset-xhtml.xhtml and dataset.html tests
https://bugs.webkit.org/show_bug.cgi?id=135681
Reviewed by Filip Pizlo.
Source/_javascript_Core:
* runtime/Structure.cpp:
(JSC::Structure::canCacheGenericPropertyNameEnumerator): We were checking the entire
prototype chain for overridesGetPropertyNames, but we were neglecting to check the
base object's Structure. D'oh!
LayoutTests:
Removed the two failing tests from the TestExpectations list since they pass now!
* TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (172215 => 172216)
--- trunk/LayoutTests/ChangeLog 2014-08-07 17:20:16 UTC (rev 172215)
+++ trunk/LayoutTests/ChangeLog 2014-08-07 17:29:52 UTC (rev 172216)
@@ -1,3 +1,14 @@
+2014-08-07 Mark Hahnenberg <mhahnenb...@apple.com>
+
+ for-in is failing fast/dom/dataset-xhtml.xhtml and dataset.html tests
+ https://bugs.webkit.org/show_bug.cgi?id=135681
+
+ Reviewed by Filip Pizlo.
+
+ Removed the two failing tests from the TestExpectations list since they pass now!
+
+ * TestExpectations:
+
2014-08-06 Brent Fulgham <bfulg...@apple.com>
[Mac, iOS] Captions are appearing multiple times during repeated video play through
Modified: trunk/LayoutTests/TestExpectations (172215 => 172216)
--- trunk/LayoutTests/TestExpectations 2014-08-07 17:20:16 UTC (rev 172215)
+++ trunk/LayoutTests/TestExpectations 2014-08-07 17:29:52 UTC (rev 172216)
@@ -141,7 +141,3 @@
webkit.org/b/135390 fast/css/fontloader-multiple-faces.html [ Skip ]
webkit.org/b/135390 fast/css/fontloader-multiple-families.html [ Skip ]
webkit.org/b/135390 http/tests/webfont/fontloader-loading-attribute.html [ Skip ]
-
-# JSC for in is broken
-webkit.org/b/135681 fast/dom/dataset-xhtml.xhtml [ Failure ]
-webkit.org/b/135681 fast/dom/dataset.html [ Failure ]
\ No newline at end of file
Modified: trunk/Source/_javascript_Core/ChangeLog (172215 => 172216)
--- trunk/Source/_javascript_Core/ChangeLog 2014-08-07 17:20:16 UTC (rev 172215)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-08-07 17:29:52 UTC (rev 172216)
@@ -1,3 +1,15 @@
+2014-08-07 Mark Hahnenberg <mhahnenb...@apple.com>
+
+ for-in is failing fast/dom/dataset-xhtml.xhtml and dataset.html tests
+ https://bugs.webkit.org/show_bug.cgi?id=135681
+
+ Reviewed by Filip Pizlo.
+
+ * runtime/Structure.cpp:
+ (JSC::Structure::canCacheGenericPropertyNameEnumerator): We were checking the entire
+ prototype chain for overridesGetPropertyNames, but we were neglecting to check the
+ base object's Structure. D'oh!
+
2014-08-06 Mark Lam <mark....@apple.com>
Gardening: fix for build failure on EFL bots.
Modified: trunk/Source/_javascript_Core/runtime/Structure.cpp (172215 => 172216)
--- trunk/Source/_javascript_Core/runtime/Structure.cpp 2014-08-07 17:20:16 UTC (rev 172215)
+++ trunk/Source/_javascript_Core/runtime/Structure.cpp 2014-08-07 17:29:52 UTC (rev 172216)
@@ -1291,6 +1291,9 @@
if (hasIndexedProperties(indexingType()))
return false;
+ if (typeInfo().overridesGetPropertyNames())
+ return false;
+
StructureChain* structureChain = m_cachedPrototypeChain.get();
ASSERT(structureChain);
WriteBarrier<Structure>* structure = structureChain->head();
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
