Title: [172693] trunk/Source/WebCore
- Revision
- 172693
- Author
- d...@apple.com
- Date
- 2014-08-16 13:32:53 -0700 (Sat, 16 Aug 2014)
Log Message
REGRESSION (r164173): Safari AutoFill button in popover, default buttons on iCloud control panel and Safari Safe Browsing pages don't have default appearance
https://bugs.webkit.org/show_bug.cgi?id=136011
Reviewed by Sam Weinig.
When we render some controls, we need to make sure the NSWindow subclass we
use as the host of the AppKit views identifies itself as the key window (if
the control state is correct). We already have a flag tracking this for
key appearance - just make sure we do the same for isKeyWindow.
* platform/mac/ThemeMac.mm:
(-[WebCoreThemeWindow isKeyWindow]): New override to mirror the static
variable for key appearance.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (172692 => 172693)
--- trunk/Source/WebCore/ChangeLog 2014-08-16 19:26:07 UTC (rev 172692)
+++ trunk/Source/WebCore/ChangeLog 2014-08-16 20:32:53 UTC (rev 172693)
@@ -1,3 +1,19 @@
+2014-08-15 Dean Jackson <d...@apple.com>
+
+ REGRESSION (r164173): Safari AutoFill button in popover, default buttons on iCloud control panel and Safari Safe Browsing pages don't have default appearance
+ https://bugs.webkit.org/show_bug.cgi?id=136011
+
+ Reviewed by Sam Weinig.
+
+ When we render some controls, we need to make sure the NSWindow subclass we
+ use as the host of the AppKit views identifies itself as the key window (if
+ the control state is correct). We already have a flag tracking this for
+ key appearance - just make sure we do the same for isKeyWindow.
+
+ * platform/mac/ThemeMac.mm:
+ (-[WebCoreThemeWindow isKeyWindow]): New override to mirror the static
+ variable for key appearance.
+
2014-08-15 Zalan Bujtas <za...@apple.com>
Do not use FloatRect::infiniteRect() to flag full repaints.
Modified: trunk/Source/WebCore/platform/mac/ThemeMac.mm (172692 => 172693)
--- trunk/Source/WebCore/platform/mac/ThemeMac.mm 2014-08-16 19:26:07 UTC (rev 172692)
+++ trunk/Source/WebCore/platform/mac/ThemeMac.mm 2014-08-16 20:32:53 UTC (rev 172693)
@@ -58,6 +58,11 @@
return themeWindowHasKeyAppearance;
}
+- (BOOL)isKeyWindow
+{
+ return themeWindowHasKeyAppearance;
+}
+
@end
@interface WebCoreThemeView : NSControl
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
