Title: [173869] trunk/Tools
Revision
173869
Author
commit-qu...@webkit.org
Date
2014-09-23 02:26:14 -0700 (Tue, 23 Sep 2014)

Log Message

[GTK] Minibrowser : Add keyboard support for stop page load
https://bugs.webkit.org/show_bug.cgi?id=136857

Patch by Rohit Kumar <kumar.ro...@samsung.com> on 2014-09-23
Reviewed by Philippe Normand.

Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.

* MiniBrowser/gtk/BrowserWindow.c:
(stopPageLoad): Callback to stop page load.
(browser_window_init):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (173868 => 173869)


--- trunk/Tools/ChangeLog	2014-09-23 08:37:10 UTC (rev 173868)
+++ trunk/Tools/ChangeLog	2014-09-23 09:26:14 UTC (rev 173869)
@@ -1,3 +1,16 @@
+2014-09-23  Rohit Kumar  <kumar.ro...@samsung.com>
+
+        [GTK] Minibrowser : Add keyboard support for stop page load
+        https://bugs.webkit.org/show_bug.cgi?id=136857
+
+        Reviewed by Philippe Normand.
+
+        Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.
+
+        * MiniBrowser/gtk/BrowserWindow.c:
+        (stopPageLoad): Callback to stop page load.
+        (browser_window_init):
+
 2014-09-22  Rohit Kumar  <kumar.ro...@samsung.com>
 
         [EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache

Modified: trunk/Tools/MiniBrowser/gtk/BrowserWindow.c (173868 => 173869)


--- trunk/Tools/MiniBrowser/gtk/BrowserWindow.c	2014-09-23 08:37:10 UTC (rev 173868)
+++ trunk/Tools/MiniBrowser/gtk/BrowserWindow.c	2014-09-23 09:26:14 UTC (rev 173869)
@@ -540,6 +540,12 @@
     webkit_web_view_reload_bypass_cache(window->webView);
 }
 
+static void stopPageLoad(BrowserWindow *window, gpointer user_data)
+{
+    if (webkit_web_view_is_loading(window->webView))
+        webkit_web_view_stop_loading(window->webView);
+}
+
 static void browserWindowFinalize(GObject *gObject)
 {
     BrowserWindow *window = BROWSER_WINDOW(gObject);
@@ -625,6 +631,12 @@
     gtk_accel_group_connect(window->accelGroup, GDK_KEY_R, GDK_CONTROL_MASK | GDK_SHIFT_MASK, GTK_ACCEL_VISIBLE,
         g_cclosure_new_swap(G_CALLBACK(reloadPageIgnoringCache), window, NULL));
 
+    /* Stop page load */ 
+    gtk_accel_group_connect(window->accelGroup, GDK_KEY_F6, 0, GTK_ACCEL_VISIBLE,
+        g_cclosure_new_swap(G_CALLBACK(stopPageLoad), window, NULL));
+    gtk_accel_group_connect(window->accelGroup, GDK_KEY_Escape, 0, GTK_ACCEL_VISIBLE,
+        g_cclosure_new_swap(G_CALLBACK(stopPageLoad), window, NULL));
+
     GtkWidget *toolbar = gtk_toolbar_new();
     window->toolbar = toolbar;
     gtk_orientable_set_orientation(GTK_ORIENTABLE(toolbar), GTK_ORIENTATION_HORIZONTAL);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to