Title: [173890] trunk/Source/WebCore
- Revision
- 173890
- Author
- cdu...@apple.com
- Date
- 2014-09-23 14:17:28 -0700 (Tue, 23 Sep 2014)
Log Message
Have NamedNodeMap::element() and DOMStringMap::element() return a reference
https://bugs.webkit.org/show_bug.cgi?id=137040
Reviewed by Ryosuke Niwa.
Have NamedNodeMap::element() and DOMStringMap::element() return a
reference instead of a pointer as they can never return null.
No new tests, no behavior change.
* dom/DatasetDOMStringMap.h:
* dom/NamedNodeMap.h:
(WebCore::NamedNodeMap::element):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (173889 => 173890)
--- trunk/Source/WebCore/ChangeLog 2014-09-23 21:08:36 UTC (rev 173889)
+++ trunk/Source/WebCore/ChangeLog 2014-09-23 21:17:28 UTC (rev 173890)
@@ -1,5 +1,21 @@
2014-09-23 Chris Dumez <cdu...@apple.com>
+ Have NamedNodeMap::element() and DOMStringMap::element() return a reference
+ https://bugs.webkit.org/show_bug.cgi?id=137040
+
+ Reviewed by Ryosuke Niwa.
+
+ Have NamedNodeMap::element() and DOMStringMap::element() return a
+ reference instead of a pointer as they can never return null.
+
+ No new tests, no behavior change.
+
+ * dom/DatasetDOMStringMap.h:
+ * dom/NamedNodeMap.h:
+ (WebCore::NamedNodeMap::element):
+
+2014-09-23 Chris Dumez <cdu...@apple.com>
+
Have DOMImplementation::document() and Element::attributes() return references
https://bugs.webkit.org/show_bug.cgi?id=137035
Modified: trunk/Source/WebCore/dom/DatasetDOMStringMap.h (173889 => 173890)
--- trunk/Source/WebCore/dom/DatasetDOMStringMap.h 2014-09-23 21:08:36 UTC (rev 173889)
+++ trunk/Source/WebCore/dom/DatasetDOMStringMap.h 2014-09-23 21:17:28 UTC (rev 173890)
@@ -52,7 +52,7 @@
void setItem(const String& name, const String& value, ExceptionCode&);
bool deleteItem(const String& name);
- Element* element() { return &m_element; }
+ Element& element() { return m_element; }
private:
Element& m_element;
Modified: trunk/Source/WebCore/dom/NamedNodeMap.h (173889 => 173890)
--- trunk/Source/WebCore/dom/NamedNodeMap.h 2014-09-23 21:08:36 UTC (rev 173889)
+++ trunk/Source/WebCore/dom/NamedNodeMap.h 2014-09-23 21:17:28 UTC (rev 173890)
@@ -63,8 +63,7 @@
PassRefPtr<Node> item(unsigned index) const;
unsigned length() const;
- // FIXME: It's lame that the bindings generator chokes if we return Element& here.
- Element* element() const { return &m_element; }
+ Element& element() const { return m_element; }
private:
explicit NamedNodeMap(Element& element)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
