Title: [173892] trunk/Source/_javascript_Core
- Revision
- 173892
- Author
- mark....@apple.com
- Date
- 2014-09-23 14:24:01 -0700 (Tue, 23 Sep 2014)
Log Message
Renamed DebuggerCallFrameScope to DebuggerPausedScope.
<https://webkit.org/b/137042>
Reviewed by Michael Saboff.
DebuggerPausedScope is a better name for this data structure because it
is meant for tracking the period within which the debugger is paused,
and doing clean ups after the pause ends.
* debugger/Debugger.cpp:
(JSC::DebuggerPausedScope::DebuggerPausedScope):
(JSC::DebuggerPausedScope::~DebuggerPausedScope):
(JSC::Debugger::pauseIfNeeded):
(JSC::DebuggerCallFrameScope::DebuggerCallFrameScope): Deleted.
(JSC::DebuggerCallFrameScope::~DebuggerCallFrameScope): Deleted.
* debugger/Debugger.h:
* debugger/DebuggerCallFrame.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (173891 => 173892)
--- trunk/Source/_javascript_Core/ChangeLog 2014-09-23 21:21:17 UTC (rev 173891)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-09-23 21:24:01 UTC (rev 173892)
@@ -1,3 +1,23 @@
+2014-09-23 Mark Lam <mark....@apple.com>
+
+ Renamed DebuggerCallFrameScope to DebuggerPausedScope.
+ <https://webkit.org/b/137042>
+
+ Reviewed by Michael Saboff.
+
+ DebuggerPausedScope is a better name for this data structure because it
+ is meant for tracking the period within which the debugger is paused,
+ and doing clean ups after the pause ends.
+
+ * debugger/Debugger.cpp:
+ (JSC::DebuggerPausedScope::DebuggerPausedScope):
+ (JSC::DebuggerPausedScope::~DebuggerPausedScope):
+ (JSC::Debugger::pauseIfNeeded):
+ (JSC::DebuggerCallFrameScope::DebuggerCallFrameScope): Deleted.
+ (JSC::DebuggerCallFrameScope::~DebuggerCallFrameScope): Deleted.
+ * debugger/Debugger.h:
+ * debugger/DebuggerCallFrame.h:
+
2014-09-23 Tomas Popela <tpop...@redhat.com>
[CLoop] - Fix CLoop on the 32-bit Big-Endians
Modified: trunk/Source/_javascript_Core/debugger/Debugger.cpp (173891 => 173892)
--- trunk/Source/_javascript_Core/debugger/Debugger.cpp 2014-09-23 21:21:17 UTC (rev 173891)
+++ trunk/Source/_javascript_Core/debugger/Debugger.cpp 2014-09-23 21:24:01 UTC (rev 173892)
@@ -96,9 +96,9 @@
namespace JSC {
-class DebuggerCallFrameScope {
+class DebuggerPausedScope {
public:
- DebuggerCallFrameScope(Debugger& debugger)
+ DebuggerPausedScope(Debugger& debugger)
: m_debugger(debugger)
{
ASSERT(!m_debugger.m_currentDebuggerCallFrame);
@@ -106,7 +106,7 @@
m_debugger.m_currentDebuggerCallFrame = DebuggerCallFrame::create(debugger.m_currentCallFrame);
}
- ~DebuggerCallFrameScope()
+ ~DebuggerPausedScope()
{
if (m_debugger.m_currentDebuggerCallFrame) {
m_debugger.m_currentDebuggerCallFrame->invalidate();
@@ -644,7 +644,7 @@
bool pauseNow = m_pauseOnNextStatement;
pauseNow |= (m_pauseOnCallFrame == m_currentCallFrame);
- DebuggerCallFrameScope debuggerCallFrameScope(*this);
+ DebuggerPausedScope debuggerPausedScope(*this);
intptr_t sourceID = DebuggerCallFrame::sourceIDForCallFrame(m_currentCallFrame);
TextPosition position = DebuggerCallFrame::positionForCallFrame(m_currentCallFrame);
Modified: trunk/Source/_javascript_Core/debugger/Debugger.h (173891 => 173892)
--- trunk/Source/_javascript_Core/debugger/Debugger.h 2014-09-23 21:21:17 UTC (rev 173891)
+++ trunk/Source/_javascript_Core/debugger/Debugger.h 2014-09-23 21:24:01 UTC (rev 173892)
@@ -207,7 +207,7 @@
RefPtr<JSC::DebuggerCallFrame> m_currentDebuggerCallFrame;
- friend class DebuggerCallFrameScope;
+ friend class DebuggerPausedScope;
friend class TemporaryPausedState;
friend class LLIntOffsetsExtractor;
};
Modified: trunk/Source/_javascript_Core/debugger/DebuggerCallFrame.h (173891 => 173892)
--- trunk/Source/_javascript_Core/debugger/DebuggerCallFrame.h 2014-09-23 21:21:17 UTC (rev 173891)
+++ trunk/Source/_javascript_Core/debugger/DebuggerCallFrame.h 2014-09-23 21:24:01 UTC (rev 173892)
@@ -82,7 +82,7 @@
CallFrame* m_callFrame;
RefPtr<DebuggerCallFrame> m_caller;
TextPosition m_position;
- // The DebuggerCallFrameScope is responsible for calling invalidate() which,
+ // The DebuggerPausedScope is responsible for calling invalidate() which,
// in turn, will clear this strong ref.
Strong<DebuggerScope> m_scope;
};
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
