Title: [174170] trunk/Tools
- Revision
- 174170
- Author
- commit-qu...@webkit.org
- Date
- 2014-10-01 14:08:17 -0700 (Wed, 01 Oct 2014)
Log Message
EWS is inconclusively spinning forever on a patch that breaks 500+
tests
https://bugs.webkit.org/show_bug.cgi?id=137223
Patch by Jake Nielsen <jacob_niel...@apple.com> on 2014-10-01
Reviewed by Tim Horton.
* Scripts/webkitpy/tool/bot/patchanalysistask.py:
Checks to see whether the tests have exceeded the failure limit, and
only spins off another test if they have not exceeded the limit.
(PatchAnalysisTask._test_patch):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (174169 => 174170)
--- trunk/Tools/ChangeLog 2014-10-01 21:02:08 UTC (rev 174169)
+++ trunk/Tools/ChangeLog 2014-10-01 21:08:17 UTC (rev 174170)
@@ -1,3 +1,16 @@
+2014-10-01 Jake Nielsen <jacob_niel...@apple.com>
+
+ EWS is inconclusively spinning forever on a patch that breaks 500+
+ tests
+ https://bugs.webkit.org/show_bug.cgi?id=137223
+
+ Reviewed by Tim Horton.
+
+ * Scripts/webkitpy/tool/bot/patchanalysistask.py:
+ Checks to see whether the tests have exceeded the failure limit, and
+ only spins off another test if they have not exceeded the limit.
+ (PatchAnalysisTask._test_patch):
+
2014-10-01 Brian J. Burg <b...@cs.washington.edu>
Unreviewed, add Katie Madonna as a contributor.
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py (174169 => 174170)
--- trunk/Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py 2014-10-01 21:02:08 UTC (rev 174169)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/patchanalysistask.py 2014-10-01 21:08:17 UTC (rev 174170)
@@ -198,7 +198,10 @@
return True
second_results = self._delegate.test_results()
- if self._results_failed_different_tests(first_results, second_results):
+
+ if (not first_results.did_exceed_test_failure_limit() and
+ not second_results.did_exceed_test_failure_limit() and
+ self._results_failed_different_tests(first_results, second_results)):
# We could report flaky tests here, but we would need to be careful
# to use similar checks to ExpectedFailures._can_trust_results
# to make sure we don't report constant failures as flakes when
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
