Title: [174386] trunk/Source/_javascript_Core
- Revision
- 174386
- Author
- aes...@apple.com
- Date
- 2014-10-06 23:19:57 -0700 (Mon, 06 Oct 2014)
Log Message
Objective-C objects must be fully defined when used in a WTF::Vector
https://bugs.webkit.org/show_bug.cgi?id=137479
Reviewed by Mark Rowe.
When compiling an Objective-C++ file under ARC, @class types are considered non-trivially destructable, so
Vector needs to see their definition in order to call their destructor.
See <http://clang.llvm.org/docs/AutomaticReferenceCounting.html#ownership-qualified-fields-of-structs-and-unions> for details.
* API/ObjcRuntimeExtras.h: Imported <objc/Protocol.h>.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/API/ObjcRuntimeExtras.h (174385 => 174386)
--- trunk/Source/_javascript_Core/API/ObjcRuntimeExtras.h 2014-10-07 05:26:20 UTC (rev 174385)
+++ trunk/Source/_javascript_Core/API/ObjcRuntimeExtras.h 2014-10-07 06:19:57 UTC (rev 174386)
@@ -23,6 +23,7 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+#import <objc/Protocol.h>
#import <objc/runtime.h>
#import <wtf/HashSet.h>
#import <wtf/Vector.h>
Modified: trunk/Source/_javascript_Core/ChangeLog (174385 => 174386)
--- trunk/Source/_javascript_Core/ChangeLog 2014-10-07 05:26:20 UTC (rev 174385)
+++ trunk/Source/_javascript_Core/ChangeLog 2014-10-07 06:19:57 UTC (rev 174386)
@@ -1,3 +1,17 @@
+2014-10-06 Andy Estes <aes...@apple.com>
+
+ Objective-C objects must be fully defined when used in a WTF::Vector
+ https://bugs.webkit.org/show_bug.cgi?id=137479
+
+ Reviewed by Mark Rowe.
+
+ When compiling an Objective-C++ file under ARC, @class types are considered non-trivially destructable, so
+ Vector needs to see their definition in order to call their destructor.
+
+ See <http://clang.llvm.org/docs/AutomaticReferenceCounting.html#ownership-qualified-fields-of-structs-and-unions> for details.
+
+ * API/ObjcRuntimeExtras.h: Imported <objc/Protocol.h>.
+
2014-10-06 Brent Fulgham <bfulg...@apple.com>
[Win] Use of 1-bit Enum type behaves improperly
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
